Merge pull request #73 from gjrtimmer/fix/chown

fix apply chown permissions in parallel for large workspace
update changelog
2025-06-26 18:27:40 +00:00 · 2021-09-16 13:43:44 -04:00 · 2021-09-16 13:08:53 -04:00 · 2021-09-16 16:56:35 +02:00 · 2021-09-15 22:51:44 +02:00 · 2021-07-14 10:08:05 +02:00
4 changed files with 23 additions and 6 deletions
--- a/README.md
+++ b/README.md
@@ -260,6 +260,7 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64

 ## Versions

+* **16.09.21:** - Fix slow `chown` on large workspace (contents of workspace folder no longer chowned).
 * **11.07.21:** - Bump node to 14 to fix builds
 * **08.05.21:** - Fix doc link
 * **04.02.20:** - Allow setting gui password via hash using env var `HASHED_PASSWORD`.
--- a/package_versions.txt
+++ b/package_versions.txt
@@ -1,7 +1,7 @@
 adduser3.116ubuntu1
 apt1.6.14
 apt-utils1.6.14
-base-files10.1ubuntu2.10
+base-files10.1ubuntu2.11
 base-passwd3.5.44
 bash4.4.18-2ubuntu1.2
 bsdutils1:2.31.1-0.4ubuntu3.7
@@ -20,8 +20,8 @@ fdisk2.31.1-0.4ubuntu3.7
 file1:5.32-2ubuntu0.4
 findutils4.6.0+git+20170828-2
 gcc-8-base8.4.0-1ubuntu1~18.04
-git1:2.17.1-1ubuntu0.8
-git-man1:2.17.1-1ubuntu0.8
+git1:2.17.1-1ubuntu0.9
+git-man1:2.17.1-1ubuntu0.9
 gnupg2.2.4-1ubuntu1.4
 gnupg-l10n2.2.4-1ubuntu1.4
 gnupg-utils2.2.4-1ubuntu1.4
@@ -54,7 +54,7 @@ libc62.27-3ubuntu1.4
 libcap-ng00.7.7-3.1
 libc-bin2.27-3ubuntu1.4
 libcom-err21.44.1-1ubuntu1.3
-libcurl3-gnutls7.58.0-2ubuntu3.14
+libcurl3-gnutls7.58.0-2ubuntu3.15
 libcurl47.58.0-2ubuntu3.14
 libdb5.35.3.28-13.1ubuntu1.1
 libdebconfclient00.213ubuntu1
--- a/readme-vars.yml
+++ b/readme-vars.yml
@@ -75,6 +75,7 @@ app_setup_block: |

 # changelog
 changelogs:
+  - { date: "16.09.21:", desc: "Fix slow `chown` on large workspace (contents of workspace folder no longer chowned)." }
  - { date: "11.07.21:", desc: "Bump node to 14 to fix builds" }
  - { date: "08.05.21:", desc: "Fix doc link" }
  - { date: "04.02.20:", desc: "Allow setting gui password via hash using env var `HASHED_PASSWORD`." }
--- a/root/etc/cont-init.d/30-config
+++ b/root/etc/cont-init.d/30-config
@@ -18,5 +18,20 @@ if [ -n "${SUDO_PASSWORD}" ] || [ -n "${SUDO_PASSWORD_HASH}" ]; then
 fi

 # permissions
-chown -R abc:abc \
-    /config
+if [ -f "/usr/bin/find" ] && [ -f "/usr/bin/xargs" ]; then
+    CORES=$(nproc --all)
+
+    # Split workload between config and workspace
+    echo "setting permissions::configuration"
+    find /config -path /config/workspace -prune -false -o -type d -print0 | \
+        xargs --null -r --max-args=1 --max-procs=$((CORES*2*8)) \
+        chown -R abc:abc
+
+    echo "setting permissions::workspace"
+    chown abc:abc /config/workspace
+else
+    # Set permissions on data mount
+    # do not decend into the workspace
+    chown -R abc:abc "$(ls /config -I workspace)"
+    chown abc:abc /config/workspace
+fi
Author	SHA1	Message	Date
aptalca	44f7b9fc5f	Merge pull request #73 from gjrtimmer/fix/chown fix apply chown permissions in parallel for large workspace	2021-09-16 13:43:44 -04:00
aptalca	442dac7b54	update changelog	2021-09-16 13:08:53 -04:00
G.J.R. Timmer	2ef2329327	fix chown	2021-09-16 16:56:35 +02:00
LinuxServer-CI	e95b42b57a	Bot Updating Package Versions	2021-09-15 22:51:44 +02:00
G.J.R. Timmer	d76a6d56cd	Fix xargs do not run if empty	2021-07-14 10:08:05 +02:00
G.J.R. Timmer	a1608a1d3c	Fix shellcheck warnings	2021-07-14 10:08:05 +02:00
G.J.R. Timmer	b54982550b	fix apply chown permissions in parallel for large workspace	2021-07-14 10:08:05 +02:00