UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-22 08:18:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,350 Commits 20 Branches 73 Tags 28 MiB
ec63533eb1
Commit Graph

1350 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
ec63533eb1 Ensure default config comments are consistent 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-19 14:37:49 +02:00
Evan Lezar
e51621aa7f Handle empty root in config 
If the config.toml has an empty root specified, this could be
passed to the NVIDIA Container CLI through the --root flag
which causes argument parsing to fail. This change only
adds the --root flag if the config option is specified
and is non-empty.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-19 14:02:23 +02:00
Evan Lezar
80a78e60d1 Merge branch 'device-namer' into 'main' 
Refactor device namer

See merge request nvidia/container-toolkit/container-toolkit!453
 2023-07-18 14:16:01 +00:00
Evan Lezar
9f46c34587 Support device name strategies for Tegra devices 
This change generates CDI specifications for Tegra devices
with the nvidia.com/gpu=0 name by default. The type-index
nameing strategy is also supported and will generate a device
with the name nvidia.com/gpu=gpu0.

The uuid naming strategy will raise an error if selected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 16:13:38 +02:00
Evan Lezar
f07a0585fc Refactor device namer 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 16:13:37 +02:00
Evan Lezar
32ec10485e Merge branch 'lookup-functional-options' into 'main' 
Use functional options when creating Symlink and Directory locators

See merge request nvidia/container-toolkit/container-toolkit!452
 2023-07-18 13:39:23 +00:00
Evan Lezar
ce7d5f7a51 Use functional options when constructing direcory locator 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:36:03 +02:00
Evan Lezar
9b64d74f6a Use functional options when constructing Symlink locator 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:31:15 +02:00
Evan Lezar
99cc0aebd6 Merge branch 'pass-image-to-csv-constructor' into 'main' 
Pass image when constructing CSV modifier

See merge request nvidia/container-toolkit/container-toolkit!451
 2023-07-18 13:30:53 +00:00
Evan Lezar
cca343abb0 Pass image when constructing CSV modifier 
Since the incoming OCI spec has already been parsed and used to
construct a CUDA image representation, pass this to the CSV
modifier constructor instead of re-creating an image representation.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:27:16 +02:00
Evan Lezar
f08e48e700 Merge branch 'set-cdi-spec-dirs-in-config' into 'main' 
Set default spec dirs at config level

See merge request nvidia/container-toolkit/container-toolkit!450
 2023-07-18 13:25:29 +00:00
Evan Lezar
e2f8d2a15f Set default spec dirs at config level 
This change sets the default CDI spec dirs at a config level instead
of when a CDI runtime modifier is constructed. This makes this setting
consistent with other options such as the nvidia-ctk path.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:23:09 +02:00
Evan Lezar
2c5761d32e Merge branch 'bug-fixes' into 'main' 
Minor fixes and cleanups

See merge request nvidia/container-toolkit/container-toolkit!449
 2023-07-18 13:20:46 +00:00
Evan Lezar
3c9d95c62f Fix usage string in CLI 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:20:24 +02:00
Evan Lezar
481000b4ce Remove unused argument 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:20:24 +02:00
Evan Lezar
b2126722e5 Update vendoring 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:16:25 +02:00
Evan Lezar
083b789102 Use cdi parser package for IsQualiedName 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-18 15:16:25 +02:00
Evan Lezar
a564b38b7e Merge branch 'remove-centos7-aarch64-scan' into 'main' 
Remove centos7-arm64 scan

See merge request nvidia/container-toolkit/container-toolkit!445
 2023-07-17 14:29:17 +00:00
Evan Lezar
5427249cfc Remove centos7-arm64 scan 
Since we don't publish a centos7-arm64 image, the scan does not
make sense.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-17 16:28:31 +02:00
Evan Lezar
032982ab9c Merge branch 'bump-dependencies' into 'main' 
Bump dependencies

See merge request nvidia/container-toolkit/container-toolkit!444
 2023-07-17 14:13:12 +00:00
Evan Lezar
96aeb9bf64 Update container-device-interface to v0.6.0 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-17 14:12:06 +02:00
Evan Lezar
c98f6ea395 Update containerized docker files for golang 1.20.5 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-17 14:10:05 +02:00
Evan Lezar
073f9cf120 Bump golang version to 1.20.5 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-17 14:06:48 +02:00
Evan Lezar
1fdd0c1248 Merge branch 'bump-changelog' into 'main' 
Fix changelog for 1.14.0-rc.2

See merge request nvidia/container-toolkit/container-toolkit!443
 2023-07-17 12:04:39 +00:00
Evan Lezar
a883c65dd6 Fix changelog for 1.14.0-rc.2 2023-07-17 12:04:38 +00:00
Evan Lezar
aac39f89cc Merge branch 'update-libnvidia-container' into 'main' 
Include Shared Compiler Library (libnvidia-gpucomp.so) in the list of compute libaries.

See merge request nvidia/container-toolkit/container-toolkit!442
 2023-07-13 12:57:40 +00:00
Evan Lezar
e25576d26d Update libnvidia-container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-13 14:15:33 +02:00
Evan Lezar
3626a13273 Merge branch 'fix-disable-require' into 'main' 
Return empty requirements if NVIDIA_DISABLE_REQUIRE is true

See merge request nvidia/container-toolkit/container-toolkit!438
 2023-07-11 11:48:35 +00:00
Evan Lezar
6750ce1667 Print invalid version on parse error 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-11 13:47:39 +02:00
Evan Lezar
1081cecea9 Return empty requirements if NVIDIA_DISABLE_REQUIRE is true 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-11 13:47:37 +02:00
Evan Lezar
7451e6eb75 Merge branch 'custom-firmware-paths' into 'main' 
Add firmware search paths when generating CDI specifications

See merge request nvidia/container-toolkit/container-toolkit!439
 2023-07-11 09:16:33 +00:00
Evan Lezar
81908c8cc9 Search custom firmware paths first 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-11 10:34:14 +02:00
Evan Lezar
d3d41a3e1d Simplify handling of custom firmware path 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-11 10:31:50 +02:00
Evan Lezar
0a37f8798a Add firmware search paths when generating CDI specifications 
Path to locate the GSP firmware is explicitly set to /lib/firmware/nvidia.
Users may chose to install the GSP firmware in alternate locations where
the kernel would look for firmware on the root filesystem.

Add locate functionality which looks for the GSP firmware files in the
same location as the kernel would
(https://docs.kernel.org/driver-api/firmware/fw_search_path.html).

The paths searched in order are:
- path described in /sys/module/firmware_class/parameters/path
- /lib/firmware/updates/UTS_RELEASE/
- /lib/firmware/updates/
- /lib/firmware/UTS_RELEASE/
- /lib/firmware/

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-11 10:31:50 +02:00
Evan Lezar
4f89b60ab9 Merge branch 'remove-experimental-runtime' into 'main' 
Remove NVIDIA experimental runtime from toolkit container

See merge request nvidia/container-toolkit/container-toolkit!238
 2023-07-10 10:25:55 +00:00
Evan Lezar
0938576618 Remove NVIDIA experimental runtime from toolkit container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-10 11:44:55 +02:00
Evan Lezar
4ca8d4173a Merge branch 'revert-d5cbe48d' into 'main' 
Revert "Merge branch 'bump-golang-1.20.5' into 'main'"

See merge request nvidia/container-toolkit/container-toolkit!437
 2023-07-05 15:12:01 +00:00
Evan Lezar
978549dc58 Revert "Merge branch 'bump-golang-1.20.5' into 'main'" 
This reverts merge request !436
 2023-07-05 15:11:41 +00:00
Evan Lezar
d5cbe48d59 Merge branch 'bump-golang-1.20.5' into 'main' 
Bump golang version to 1.20.5

See merge request nvidia/container-toolkit/container-toolkit!436
 2023-07-05 14:07:58 +00:00
Evan Lezar
e8ec795883 Bump golang version to 1.20.5 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 16:07:41 +02:00
Evan Lezar
62bc6b211f Merge branch 'bump-cuda-12.2.0' into 'main' 
Bump cuda base image to 12.2.0

See merge request nvidia/container-toolkit/container-toolkit!435
 2023-07-05 10:11:27 +00:00
Evan Lezar
6fac6c237b Bump cuda base image to 12.2.0 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 11:28:32 +02:00
Evan Lezar
20ff4e2fb9 Merge branch 'generate-default-config-post-install' into 'main' 
Ensure that default config is created on the file system as a post-install step

See merge request nvidia/container-toolkit/container-toolkit!431
 2023-07-05 09:27:29 +00:00
Evan Lezar
f78d3a858f Rework default config generation to not use toml 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 11:26:55 +02:00
Evan Lezar
bc6ca7ff88 Generate default config post-install 
The debian and rpm packages are updated to trigger the generation of
of a default config if no config exists at the expected location.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 11:26:53 +02:00
Evan Lezar
65ae6f1dab Fix generation of default config 
This change ensures that the nvidia-ctk config default command
generates a config file that is compatible with the official documentation
to, for example, disable cgroups in the NVIDIA Container CLI.

This requires that whitespace around comments is stripped before outputing the
contets.

This also adds an option to load a config and modify it in-place instead. This can
be triggered as a post-install step, for example.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 11:26:04 +02:00
Evan Lezar
ba24338122 Add quiet mode to nvidia-ctk cli 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-05 11:26:04 +02:00
Evan Lezar
2299c9588d Merge branch 'create-config-folders' into 'main' 
Ensure that folders exist when creating config files

See merge request nvidia/container-toolkit/container-toolkit!433
 2023-07-05 09:25:28 +00:00
Evan Lezar
ba80d0318f Merge branch 'rpm-fix-missing-coreutils-during-install' into 'main' 
RPM spec: Avoid scriptlet failure during initial system installation

See merge request nvidia/container-toolkit/container-toolkit!432
 2023-07-05 08:43:26 +00:00
Evan Lezar
6342dae0e9 Ensure that parent directories exist for config files 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-07-03 15:30:31 +02:00