UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-25 13:35:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
141 Commits 21 Branches 73 Tags 29 MiB
cc9c3c0d28
Commit Graph

141 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
cc9c3c0d28 Copy scripts from nvidia-container-toolkit-release 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-22 13:42:32 +02:00
Evan Lezar
78f137a5ef Bump version for 1.6.0 development 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-22 13:42:32 +02:00
Evan Lezar
00258f14fb Merge branch 'include-nvidia-container-runtime' into 'master' 
Include nvidia-container-runtime executable in nvidia-container-toolkit

See merge request nvidia/container-toolkit/container-toolkit!45
 2021-09-20 14:54:06 +00:00
Evan Lezar
e828697f90 Update debian and rpm package definitions 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-20 14:54:54 +02:00
Evan Lezar
923344d376 Add PREFIX make variable to control command output 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-13 17:15:34 +02:00
Evan Lezar
35c6559013 Make all commands and copy executables 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-13 17:15:19 +02:00
Evan Lezar
eb67968911 Add cmds target to makefile to build all go commands 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-13 17:08:31 +02:00
Evan Lezar
6e1436cefb Update go vendoring 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-07 13:13:03 +02:00
Evan Lezar
10cd42273e Update package references 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-07 13:13:03 +02:00
Evan Lezar
b6a585c77d Copy code from nvidia-container-runtime 
This change copies the cmd/nvidia-container-runtime, internal, and test
folders from github.com/NVIDIA/nvidia-container-runtime@8a63b4b34f3ce3b4167f0516aa3f7207ca280dfb

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-07 13:13:03 +02:00
Evan Lezar
58e707fed6 Bump version for post 1.5.1 development 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-09-07 13:12:25 +02:00
Evan Lezar
28ee3d5fd5 Merge branch 'revert-nvlink' into 'master' 
Revert support for NVIDIA_FABRIC_DEVICES

See merge request nvidia/container-toolkit/container-toolkit!41
 2021-08-20 08:39:49 +00:00
Evan Lezar
c2ac6db43b Revert "Add support for NVIDIA_FABRIC_DEVICES" 
This reverts commit f828efcf64.
 2021-08-18 15:17:59 +02:00
Evan Lezar
620bd806e8 Revert "Bump version to 1.6.0~rc.1" 
This reverts commit 2001d66f9b.
 2021-08-18 15:17:37 +02:00
Evan Lezar
afe0f8b61f Merge branch 'release-1.6.0-rc.1' into 'master' 
Bump version to 1.6.0~rc.1

See merge request nvidia/container-toolkit/container-toolkit!40
 2021-08-16 10:27:11 +00:00
Evan Lezar
2001d66f9b Bump version to 1.6.0~rc.1 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-08-13 14:55:28 +02:00
Evan Lezar
7626578b8e Merge branch 'nvlink' into 'master' 
Add support for NVIDIA_FABRIC_DEVICES

See merge request nvidia/container-toolkit/container-toolkit!39
 2021-08-12 14:04:10 +00:00
Evan Lezar
f828efcf64 Add support for NVIDIA_FABRIC_DEVICES 
This change adds support for the NVIDIA_FABRIC_DEVICES envvar. The (non-empty)
value of this envvar is passed to the NVIDIA Container CLI using the --fabric-device
command line flag and allows for nvswitch and nvlink devices to be mounted
into the container.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-08-11 10:33:55 +02:00
Evan Lezar
faf0df66c7 Merge branch 'improve-ci' into 'master' 
Improve CI for container toolkit

See merge request nvidia/container-toolkit/container-toolkit!38
 2021-07-15 15:40:56 +00:00
Evan Lezar
1ef4b1a14a Use extends keyword for build-one and build-all 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-07-15 16:27:17 +02:00
Evan Lezar
3df0969349 Improve CI for container toolkit 
This change improves the CI for the container toolkit. The go targets are
executed in a docker container which allows for reproducible behaviour on
local systems as well as CI. The Makefile is updated to facilitate this.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-07-15 16:27:15 +02:00
Evan Lezar
22fcd022f3 Merge branch 'upstream-bump-v1.5.1' into 'master' 
Bump to version 1.5.1

See merge request nvidia/container-toolkit/container-toolkit!35
 2021-06-14 18:35:45 +00:00
Evan Lezar
492905de38 Bump to version 1.5.1 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-14 17:16:44 +02:00
Evan Lezar
17e76cad4d Merge branch 'make-binary-goos-explicit' into 'master' 
Explicitly set GOOS when building binary

See merge request nvidia/container-toolkit/container-toolkit!33
 2021-06-14 10:12:24 +00:00
Evan Lezar
c728bf4b1e Explicitly set GOOS when building binary 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-10 10:40:06 +02:00
Evan Lezar
f05e4e81c5 Merge branch 'fix-go-install' into 'master' 
Move pkg to cmd/nvidia-container-toolkit

See merge request nvidia/container-toolkit/container-toolkit!32
 2021-06-08 15:21:06 +00:00
Evan Lezar
14cd7c1833 Add coverage step to CI 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-08 15:23:19 +02:00
Evan Lezar
f72b79cc2a Move pkg to cmd/nvidia-container-toolkit 
This change moves the pkg folder to `cmd/nvidia-container-toolkit` to
better match go best practices. This allows, for example, for the
`cmd/nvidia-container-toolkit` to be go installed.

The only package included in `pkg` was `main`.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-08 15:20:59 +02:00
Evan Lezar
f25698e96e Run go mod vendor and go mod tidy 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-08 10:51:33 +02:00
Evan Lezar
a02f7f8f6f Merge branch 'CNT-1554/docker-swarm' into 'master' 
Fix bug where docker swarm device selection is overriden by NVIDIA_VISIBLE_DEVICES

See merge request nvidia/container-toolkit/container-toolkit!31
 2021-06-08 05:31:05 +00:00
Evan Lezar
2a92d6acb7 Fix bug where docker swarm device selection is overriden by NVIDIA_VISIBLE_DEVICES 
This change fixes a bug where the value of NVIDIA_VISIBLE_DEVICES would be used to
select devices even if the `swarm-resource` config option is specified.

Note that this does not change the value of NVIDIA_VISIBLE_DEVICES in the container.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-07 14:10:08 +02:00
Evan Lezar
602eaf0e60 Use require package for tests 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-07 13:31:41 +02:00
Evan Lezar
b930487dc5 Add coverage to go tests 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-07 13:21:28 +02:00
Evan Lezar
9aac07fe64 Update vendoring 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-06-07 13:20:34 +02:00
Evan Lezar
825990ba41 Merge branch 'CNT-1334-publish-tags-to-artifactory' into 'master' 
Add artifactory publish step

See merge request nvidia/container-toolkit/container-toolkit!30
 2021-05-18 17:25:07 +00:00
Evan Lezar
03d9c1d698 Update to Golang 1.16.3 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-05-18 11:25:52 +02:00
Evan Lezar
de172674b1 Add artifactory publish step 
This change simplifies the build process by only targetting ubuntu20.04-amd64
and adds logic to push tagged builds to artifactory.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-05-18 11:25:48 +02:00
Kevin Klues
b71a9ed153 Merge branch 'upstream-bump-v1.5.0' into 'master' 
Bump version to 1.5.0

See merge request nvidia/container-toolkit/container-toolkit!29
 2021-04-29 14:08:23 +00:00
Kevin Klues
dde7159e11 Bump version to 1.5.0 
Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-04-29 10:16:44 +00:00
Evan Lezar
46de426cc4 Merge branch 'CNT-1330/jenkins-ci' into 'master' 
Add Jenkins file for CI build steps

See merge request nvidia/container-toolkit/container-toolkit!28
 2021-03-18 10:06:44 +00:00
Evan Lezar
1c7d6a233a Add golang check targets 
This change adds check targets for Golang to the make file. These are also
added as stages to the to the Jenkinsfile definition and the GitLab CI
is modified to use them too.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-03-17 16:58:39 +01:00
Evan Lezar
635aeb8343 Add Jenkinsfile definition for build targets 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-03-17 13:52:19 +01:00
Evan Lezar
ec9d296afe Move docker.mk to docker folder 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-03-17 13:52:14 +01:00
Evan Lezar
ff44395b31 Merge branch 'upstream-bump-v1.4.2' into 'master' 
Bump version to 1.4.2

See merge request nvidia/container-toolkit/container-toolkit!27
 2021-02-05 12:47:01 +00:00
Kevin Klues
8571e5ac5d Bump version to 1.4.2 
Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-02-05 10:26:10 +00:00
Kevin Klues
108c99bb9b Merge branch 'upstream-bump-v1.4.1' into 'master' 
Bump version to 1.4.1

See merge request nvidia/container-toolkit/container-toolkit!26
 2021-01-25 13:35:42 +00:00
Kevin Klues
dfb5daf200 Bump version to 1.4.1 
Signed-off-by: Kevin Klues <kklues@nvidia.com>
 2021-01-25 10:42:32 +00:00
Kevin Klues
e8aa3cc8c3 Merge branch 'ignore-nvidia-visible-devices' into 'master' 
Ignore NVIDIA_VISIBLE_DEVICES for containers with insufficent privileges

See merge request nvidia/container-toolkit/container-toolkit!25
 2021-01-25 10:25:00 +00:00
Evan Lezar
fc408a32c7 Add utility function to get config name from struct 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-01-22 16:08:45 +01:00
Evan Lezar
f6b1b1afad Ignore NVIDIA_VISIBLE_DEVICES for containers with insufficent privileges 
This change ignores the value of NVIDIA_VISIBLE_DEVICES instead of
raising an error when launching a container with insufficient permissions.

This changes the behaviour under the following conditions:

NVIDIA_VISIBLE_DEVICES is set
and

accept-nvidia-visible-devices-envvar-when-unprivileged = false (default: true)

or

privileged = false (default: false)

This means that a user need not explicitly clear the NVIDIA_VISIBLE_DEVICES
environment variable if no GPUs are to be used in unprivileged containers.
Note that this envvar is set to 'all' by default in many CUDA images that
are used as base images.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2021-01-22 15:34:52 +01:00