nvidia-container-toolkit

mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2025-04-04 12:50:54 +00:00

Author	SHA1	Message	Date
Evan Lezar	03152dba8d	Allow cdi mode to work with --gpus flag This changes ensures that the cdi modifier also removes the NVIDIA Container Runtime Hook from the incoming spec. This aligns with what is done for CSV modifications and prevents an error when starting the container. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 19:01:43 +01:00
Evan Lezar	cf026dce9a	[no-relnote] Remove duplicate test case Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 19:01:43 +01:00
Evan Lezar	073fb138d7	Merge pull request #900 from elezar/fix-make-target Some checks are pending CodeQL / Analyze Go code with CodeQL (push) Waiting to run Details Golang / check (push) Waiting to run Details Golang / Unit test (push) Waiting to run Details Golang / Build (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, centos7-aarch64) (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, centos7-x86_64) (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, centos8-ppc64le) (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, ubuntu18.04-amd64) (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, ubuntu18.04-arm64) (push) Waiting to run Details image / packages (${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}, ubuntu18.04-ppc64le) (push) Waiting to run Details image / image (packaging, ${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}) (push) Blocked by required conditions Details image / image (ubi8, ${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}) (push) Blocked by required conditions Details image / image (ubuntu20.04, ${{ github.ref_name != 'main' && !startsWith( github.ref_name, 'release-' ) }}) (push) Blocked by required conditions Details [no-relnote] Fix e2e test make target	2025-02-05 19:01:20 +01:00
Evan Lezar	948bc113f0	[no-relnote] Fix e2e test make target Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 19:00:40 +01:00
Evan Lezar	b457247a0c	Merge pull request #895 from ArangoGutierrez/reg_test03 Add E2E GitHub Action for Container Toolkit	2025-02-05 17:51:18 +01:00
Evan Lezar	bae4b3ebd3	[no-relnote] Wait on image Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 17:28:29 +01:00
Evan Lezar	3a06066f6b	[no-relnote] Simplify multi-arch checks Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 16:46:29 +01:00
Evan Lezar	c0292f5048	[no-relnote] Use nvcr.io/nvidia/cuda Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 16:26:09 +01:00
Carlos Eduardo Arango Gutierrez	cd8937bc5b	Add E2E GitHub Action for Container Toolkit Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>	2025-02-05 16:22:14 +01:00
Evan Lezar	cec3445318	Merge pull request #897 from elezar/fix-copy-prs Fix detection of PRs	2025-02-05 16:21:44 +01:00
Evan Lezar	f830653738	[no-relnote] Remove unused LABEL_IMAGE_SOURCE Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 16:13:16 +01:00
Evan Lezar	6e9ff446c8	[no-relnote] Use github.ref_name to detect PRs Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 16:13:16 +01:00
Evan Lezar	9a07de0ee8	Merge pull request #896 from elezar/onboard-pr-copy-bot [no-relnote] Enable pr-copy-bot	2025-02-05 15:55:49 +01:00
Evan Lezar	517873e97d	[no-relnote] Enable pr-copy-bot Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-02-05 15:55:12 +01:00
Carlos Eduardo Arango Gutierrez	78d6cdc7f7	Merge pull request #876 from ArangoGutierrez/reg_test02 Some checks are pending CodeQL / Analyze Go code with CodeQL (push) Waiting to run Details Golang / check (push) Waiting to run Details Golang / Unit test (push) Waiting to run Details Golang / Build (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Waiting to run Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details Add remote-test option for E2E	2025-02-04 18:33:34 +01:00
Carlos Eduardo Arango Gutierrez	61640591ba	Add remote-test option for E2E Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>	2025-02-04 15:05:46 +01:00
Evan Lezar	df4c87b877	Merge pull request #838 from cdesiniotis/enable-cdi-toolkit-container Some checks are pending CodeQL / Analyze Go code with CodeQL (push) Waiting to run Details Golang / check (push) Waiting to run Details Golang / Unit test (push) Waiting to run Details Golang / Build (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Waiting to run Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details Enable CDI in the container runtime if enabled in the toolkit	2025-02-03 16:37:49 +01:00
Tariq	d6c312956b	Merge pull request #887 from NVIDIA/latest-qemu Some checks failed CodeQL / Analyze Go code with CodeQL (push) Has been cancelled Details Golang / check (push) Has been cancelled Details Golang / Unit test (push) Has been cancelled Details Golang / Build (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Has been cancelled Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details [no-relnote] switch to the newer qemu artifacts image	2025-01-31 10:33:38 -05:00
Tariq Ibrahim	51f765dd71	[no-relnote] switch to the newer qemu artifacts image Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>	2025-01-31 09:28:30 -05:00
Evan Lezar	d8cd5438e4	[no-relnote] Add basic cdi-enabled tests Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-29 15:37:32 +01:00
Evan Lezar	5ed25bb375	[no-relnote] Add unit test for installer command This change adds a basic unit test for the nvidia-ckt-installer command. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-29 15:37:32 +01:00
Evan Lezar	a7786d4d41	Enable CDI in runtime if CDI_ENABLED is set This change also enables CDI in the configured runtime when the toolkit is installed with CDI enabled. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-29 15:37:32 +01:00
Evan Lezar	be1ac24f2a	Merge pull request #882 from NVIDIA/dependabot/docker/deployments/container/main/nvidia/cuda-12.8.0-base-ubuntu20.04 Some checks failed CodeQL / Analyze Go code with CodeQL (push) Has been cancelled Details Golang / check (push) Has been cancelled Details Golang / Unit test (push) Has been cancelled Details Golang / Build (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Has been cancelled Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details Bump nvidia/cuda from 12.6.3-base-ubuntu20.04 to 12.8.0-base-ubuntu20.04 in /deployments/container	2025-01-29 14:11:47 +01:00
dependabot[bot]	dd86f598b5	Bump nvidia/cuda in /deployments/container Bumps nvidia/cuda from 12.6.3-base-ubuntu20.04 to 12.8.0-base-ubuntu20.04. --- updated-dependencies: - dependency-name: nvidia/cuda dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2025-01-28 08:57:31 +00:00
Evan Lezar	2b417c1a9a	Fix overwriting docker feature flags Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-27 15:52:08 +01:00
Christopher Desiniotis	e89be14c86	Add option in toolkit container to enable CDI in runtime Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>	2025-01-27 15:52:08 +01:00
Evan Lezar	f625242ed6	Remove Set from engine config API Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-27 15:52:08 +01:00
Christopher Desiniotis	df73db7e1e	Add EnableCDI() method to engine.Interface This change adds an EnableCDI method to the container engine config files and Updates the 'nvidia-ctk runtime configure' command to use this new method. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>	2025-01-27 15:51:23 +01:00
Evan Lezar	89f33bdf71	Merge pull request #881 from elezar/add-imex-binaries Some checks failed CodeQL / Analyze Go code with CodeQL (push) Has been cancelled Details Golang / check (push) Has been cancelled Details Golang / Unit test (push) Has been cancelled Details Golang / Build (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Has been cancelled Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details Add IMEX binaries to CDI discovery	2025-01-27 13:27:58 +01:00
Evan Lezar	6834d5e0a4	Merge pull request #879 from NVIDIA/dependabot/submodules/main/third_party/libnvidia-container-95d3e86 Some checks failed CodeQL / Analyze Go code with CodeQL (push) Has been cancelled Details Golang / check (push) Has been cancelled Details Golang / Unit test (push) Has been cancelled Details Golang / Build (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Has been cancelled Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details Bump third_party/libnvidia-container from `f23e5e5` to `95d3e86`	2025-01-24 18:30:23 +01:00
Evan Lezar	c91a1b1dc8	Add IMEX binaries to CDI discovery This change adds the nvidia-imex and nivdia-imex-ctl binaries to the list of driver binaries that are searched when using CDI. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-24 14:46:31 +01:00
dependabot[bot]	96d91df78e	Bump third_party/libnvidia-container from `f23e5e5` to `95d3e86` Bumps [third_party/libnvidia-container](https://github.com/NVIDIA/libnvidia-container) from `f23e5e5` to `95d3e86`. - [Release notes](https://github.com/NVIDIA/libnvidia-container/releases) - [Commits](`f23e5e55ea...95d3e86522`) --- updated-dependencies: - dependency-name: third_party/libnvidia-container dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2025-01-24 09:05:17 +00:00
Carlos Eduardo Arango Gutierrez	a990860bfa	Merge pull request #873 from ArangoGutierrez/tests_rename Some checks failed CodeQL / Analyze Go code with CodeQL (push) Has been cancelled Details Golang / check (push) Has been cancelled Details Golang / Unit test (push) Has been cancelled Details Golang / Build (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Has been cancelled Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Has been cancelled Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Has been cancelled Details Rename test folder to tests	2025-01-23 11:54:59 +01:00
Carlos Eduardo Arango Gutierrez	bf9d618ff2	Rename test folder to tests Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-23 11:46:14 +01:00
Evan Lezar	7ae5c2901f	Merge commit from fork Disable mounting of compat libs from container by default	2025-01-23 10:56:32 +01:00
Evan Lezar	6b236746ce	Bump libnvidia-container to f23e5e55 Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-23 10:51:32 +01:00
Evan Lezar	ed3b52eb8d	Add allow-cuda-compat-libs-from-container feature flag This change adds an allow-cuda-compat-libs-from-container feature flag to the NVIDIA Container Toolkit config. This allows a user to opt-in to the previous default behaviour of overriding certain driver libraries with CUDA compat libraries from the container. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-22 17:34:20 +01:00
Evan Lezar	1176430278	Disable mounting of compat libs from container This change passes the --no-cntlibs argument to the nvidia-container-cli from the nvidia-container-runtime-hook to disable overwriting host drivers with the compat libs from a container being started. Note that this may be a breaking change for some applications. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-22 17:34:20 +01:00
Evan Lezar	c22f3bd56c	Merge pull request #765 from elezar/use-logger-in-toolkit-install Some checks are pending CodeQL / Analyze Go code with CodeQL (push) Waiting to run Details Golang / check (push) Waiting to run Details Golang / Unit test (push) Waiting to run Details Golang / Build (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-aarch64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos7-x86_64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, centos8-ppc64le) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-amd64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-arm64) (push) Waiting to run Details image / packages (${{github.event_name == 'pull_request'}}, ubuntu18.04-ppc64le) (push) Waiting to run Details image / image (packaging, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubi8, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details image / image (ubuntu20.04, ${{github.event_name == 'pull_request'}}) (push) Blocked by required conditions Details Simplify standalone installer	2025-01-22 14:42:50 +01:00
Evan Lezar	6375e832ff	Merge pull request #874 from elezar/skip-graphics-for-csv Skip graphics modifier in CSV mode	2025-01-22 14:37:07 +01:00
Evan Lezar	991b9c222f	Skip graphics modifier in CSV mode In CSV mode the CSV files at /etc/nvidia-container-runtime/host-files-for-container.d/ should be the source of truth for container modifications. This change skips graphics modifications to a container. This prevents conflicts when handling files such as vulkan icd files which are already defined in the CSV file. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-22 13:58:31 +01:00
Evan Lezar	fdad3927b4	[no-relnote] Refactor oci spec modifier list Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-22 13:58:31 +01:00
Evan Lezar	6bd292eff8	[no-relnote] Move tools/container to cmd/nvidia-ctk-installer Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:28:46 +01:00
Evan Lezar	9429ce039b	[no-relnote] Rename run.go to main.go Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:28:46 +01:00
Evan Lezar	d953bbb977	Move nvidia-toolkit to nvidia-ctk-installer This change moves the containerized installer from nvidia-toolkit to cmd/nvidia-ctk-installer to allow for its use in CI. Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:28:44 +01:00
Evan Lezar	5cbf3f82d9	[no-relnote] Move fileinstaller to separate file Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:27:21 +01:00
Evan Lezar	69375d7889	[no-relnote] Use logger in toolkit installation Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:27:21 +01:00
Evan Lezar	9753096398	[no-relnote] Add app struct for nvidia-toolkit Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:27:21 +01:00
Evan Lezar	76edd1d7ca	[no-relnote] Remove unused TryDelete function Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:27:21 +01:00
Evan Lezar	a6476193c8	[no-relnote] Merge verifyFlags and validateFlags Signed-off-by: Evan Lezar <elezar@nvidia.com>	2025-01-21 14:27:21 +01:00

1 2 3 4 5 ...

2151 Commits