UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-22 00:08:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #313 from elezar/fix-update-ldconfig

Browse Source 
Fix bug in update-ldcache hook
This commit is contained in:
Carlos Eduardo Arango Gutierrez 2024-01-29 18:24:33 +01:00 committed by GitHub
commit 21ed60bc46
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/nvidia-ctk/hook/update-ldcache/update-ldcache.go
View File

@ -17,6 +17,7 @@
package ldcache
import (
"errors"
"fmt"
"os"
"path/filepath"
@ -56,6 +57,9 @@ func (m command) build() *cli.Command {
c := cli.Command{
Name: "update-ldcache",
Usage: "Update ldcache in a container by running ldconfig",
Before: func(c *cli.Context) error {
return m.validateFlags(c, &cfg)
},
Action: func(c *cli.Context) error {
return m.run(c, &cfg)
},
@ -71,7 +75,7 @@ func (m command) build() *cli.Command {
Name: "ldconfig-path",
Usage: "Specify the path to the ldconfig program",
Destination: &cfg.ldconfigPath,
DefaultText: "/sbin/ldconfig",
Value: "/sbin/ldconfig",
},
&cli.StringFlag{
Name: "container-spec",
@ -83,6 +87,13 @@ func (m command) build() *cli.Command {
return &c
}
func (m command) validateFlags(c *cli.Context, cfg *options) error {
if cfg.ldconfigPath == "" {
return errors.New("ldconfig-path must be specified")
}
return nil
}
func (m command) run(c *cli.Context, cfg *options) error {
s, err := oci.LoadContainerState(cfg.containerSpec)
if err != nil {