fix: apply feedback updates

This commit is contained in:
yassinedorbozgithub
2025-01-27 08:31:50 +01:00
parent 0d97d78ab4
commit db8d41166b
14 changed files with 32 additions and 32 deletions

View File

@@ -114,10 +114,10 @@ const AttachmentThumbnail: FC<AttachmentThumbnailProps> = ({
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.ATTACHMENT}
onDeleteError={() => {
onError={() => {
toast.error(t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
toast.success(t("message.success_save"));
onChange?.(null);
}}

View File

@@ -28,19 +28,19 @@ export type DeleteDialogProps<T extends string = string> = DialogControl<T>;
export const DeleteDialog = <T extends string = string>({
data: ids,
entity = EntityType.ATTACHMENT,
onDeleteError = () => {},
onDeleteSuccess = () => {},
onError = () => {},
onSuccess = () => {},
...rest
}: DeleteDialogProps<T> & {
entity?: keyof IEntityMapTypes;
onDeleteError?: (error: Error) => void;
onDeleteSuccess?: (data?: unknown) => void;
onError?: (error: Error) => void;
onSuccess?: (data?: unknown) => void;
}) => {
const { t } = useTranslate();
const options = {
onError: onDeleteError,
onError,
onSuccess: (data: unknown) => {
onDeleteSuccess(data);
onSuccess(data);
rest.reset?.();
},
};

View File

@@ -109,10 +109,10 @@ export const Categories = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.CATEGORY}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error.message || t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -108,10 +108,10 @@ export const ContentTypes = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.CONTENT_TYPE}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error.message || t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -163,7 +163,7 @@ export const Contents = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.CONTENT}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -141,10 +141,10 @@ export const ContextVars = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.CONTEXT_VAR}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error);
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -143,10 +143,10 @@ export const Labels = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.LABEL}
onDeleteError={() => {
onError={() => {
toast.error(t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -170,10 +170,10 @@ export const Languages = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.LANGUAGE}
onDeleteError={() => {
onError={() => {
toast.error(t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
queryClient.removeQueries({
predicate: ({ queryKey }) => {
const [_qType, qEntity] = queryKey;

View File

@@ -153,10 +153,10 @@ const NlpEntity = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.NLP_ENTITY}
onDeleteError={() => {
onError={() => {
toast.error(t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -232,8 +232,8 @@ export default function NlpSample() {
val.value === NlpSampleType.train
? "enabled"
: val.value === NlpSampleType.inbox
? "inbox"
: "test"
? "inbox"
: "test"
}
/>
),
@@ -276,10 +276,10 @@ export default function NlpSample() {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.NLP_SAMPLE}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error);
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -202,10 +202,10 @@ export const NlpValues = ({ entityId }: { entityId: string }) => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.NLP_VALUE}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error);
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -122,10 +122,10 @@ export const Roles = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.ROLE}
onDeleteError={(error) => {
onError={(error) => {
toast.error(error);
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -158,10 +158,10 @@ export const Translations = () => {
<DeleteDialog
{...deleteDialogCtl}
entity={EntityType.TRANSLATION}
onDeleteError={() => {
onError={() => {
toast.error(t("message.internal_server_error"));
}}
onDeleteSuccess={() => {
onSuccess={() => {
deleteDialogCtl.closeDialog();
toast.success(t("message.item_delete_success"));
}}

View File

@@ -16,7 +16,7 @@ type TCloseDialog = <E extends React.MouseEvent | Event | Object>(
) => void;
type TFnVoid<T> = (data?: T) => void;
type TStatesMode = "datumOrData" | "datumAndData";
export type DialogControl<T = never> = DialogProps & {
export type DialogControl<T = never> = Omit<DialogProps, "onError"> & {
data?: T[];
datum?: T;
reset?: () => void;