fix: add warn message to not found resource

This commit is contained in:
Mohamed Marrouchi
2025-05-09 15:58:16 +01:00
parent 0db40680dc
commit 5ddc257492
2 changed files with 7 additions and 2 deletions

View File

@@ -311,6 +311,7 @@ export default abstract class ChannelHandler<
const [name, _suffix] = this.getName().split('-');
if ('id' in attachment) {
if (!attachment || !attachment.id) {
this.logger.warn('Unable to build public URL: Empty attachment ID');
return buildURL(config.apiBaseUrl, `/webhook/${name}/not-found`);
}
@@ -330,6 +331,10 @@ export default abstract class ChannelHandler<
// In case the url is external
return attachment.url;
} else {
this.logger.warn(
'Unable to resolve the attachment public URL.',
attachment,
);
return buildURL(config.apiBaseUrl, `/webhook/${name}/not-found`);
}
}

View File

@@ -1,5 +1,5 @@
/*
* Copyright © 2024 Hexastack. All rights reserved.
* Copyright © 2025 Hexastack. All rights reserved.
*
* Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms:
* 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission.
@@ -92,6 +92,6 @@ export class WebhookController {
@Roles('public')
@Get(':channel/not-found')
async handleNotFound(@Res() res: Response) {
return res.status(404).send({ error: 'Not found!' });
return res.status(404).send({ error: 'Resource not found!' });
}
}