fix: prevent update_user_settings_by_id crash when user is None (#20278)

Get user first and check for None before accessing .settings attribute. Returns None gracefully instead of crashing with AttributeError.
This commit is contained in:
Classic298
2025-12-31 08:30:31 +01:00
committed by GitHub
parent 2c0ebbcced
commit 07cbc52c9a

View File

@@ -613,7 +613,11 @@ class UsersTable:
def update_user_settings_by_id(self, id: str, updated: dict, db: Optional[Session] = None) -> Optional[UserModel]:
try:
with get_db_context(db) as db:
user_settings = db.query(User).filter_by(id=id).first().settings
user = db.query(User).filter_by(id=id).first()
if not user:
return None
user_settings = user.settings
if user_settings is None:
user_settings = {}