fix: change for in to for of to access to real value instead of the index

This commit is contained in:
Mauricio Siu
2024-05-01 17:42:52 -06:00
parent 307ae22117
commit ad58cce2cd
3 changed files with 74 additions and 73 deletions

View File

@@ -6,35 +6,35 @@ import type { WriteStream } from "node:fs";
// TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
export const buildHeroku = async ( export const buildHeroku = async (
application: ApplicationNested, application: ApplicationNested,
writeStream: WriteStream, writeStream: WriteStream,
) => { ) => {
const { env, appName } = application; const { env, appName } = application;
const buildAppDirectory = getBuildAppDirectory(application); const buildAppDirectory = getBuildAppDirectory(application);
const envVariables = prepareEnvironmentVariables(env); const envVariables = prepareEnvironmentVariables(env);
try { try {
const args = [ const args = [
"build", "build",
appName, appName,
"--path", "--path",
buildAppDirectory, buildAppDirectory,
"--builder", "--builder",
"heroku/builder:22", "heroku/builder:22",
]; ];
for (const env in envVariables) { for (const env of envVariables) {
args.push("--env", env); args.push("--env", env);
} }
await spawnAsync("pack", args, (data) => { await spawnAsync("pack", args, (data) => {
if (writeStream.writable) { if (writeStream.writable) {
writeStream.write(data); writeStream.write(data);
} }
// Stream the data // Stream the data
console.log(data); console.log(data);
}); });
return true; return true;
} catch (e) { } catch (e) {
throw e; throw e;
} }
}; };

View File

@@ -6,25 +6,26 @@ import type { WriteStream } from "node:fs";
// TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
export const buildNixpacks = async ( export const buildNixpacks = async (
application: ApplicationNested, application: ApplicationNested,
writeStream: WriteStream, writeStream: WriteStream,
) => { ) => {
const { env, appName } = application; const { env, appName } = application;
const buildAppDirectory = getBuildAppDirectory(application); const buildAppDirectory = getBuildAppDirectory(application);
const envVariables = prepareEnvironmentVariables(env); const envVariables = prepareEnvironmentVariables(env);
try { try {
const args = ["build", buildAppDirectory, "--name", appName]; const args = ["build", buildAppDirectory, "--name", appName];
for (const env in envVariables) { for (const env of envVariables) {
args.push("--env", env); args.push("--env", env);
} }
await spawnAsync("nixpacks", args, (data) => {
if (writeStream.writable) { await spawnAsync("nixpacks", args, (data) => {
writeStream.write(data); if (writeStream.writable) {
} writeStream.write(data);
}); }
return true; });
} catch (e) { return true;
throw e; } catch (e) {
} throw e;
}
}; };

View File

@@ -6,33 +6,33 @@ import { prepareEnvironmentVariables } from "../docker/utils";
// TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
export const buildPaketo = async ( export const buildPaketo = async (
application: ApplicationNested, application: ApplicationNested,
writeStream: WriteStream, writeStream: WriteStream,
) => { ) => {
const { env, appName } = application; const { env, appName } = application;
const buildAppDirectory = getBuildAppDirectory(application); const buildAppDirectory = getBuildAppDirectory(application);
const envVariables = prepareEnvironmentVariables(env); const envVariables = prepareEnvironmentVariables(env);
try { try {
const args = [ const args = [
"build", "build",
appName, appName,
"--path", "--path",
buildAppDirectory, buildAppDirectory,
"--builder", "--builder",
"paketobuildpacks/builder-jammy-full", "paketobuildpacks/builder-jammy-full",
]; ];
for (const env in envVariables) { for (const env of envVariables) {
args.push("--env", env); args.push("--env", env);
} }
await spawnAsync("pack", args, (data) => { await spawnAsync("pack", args, (data) => {
if (writeStream.writable) { if (writeStream.writable) {
writeStream.write(data); writeStream.write(data);
} }
}); });
return true; return true;
} catch (e) { } catch (e) {
throw e; throw e;
} }
}; };