From ad58cce2cda402cdc0380251ab1162ab823a11fb Mon Sep 17 00:00:00 2001
From: Mauricio Siu <47042324+Siumauricio@users.noreply.github.com>
Date: Wed, 1 May 2024 17:42:52 -0600
Subject: [PATCH]  fix: change for in to for of to access to real value instead
 of the index

---
 server/utils/builders/heroku.ts   | 56 +++++++++++++++----------------
 server/utils/builders/nixpacks.ts | 39 ++++++++++-----------
 server/utils/builders/paketo.ts   | 52 ++++++++++++++--------------
 3 files changed, 74 insertions(+), 73 deletions(-)

diff --git a/server/utils/builders/heroku.ts b/server/utils/builders/heroku.ts
index bf598c42..bd2ed543 100644
--- a/server/utils/builders/heroku.ts
+++ b/server/utils/builders/heroku.ts
@@ -6,35 +6,35 @@ import type { WriteStream } from "node:fs";
 
 // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
 export const buildHeroku = async (
-  application: ApplicationNested,
-  writeStream: WriteStream,
+	application: ApplicationNested,
+	writeStream: WriteStream,
 ) => {
-  const { env, appName } = application;
-  const buildAppDirectory = getBuildAppDirectory(application);
-  const envVariables = prepareEnvironmentVariables(env);
-  try {
-    const args = [
-      "build",
-      appName,
-      "--path",
-      buildAppDirectory,
-      "--builder",
-      "heroku/builder:22",
-    ];
+	const { env, appName } = application;
+	const buildAppDirectory = getBuildAppDirectory(application);
+	const envVariables = prepareEnvironmentVariables(env);
+	try {
+		const args = [
+			"build",
+			appName,
+			"--path",
+			buildAppDirectory,
+			"--builder",
+			"heroku/builder:22",
+		];
 
-    for (const env in envVariables) {
-      args.push("--env", env);
-    }
+		for (const env of envVariables) {
+			args.push("--env", env);
+		}
 
-    await spawnAsync("pack", args, (data) => {
-      if (writeStream.writable) {
-        writeStream.write(data);
-      }
-      // Stream the data
-      console.log(data);
-    });
-    return true;
-  } catch (e) {
-    throw e;
-  }
+		await spawnAsync("pack", args, (data) => {
+			if (writeStream.writable) {
+				writeStream.write(data);
+			}
+			// Stream the data
+			console.log(data);
+		});
+		return true;
+	} catch (e) {
+		throw e;
+	}
 };
diff --git a/server/utils/builders/nixpacks.ts b/server/utils/builders/nixpacks.ts
index 798fac33..d3439faa 100644
--- a/server/utils/builders/nixpacks.ts
+++ b/server/utils/builders/nixpacks.ts
@@ -6,25 +6,26 @@ import type { WriteStream } from "node:fs";
 
 // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
 export const buildNixpacks = async (
-  application: ApplicationNested,
-  writeStream: WriteStream,
+	application: ApplicationNested,
+	writeStream: WriteStream,
 ) => {
-  const { env, appName } = application;
-  const buildAppDirectory = getBuildAppDirectory(application);
-  const envVariables = prepareEnvironmentVariables(env);
-  try {
-    const args = ["build", buildAppDirectory, "--name", appName];
+	const { env, appName } = application;
+	const buildAppDirectory = getBuildAppDirectory(application);
+	const envVariables = prepareEnvironmentVariables(env);
+	try {
+		const args = ["build", buildAppDirectory, "--name", appName];
 
-    for (const env in envVariables) {
-      args.push("--env", env);
-    }
-    await spawnAsync("nixpacks", args, (data) => {
-      if (writeStream.writable) {
-        writeStream.write(data);
-      }
-    });
-    return true;
-  } catch (e) {
-    throw e;
-  }
+		for (const env of envVariables) {
+			args.push("--env", env);
+		}
+
+		await spawnAsync("nixpacks", args, (data) => {
+			if (writeStream.writable) {
+				writeStream.write(data);
+			}
+		});
+		return true;
+	} catch (e) {
+		throw e;
+	}
 };
diff --git a/server/utils/builders/paketo.ts b/server/utils/builders/paketo.ts
index 8baf90a2..b1b9b0a9 100644
--- a/server/utils/builders/paketo.ts
+++ b/server/utils/builders/paketo.ts
@@ -6,33 +6,33 @@ import { prepareEnvironmentVariables } from "../docker/utils";
 
 // TODO: integrate in the vps sudo chown -R $(whoami) ~/.docker
 export const buildPaketo = async (
-  application: ApplicationNested,
-  writeStream: WriteStream,
+	application: ApplicationNested,
+	writeStream: WriteStream,
 ) => {
-  const { env, appName } = application;
-  const buildAppDirectory = getBuildAppDirectory(application);
-  const envVariables = prepareEnvironmentVariables(env);
-  try {
-    const args = [
-      "build",
-      appName,
-      "--path",
-      buildAppDirectory,
-      "--builder",
-      "paketobuildpacks/builder-jammy-full",
-    ];
+	const { env, appName } = application;
+	const buildAppDirectory = getBuildAppDirectory(application);
+	const envVariables = prepareEnvironmentVariables(env);
+	try {
+		const args = [
+			"build",
+			appName,
+			"--path",
+			buildAppDirectory,
+			"--builder",
+			"paketobuildpacks/builder-jammy-full",
+		];
 
-    for (const env in envVariables) {
-      args.push("--env", env);
-    }
+		for (const env of envVariables) {
+			args.push("--env", env);
+		}
 
-    await spawnAsync("pack", args, (data) => {
-      if (writeStream.writable) {
-        writeStream.write(data);
-      }
-    });
-    return true;
-  } catch (e) {
-    throw e;
-  }
+		await spawnAsync("pack", args, (data) => {
+			if (writeStream.writable) {
+				writeStream.write(data);
+			}
+		});
+		return true;
+	} catch (e) {
+		throw e;
+	}
 };