DeepSeek/deepseek-harness
1
0
Fork 0
mirror of https://github.com/deepseek-ai/deepseek-harness synced 2026-08-15 21:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(sandbox): decouple the probe-timeout test from the racy default budget

Browse Source 
The earlier fix only widened the vitest timeout, but the real race is the
patient probe reading the 1s launcher under the 5000ms *default* probe budget:
under a full parallel run spawnSync blocks the worker and fork/exec latency can
push the launcher's wall-clock past 5000ms, so the patient probe wrongly reads
unusable and the assertion fails. Give the patient probe a generous explicit
15000ms budget (still far below its 1s launcher runtime margin) so only the
250ms impatient probe races the launcher; keep a 30s vitest timeout above the
patient budget.
This commit is contained in:
Turtle
2026-07-21 10:07:03 +08:00
parent bdbd22bb97
commit dd57d3009d
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/sandbox/sandbox-local/tests/local.spec.ts
View File

@@ -325,13 +325,19 @@ describe('probeTimeoutMs config', () => {
})
it('bounds the default probes: a launcher slower than the configured timeout reads as unusable', async () => {
// The same sleeping launcher passes under the default 5000ms budget and
// fails under a 250ms one — the config demonstrably reaches spawnSync.
// The same 1s launcher reads usable under a generous budget and unusable
// under a 250ms one — the config demonstrably reaches spawnSync. Both bounds
// keep a wide margin from the launcher's 1s runtime so a loaded host (where
// spawnSync blocks the worker and fork/exec latency inflates wall-clock)
// cannot flip either verdict; the vitest timeout clears the patient budget.
const dir = mkdtempSync(join(tmpdir(), 'dsh-slow-landlock-'))
const launcher = join(dir, 'landlock-run')
writeFileSync(launcher, '#!/bin/sh\nsleep 1\necho "landlock: fully enforced"\nexit 0\n', { mode: 0o755 })
const patient = await setup({}, { platform: 'linux', probeBwrap: () => false, landlockLauncher: launcher })
const patient = await setup(
{ probeTimeoutMs: 15_000 },
{ platform: 'linux', probeBwrap: () => false, landlockLauncher: launcher },
)
expect(patient.sandbox.confine(['true'], RO).enforcement).toBe('full')
const impatient = await setup(
@@ -339,10 +345,7 @@ describe('probeTimeoutMs config', () => {
{ platform: 'linux', probeBwrap: () => false, landlockLauncher: launcher },
)
expect(() => impatient.sandbox.confine(['true'], RO)).toThrow(expect.objectContaining({ code: SANDBOX_UNAVAILABLE }))
// The patient probe blocks on a real 1s launcher under the 5000ms default
// budget; an explicit timeout keeps the test clear of vitest's 5000ms
// default, which the blocking spawnSync would otherwise race under load.
}, 20_000)
}, 30_000)
})
describe('the default seatbelt probe (sandbox-exec contract)', () => {