DeepSeek/deepseek-harness
1
0
Fork 0
mirror of https://github.com/deepseek-ai/deepseek-harness synced 2026-08-15 21:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(session-query-sqlite): bind the header columns once

Browse Source 
Both session upserts write the same eight header columns and differ only in
what they append; the agent_preset column made the pair long enough for the
duplication gate to flag it.
This commit is contained in:
Yichen Jiang
2026-08-07 15:55:24 +08:00
parent 9f0159e15c
commit 5f57f51f34
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
packages/session-query/session-query-sqlite/src/index.ts
View File

@@ -556,14 +556,7 @@ export class SessionQuerySqlite extends SessionQueryService {
(id, version, created_at, cwd, parent_session, seed_length, delegation_depth, agent_preset, revision, generation)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
`).run(
entry.header.id,
entry.header.version,
entry.header.createdAt,
entry.header.cwd ?? null,
entry.header.parentSession ?? null,
entry.header.seedLength ?? null,
entry.header.delegationDepth ?? null,
entry.header.agentPreset ?? null,
...headerBindings(entry.header),
revision,
generation,
)
@@ -593,14 +586,7 @@ export class SessionQuerySqlite extends SessionQueryService {
(id, version, created_at, cwd, parent_session, seed_length, delegation_depth, agent_preset, fingerprint, persisted, generation)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
`).run(
entry.header.id,
entry.header.version,
entry.header.createdAt,
entry.header.cwd ?? null,
entry.header.parentSession ?? null,
entry.header.seedLength ?? null,
entry.header.delegationDepth ?? null,
entry.header.agentPreset ?? null,
...headerBindings(entry.header),
entry.fingerprint,
persisted ? 1 : 0,
generation,
@@ -753,6 +739,25 @@ export class SessionQuerySqlite extends SessionQueryService {
}
}
/**
* The header columns both session upserts bind, in the order their INSERT
* lists them. The two statements differ only in what they append after these.
* @param header - the session header being written.
* @returns one bound value per header column.
*/
function headerBindings(header: SessionHeader): (string | number | null)[] {
return [
header.id,
header.version,
header.createdAt,
header.cwd ?? null,
header.parentSession ?? null,
header.seedLength ?? null,
header.delegationDepth ?? null,
header.agentPreset ?? null,
]
}
function selectedDocumentsSql(): { sql: string } {
return {
sql: `WITH candidates AS (