Matt Johnston
9c3e9fcdad
merge
2015-06-04 23:24:08 +08:00
Matt Johnston
1a4db21fe4
buf_getstring and buf_putstring now use non-unsigned char*
2015-06-04 23:08:50 +08:00
Matt Johnston
d96a52541f
Merge pull request #13 from gazoo74/fix-warnings
...
Fix warnings
2015-06-04 23:08:50 +08:00
Matt Johnston
e7ac4c1ab3
Merge pull request #13 from gazoo74/fix-warnings
...
Fix warnings
2015-06-04 22:25:28 +08:00
Matt Johnston
ecd8505218
Disable twofish-ctr by default, add config option
2015-06-03 22:59:59 +08:00
Matt Johnston
1fa1c3f9db
note about constant_time_strcmp and lengths
2015-06-03 22:15:12 +08:00
Matt Johnston
91df741926
Fix building when ENABLE_CLI_PUBKEY_AUTH is unset
2015-06-03 21:45:32 +08:00
Matt Johnston
2a431cab03
separate client/server fastopen options
2015-05-29 23:19:11 +08:00
Gaël PORTAY
9fdab3ced8
Merge branch 'fix-pointer-sign-warnings' into fix-warnings
2015-05-05 20:42:38 +02:00
Gaël PORTAY
6e15e75391
Turn modptr local variable into unsigned char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
1c2a1838fc
Turn name and instruction local variables into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
bfd730aa4c
Turn type and term local variables into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
e3c6a86b1e
Turn TCPFwdEntry's connectaddr and listenaddr attributes into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
bbaeb917ff
Turn banner, methods and tok local variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
20f1e49b73
Turn many local variables into char *
...
reqname, bindaddr, request_addr, desthost and orighost to be exhaustive.
2015-05-05 20:39:14 +02:00
Gaël PORTAY
292656d899
Turn signame local variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
05b36b484e
Turn ChanSess's cmd attribute into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
be3016b8d5
Turn send_msg_service_accept()'s name argument into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
5cf43d76bf
Turn checkpubkey() and send_msg_userauth_pk_ok()'s algo argument into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
6f05e810d9
Turn addr local variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
947d2697cf
Turn sshsession's remoteident attribute into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
449ddae628
Turn dropbear_ecc_curve's name into const char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
6b90885d4f
Turn Algo_Type's name attribute into const char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
bd6c37adb6
Turn local key_indent variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
59235276ac
Turn get_response()'s return type and prompt argument into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
e5ce3fc51b
Turn type local variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
9f97511356
Turn ChanSess's tty and term attributes into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
ef0aac432c
Fix unused make_connection_string() warning [-Werror=unused-function]
...
This function is used when USE_VFORK is unset.
2015-05-05 20:39:13 +02:00
Gaël PORTAY
7928d83b02
Turn cleantext()'s dirtytext argument into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
3e91ec07e4
Fix unused but set variable warnings [-Werror=unused-but-set-variable]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
d680a9e3fb
Turn username, servicename and methodname local variables into char *
...
Changing checkusername()'s username argument into char * as well.
2015-05-05 20:39:13 +02:00
Gaël PORTAY
6086851fc1
Fix unused parameters warnings [-Werror=unused-parameter]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
61726df20c
Turn sendaddr, listenaddr and request_listenaddr local variables into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
1601a657d4
Turn send_msg_channel_open_failure()'s text and lang into const char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
50b14f696c
Turn start_send_channel_request()'s type argument into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
c239baf801
Turn addrandom()'s buf argument into unsigned char *
...
Data is usually represented as "unsigned char *" like genrandom().
2015-05-05 20:39:13 +02:00
Gaël PORTAY
18638859e6
Expect len to be a type of socklen_t [-Werror=pointer-sign]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
224b16b247
Fix pointer differ in signess warnings [-Werror=pointer-sign]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
d9d97969a3
Uses abort() instead of raising a SIGABRT signal [-Werror]
...
error: ‘noreturn’ function does return [-Werror]
abort() is a noreturn function while raise() is not.
And because crypt_argchk() is flagged as __attribute__(noreturn), abort()
appears to be a better condidate.
This compilation warning has probably been introduced by commit
1809f741cb
.
2015-05-05 20:30:49 +02:00
Gaël PORTAY
897da4ee36
Uses k_size as an signed integer
...
buf_incrwritepos() and mp_to_unsigned_bin() functions use k_size as signed
integer argument.
k_size is also used in an assertion that compared it to curve_size which is
a signed long.
Only buf_getwriteptr() is using k_size as unsigned.
So it safe to use it as signed.
2015-05-05 20:30:49 +02:00
Gaël PORTAY
90f9f43335
Test struct existance against sizeof() operator
...
Instead of declaring an "unused-variable" or "unused-but-set-variable"
structure.
This avoid unexpected broken configurations when using something like:
$ ./configure CFLAGS="-Wall -Wextra -Werror"
It causes AC_COMPILE_IFELSE to fail and thus leading to a mismatch
configuration (because the CFLAGS are passed to the macro).
2015-05-05 20:23:54 +02:00
Matt Johnston
0e1dee828a
Make sure kexfirstinitialise is called early enough
2015-05-03 00:00:35 +08:00
Matt Johnston
cbdc1f0753
fix travis more
2015-05-02 22:59:55 +08:00
Matt Johnston
7e306336d0
bad travis syntax
2015-05-02 22:55:53 +08:00
Matt Johnston
e7def4c211
add no-writev build
2015-05-02 22:51:46 +08:00
Matt Johnston
19e1afbd1c
Fix no-writev fallback
2015-05-02 22:47:25 +08:00
Matt Johnston
fee32054e6
Should be AF_UNSPEC not PF_UNSPEC
2015-04-17 20:59:32 +08:00
Matt Johnston
9754fdd995
fastopen code was totally broken
2015-04-14 20:43:54 +08:00
Matt Johnston
ef20b9ff7a
Avoid channel writev() when there is nothing to write
2015-03-21 22:43:08 +08:00
Matt Johnston
275611fbaa
Make main socket nonblocking. Limit writequeue size.
2015-03-20 23:36:42 +08:00