Gaël PORTAY
6b90885d4f
Turn Algo_Type's name attribute into const char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
bd6c37adb6
Turn local key_indent variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
59235276ac
Turn get_response()'s return type and prompt argument into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
e5ce3fc51b
Turn type local variable into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
9f97511356
Turn ChanSess's tty and term attributes into char *
2015-05-05 20:39:14 +02:00
Gaël PORTAY
7928d83b02
Turn cleantext()'s dirtytext argument into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
d680a9e3fb
Turn username, servicename and methodname local variables into char *
...
Changing checkusername()'s username argument into char * as well.
2015-05-05 20:39:13 +02:00
Gaël PORTAY
61726df20c
Turn sendaddr, listenaddr and request_listenaddr local variables into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
1601a657d4
Turn send_msg_channel_open_failure()'s text and lang into const char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
50b14f696c
Turn start_send_channel_request()'s type argument into char *
2015-05-05 20:39:13 +02:00
Gaël PORTAY
c239baf801
Turn addrandom()'s buf argument into unsigned char *
...
Data is usually represented as "unsigned char *" like genrandom().
2015-05-05 20:39:13 +02:00
Gaël PORTAY
18638859e6
Expect len to be a type of socklen_t [-Werror=pointer-sign]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
224b16b247
Fix pointer differ in signess warnings [-Werror=pointer-sign]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
ef0aac432c
Fix unused make_connection_string() warning [-Werror=unused-function]
...
This function is used when USE_VFORK is unset.
2015-05-05 20:39:13 +02:00
Gaël PORTAY
3e91ec07e4
Fix unused but set variable warnings [-Werror=unused-but-set-variable]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
6086851fc1
Fix unused parameters warnings [-Werror=unused-parameter]
2015-05-05 20:39:13 +02:00
Gaël PORTAY
d9d97969a3
Uses abort() instead of raising a SIGABRT signal [-Werror]
...
error: ‘noreturn’ function does return [-Werror]
abort() is a noreturn function while raise() is not.
And because crypt_argchk() is flagged as __attribute__(noreturn), abort()
appears to be a better condidate.
This compilation warning has probably been introduced by commit
1809f741cb
.
2015-05-05 20:30:49 +02:00
Gaël PORTAY
897da4ee36
Uses k_size as an signed integer
...
buf_incrwritepos() and mp_to_unsigned_bin() functions use k_size as signed
integer argument.
k_size is also used in an assertion that compared it to curve_size which is
a signed long.
Only buf_getwriteptr() is using k_size as unsigned.
So it safe to use it as signed.
2015-05-05 20:30:49 +02:00
Gaël PORTAY
90f9f43335
Test struct existance against sizeof() operator
...
Instead of declaring an "unused-variable" or "unused-but-set-variable"
structure.
This avoid unexpected broken configurations when using something like:
$ ./configure CFLAGS="-Wall -Wextra -Werror"
It causes AC_COMPILE_IFELSE to fail and thus leading to a mismatch
configuration (because the CFLAGS are passed to the macro).
2015-05-05 20:23:54 +02:00
Matt Johnston
cbdc1f0753
fix travis more
2015-05-02 22:59:55 +08:00
Matt Johnston
7e306336d0
bad travis syntax
2015-05-02 22:55:53 +08:00
Matt Johnston
e7def4c211
add no-writev build
2015-05-02 22:51:46 +08:00
Matt Johnston
19e1afbd1c
Fix no-writev fallback
2015-05-02 22:47:25 +08:00
Matt Johnston
fee32054e6
Should be AF_UNSPEC not PF_UNSPEC
2015-04-17 20:59:32 +08:00
Matt Johnston
9754fdd995
fastopen code was totally broken
2015-04-14 20:43:54 +08:00
Matt Johnston
ef20b9ff7a
Avoid channel writev() when there is nothing to write
2015-03-21 22:43:08 +08:00
Matt Johnston
275611fbaa
Make main socket nonblocking. Limit writequeue size.
2015-03-20 23:36:42 +08:00
Matt Johnston
a070159cc5
Fix when iov queue is large
2015-03-20 23:33:45 +08:00
Matt Johnston
20f9683ae0
avoid malloc for iovec
2015-03-20 22:53:32 +08:00
Matt Johnston
dce384668b
dropbear_assert() rather than assert()
2015-03-16 21:33:01 +08:00
Matt Johnston
67b4fa313e
strdup strerror
2015-03-11 23:10:27 +08:00
Matt Johnston
5dff74109e
Fix error handling for dbclient async connect
2015-03-03 20:53:00 +08:00
Matt Johnston
20d970a0e2
more changes
2015-03-02 21:40:06 +08:00
Matt Johnston
94734ad377
changes (also testing hg bookmarks)
2015-03-02 21:29:49 +08:00
Matt Johnston
14ad6a5972
merge
2015-03-01 23:27:08 +08:00
Matt Johnston
9e66b5a9b1
reword comment for clarity
...
--HG--
branch : nocircbuffer
2015-03-01 23:26:42 +08:00
Matt Johnston
f782cf375a
Fix pubkey auth after change to reuse ses.readbuf as ses.payload
...
(4d7b4c5526c5)
--HG--
branch : nocircbuffer
2015-03-01 23:02:06 +08:00
Matt Johnston
3317916111
Fix some memory leaks in ecc code
2015-03-01 22:44:36 +08:00
Matt Johnston
f367273549
allocate buffer and data in a single allocation
...
--HG--
branch : nocircbuffer
2015-03-01 21:16:09 +08:00
Matt Johnston
91ef9b2fa9
Avoid malloc in hmac
...
--HG--
branch : nocircbuffer
2015-03-01 14:46:04 +08:00
Matt Johnston
579463933b
A bit of a bodge to avoid memcpy if zlib is disabled
...
--HG--
branch : nocircbuffer
2015-03-01 00:57:21 +08:00
Matt Johnston
989c5c1436
Avoid copying data into circular buffer
...
--HG--
branch : nocircbuffer
2015-03-01 00:44:45 +08:00
Matt Johnston
3113932151
Better failure handling
2015-02-28 23:49:39 +08:00
Matt Johnston
125a970d71
merge tcp fastopen
2015-02-28 23:24:30 +08:00
Matt Johnston
89c0b2a6d8
Add cleanup
...
--HG--
branch : fastopen
2015-02-28 23:15:23 +08:00
Matt Johnston
31e379c300
merge from default
...
--HG--
branch : fastopen
2015-02-28 09:06:40 +08:00
Matt Johnston
843953379c
EINPROGRESS for sendmsg() means it's working OK
...
--HG--
branch : fastopen
2015-02-27 00:02:48 +08:00
Matt Johnston
2a90c1ca7e
ignore any sendmsg() errors
...
--HG--
branch : fastopen
2015-02-26 23:43:12 +08:00
Thorsten Horstmann
59bb1777be
Use m_burn rather than memset
2015-02-24 22:48:14 +08:00
Thorsten Horstmann
c5f3c550a6
Avoid cppcheck warning
2015-02-24 22:41:26 +08:00