ClearML/dropbear
1
0
Fork 0
mirror of https://github.com/clearml/dropbear synced 2025-04-05 05:09:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Mention the race condition between setting the childpid entry, and

Browse Source 
the child exiting.

--HG--
extra : convert_revision : 0acd2d97675d6a45fa1664790b4b9c891461de10
This commit is contained in:
Matt Johnston 2004-08-18 16:42:08 +00:00
parent abf66aa7a1
commit 4dd70c433e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
svr-chansession.c
View File

@ -78,7 +78,6 @@ static void sesssigchild_handler(int dummy) {
TRACE(("enter sigchld handler"));
while ((pid = waitpid(-1, &status, WNOHANG)) > 0) {
/* find the corresponding chansess */
for (i = 0; i < svr_ses.childpidsize; i++) {
if (svr_ses.childpids[i].pid == pid) {
@ -630,7 +629,10 @@ static int noptycommand(struct Channel *channel, struct ChanSess *chansess) {
TRACE(("continue noptycommand: parent"));
chansess->pid = pid;
/* add a child pid */
/* add a child pid - Beware: there's a race between this, and the
* exec() called from the child. If the child finishes before we've
* done this (ie if it was a shell builtin and fast), we won't return a
* proper return code. For now, we ignore this case. */
addchildpid(chansess, pid);
close(infds[FDIN]);