ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-03-03 10:42:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix None type as default value in dictionary

Browse Source
This commit is contained in:
allegroai 2020-01-22 11:08:06 +02:00
parent b50bfd5b63
commit d03311764e
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
trains/backend_interface/task/args.py
View File

@ -217,7 +217,7 @@ class _Arguments(object):
# if we have an int, we should cast to float, because it is more generic
if var_type == int:
var_type = float
elif var_type == type(None):
elif var_type == type(None): # do not change! because isinstance(var_type, type(None)) === False
var_type = str
# now we should try and cast the value if we can
try:
@ -370,12 +370,14 @@ class _Arguments(object):
except Exception:
self._task.log.warning('Failed parsing task parameter %s=%s keeping default %s=%s' %
(str(k), str(param), str(k), str(v)))
elif isinstance(v_type, type(None)):
v_type = str
try:
dictionary[k] = v_type(param)
except ValueError:
# do not change this comparison because isinstance(v_type, type(None)) === False
if v_type == type(None):
dictionary[k] = str(param) if param else None
else:
dictionary[k] = v_type(param)
except Exception:
self._task.log.warning('Failed parsing task parameter %s=%s keeping default %s=%s' %
(str(k), str(param), str(k), str(v)))
continue