From d165fc0658a9f6d955d80f404989cd19ba0a6c58 Mon Sep 17 00:00:00 2001 From: Christoph Haas Date: Mon, 17 May 2021 09:06:26 +0200 Subject: [PATCH] ensure that email attribute is set --- internal/server/ldapsync.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/server/ldapsync.go b/internal/server/ldapsync.go index abdecf9..57f7982 100644 --- a/internal/server/ldapsync.go +++ b/internal/server/ldapsync.go @@ -113,6 +113,11 @@ func (s *Server) disableMissingLdapUsers(ldapUsers []ldap.RawLdapData) { func (s *Server) updateLdapUsers(ldapUsers []ldap.RawLdapData) { for i := range ldapUsers { + if ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute] == "" { + logrus.Tracef("skipping sync of %s, empty email attribute", ldapUsers[i].DN) + continue + } + user, err := s.users.GetOrCreateUserUnscoped(ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute]) if err != nil { logrus.Errorf("failed to get/create user %s in database: %v", ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute], err)