UniqAI/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui synced 2024-11-26 22:09:51 +00:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

Merge pull request #538 from Shiyinq/refactor-signup

Browse Source 
feat: add guard clause to improve signup process
This commit is contained in:
Timothy Jaeryang Baek 2024-01-21 15:36:09 -08:00 committed by GitHub
commit 95da5ab8e0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 32 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
backend/apps/web/routers/auths.py
View File

@ -91,9 +91,15 @@ async def signin(form_data: SigninForm):
@router.post("/signup", response_model=SigninResponse) @router.post("/signup", response_model=SigninResponse)
async def signup(request: Request, form_data: SignupForm): async def signup(request: Request, form_data: SignupForm):
if request.app.state.ENABLE_SIGNUP: if not request.app.state.ENABLE_SIGNUP:
if validate_email_format(form_data.email.lower()): raise HTTPException(400, detail=ERROR_MESSAGES.ACCESS_PROHIBITED)
if not Users.get_user_by_email(form_data.email.lower()):
if not validate_email_format(form_data.email.lower()):
raise HTTPException(400, detail=ERROR_MESSAGES.INVALID_EMAIL_FORMAT)
if Users.get_user_by_email(form_data.email.lower()):
raise HTTPException(400, detail=ERROR_MESSAGES.EMAIL_TAKEN)
try: try:
role = "admin" if Users.get_num_users() == 0 else "pending" role = "admin" if Users.get_num_users() == 0 else "pending"
hashed = get_password_hash(form_data.password) hashed = get_password_hash(form_data.password)
@ -119,14 +125,6 @@ async def signup(request: Request, form_data: SignupForm):
except Exception as err: except Exception as err:
raise HTTPException(500, raise HTTPException(500,
detail=ERROR_MESSAGES.DEFAULT(err)) detail=ERROR_MESSAGES.DEFAULT(err))
else:
raise HTTPException(400, detail=ERROR_MESSAGES.EMAIL_TAKEN)
else:
raise HTTPException(400,
detail=ERROR_MESSAGES.INVALID_EMAIL_FORMAT)
else:
raise HTTPException(400, detail=ERROR_MESSAGES.ACCESS_PROHIBITED)
############################ ############################
# ToggleSignUp # ToggleSignUp