From dcb32f78fe0a84100cb18879099e81f89a07a1ef Mon Sep 17 00:00:00 2001 From: Silentoplayz <50341825+Silentoplayz@users.noreply.github.com> Date: Mon, 22 Apr 2024 07:11:59 +0000 Subject: [PATCH 1/6] Update pull_request_template.md Overhaul --- .github/pull_request_template.md | 37 ++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4c4cfa3b2..312f210cd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,14 +2,19 @@ - [ ] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. -- [ ] **Documentation:** Have you updated relevant documentation? +- [ ] **Documentation:** Have you updated relevant documentation, including [README](https://github.com/open-webui/open-webui/blob/main/README.md), [Open WebUI Docs](https://docs.openwebui.com/), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? +- [ ] **Testing:** Have you written and run sufficient tests for the changes? +- [ ] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues? --- ## Description -[Insert a brief description of the changes made in this pull request] +[Insert a brief description of the changes made in this pull request, including any relevant background or motivation. Consider including answers to the following questions: +* What problem does this PR solve? +* How does it improve the project or fix an issue? +* What changes were made to achieve this outcome?] --- @@ -17,16 +22,36 @@ ### Added -- [List any new features or additions] +- [List any new features, functionalities, or additions, including any breaking changes] ### Fixed -- [List any fixes or corrections] +- [List any fixes or corrections, including bug fixes, typo fixes, or other corrections] ### Changed -- [List any changes or updates] +- [List any changes or updates, including refactorings, optimizations, or other modifications] ### Removed -- [List any removed features or files] +- [List any removed features, files, or deprecated functionalities] + +### Deprecated + +- [List any deprecated features, functions, or APIs] + +### Security + +- [List any security-related changes, including vulnerability fixes or security enhancements] + +### Breaking Changes + +- [List any breaking changes, including changes that may affect existing functionality or compatibility] + +--- + +### Additional Information + +* [Insert any additional context, notes, or explanations for the changes] + +* [Mention any related issues, commits, or other references] From a615308111a423e760a3d4dc5a6e9a90a0b36e1e Mon Sep 17 00:00:00 2001 From: Silentoplayz <50341825+Silentoplayz@users.noreply.github.com> Date: Mon, 22 Apr 2024 07:19:09 +0000 Subject: [PATCH 2/6] Update pull_request_template.md Fix --- .github/pull_request_template.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 312f210cd..3fa91f857 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,7 +22,7 @@ ### Added -- [List any new features, functionalities, or additions, including any breaking changes] +- [List any new features, functionalities, or additions] ### Fixed @@ -34,11 +34,7 @@ ### Removed -- [List any removed features, files, or deprecated functionalities] - -### Deprecated - -- [List any deprecated features, functions, or APIs] +- [List any removed features, files, or deprecated functionalities and APIs] ### Security From 4a536484a69dfed5aa040d9ed3998cf8b25132c8 Mon Sep 17 00:00:00 2001 From: Silentoplayz <50341825+Silentoplayz@users.noreply.github.com> Date: Tue, 23 Apr 2024 11:14:54 +0000 Subject: [PATCH 3/6] Update pull_request_template.md Added failure to follow template warning Made more concise --- .github/pull_request_template.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3fa91f857..c007d4afe 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,6 @@ +## WARNING: FAILURE TO FOLLOW THE TEMPLATE WILL RESULT IN IMMEDIATE LOCK OF THE PULL REQUEST WITHOUT COMMENT +Please complete the following pull request checklist to ensure accuracy, clarity, and consistency. + ## Pull Request Checklist - [ ] **Description:** Briefly describe the changes in this pull request. @@ -11,10 +14,7 @@ ## Description -[Insert a brief description of the changes made in this pull request, including any relevant background or motivation. Consider including answers to the following questions: -* What problem does this PR solve? -* How does it improve the project or fix an issue? -* What changes were made to achieve this outcome?] +[Insert a brief description of the changes made in this pull request, including any relevantincluding motivation and impact.] --- @@ -26,23 +26,23 @@ ### Fixed -- [List any fixes or corrections, including bug fixes, typo fixes, or other corrections] +- [List any fixes, corrections, or bug fixes] ### Changed -- [List any changes or updates, including refactorings, optimizations, or other modifications] +- [List any changes, updates, refactorings, or optimizations] ### Removed -- [List any removed features, files, or deprecated functionalities and APIs] +- [List any removed features, files, or deprecated functionalities] ### Security -- [List any security-related changes, including vulnerability fixes or security enhancements] +- [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes -- [List any breaking changes, including changes that may affect existing functionality or compatibility] +- [List any breaking changes affecting compatibility or functionality] --- @@ -50,4 +50,4 @@ * [Insert any additional context, notes, or explanations for the changes] -* [Mention any related issues, commits, or other references] +* [Reference any related issues, commits, or other relevant information] From 29c6b253ca28f57c9a74e717e78b15c06fc8d547 Mon Sep 17 00:00:00 2001 From: Silentoplayz <50341825+Silentoplayz@users.noreply.github.com> Date: Tue, 23 Apr 2024 11:17:32 +0000 Subject: [PATCH 4/6] Update pull_request_template.md Okay, no warning then. --- .github/pull_request_template.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c007d4afe..5eee07454 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,3 @@ -## WARNING: FAILURE TO FOLLOW THE TEMPLATE WILL RESULT IN IMMEDIATE LOCK OF THE PULL REQUEST WITHOUT COMMENT -Please complete the following pull request checklist to ensure accuracy, clarity, and consistency. - ## Pull Request Checklist - [ ] **Description:** Briefly describe the changes in this pull request. From 53b277e575f7d6b4a3481ba06bd6f5f52af5e634 Mon Sep 17 00:00:00 2001 From: Silentoplayz <50341825+Silentoplayz@users.noreply.github.com> Date: Wed, 24 Apr 2024 06:02:25 +0000 Subject: [PATCH 5/6] Update pull_request_template.md fix --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5eee07454..fa37e7723 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,7 +11,7 @@ ## Description -[Insert a brief description of the changes made in this pull request, including any relevantincluding motivation and impact.] +[Insert a brief description of the changes made in this pull request, including any relevant motivation and impact.] --- From c1b97a723f611d41d3179b2c1e9ab10e3b8e4cc8 Mon Sep 17 00:00:00 2001 From: Timothy Jaeryang Baek Date: Sat, 27 Apr 2024 16:28:14 -0500 Subject: [PATCH 6/6] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fa37e7723..9809f3af4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ - [ ] **Description:** Briefly describe the changes in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. -- [ ] **Documentation:** Have you updated relevant documentation, including [README](https://github.com/open-webui/open-webui/blob/main/README.md), [Open WebUI Docs](https://docs.openwebui.com/), or other documentation sources? +- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for the changes? - [ ] **Code Review:** Have you self-reviewed your code and addressed any coding standard issues?