mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-23 00:38:26 +00:00
8bb0235c92
These changes remove the use of discover.Config which was used to pass the driver root and the nvidiaCTK path in some cases. Instead, the nvidiaCTKPath is resolved at the begining of runtime invocation to ensure that this is valid at all points where it is used. Signed-off-by: Evan Lezar <elezar@nvidia.com>
164 lines
3.4 KiB
Go
164 lines
3.4 KiB
Go
/**
|
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package discover
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
testlog "github.com/sirupsen/logrus/hooks/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
const (
|
|
testNvidiaCTKPath = "/foo/bar/nvidia-ctk"
|
|
)
|
|
|
|
func TestLDCacheUpdateHook(t *testing.T) {
|
|
logger, _ := testlog.NewNullLogger()
|
|
|
|
testCases := []struct {
|
|
description string
|
|
mounts []Mount
|
|
mountError error
|
|
expectedError error
|
|
expectedArgs []string
|
|
}{
|
|
{
|
|
description: "empty mounts",
|
|
expectedArgs: []string{"nvidia-ctk", "hook", "update-ldcache"},
|
|
},
|
|
{
|
|
description: "mount error",
|
|
mountError: fmt.Errorf("mountError"),
|
|
expectedError: fmt.Errorf("mountError"),
|
|
},
|
|
{
|
|
description: "library folders are added to args",
|
|
mounts: []Mount{
|
|
{
|
|
Path: "/usr/local/lib/libfoo.so",
|
|
},
|
|
{
|
|
Path: "/usr/bin/notlib",
|
|
},
|
|
{
|
|
Path: "/usr/local/libother/libfoo.so",
|
|
},
|
|
{
|
|
Path: "/usr/local/lib/libbar.so",
|
|
},
|
|
},
|
|
expectedArgs: []string{"nvidia-ctk", "hook", "update-ldcache", "--folder", "/usr/local/lib", "--folder", "/usr/local/libother"},
|
|
},
|
|
{
|
|
description: "host paths are ignored",
|
|
mounts: []Mount{
|
|
{
|
|
HostPath: "/usr/local/other/libfoo.so",
|
|
Path: "/usr/local/lib/libfoo.so",
|
|
},
|
|
},
|
|
expectedArgs: []string{"nvidia-ctk", "hook", "update-ldcache", "--folder", "/usr/local/lib"},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
mountMock := &DiscoverMock{
|
|
MountsFunc: func() ([]Mount, error) {
|
|
return tc.mounts, tc.mountError
|
|
},
|
|
}
|
|
expectedHook := Hook{
|
|
Path: testNvidiaCTKPath,
|
|
Args: tc.expectedArgs,
|
|
Lifecycle: "createContainer",
|
|
}
|
|
|
|
d, err := NewLDCacheUpdateHook(logger, mountMock, testNvidiaCTKPath)
|
|
require.NoError(t, err)
|
|
|
|
hooks, err := d.Hooks()
|
|
require.Len(t, mountMock.MountsCalls(), 1)
|
|
require.Len(t, mountMock.DevicesCalls(), 0)
|
|
require.Len(t, mountMock.HooksCalls(), 0)
|
|
if tc.expectedError != nil {
|
|
require.Error(t, err)
|
|
return
|
|
}
|
|
|
|
require.NoError(t, err)
|
|
require.Len(t, hooks, 1)
|
|
|
|
require.EqualValues(t, hooks[0], expectedHook)
|
|
|
|
devices, err := d.Devices()
|
|
require.NoError(t, err)
|
|
require.Empty(t, devices)
|
|
|
|
mounts, err := d.Mounts()
|
|
require.NoError(t, err)
|
|
require.Empty(t, mounts)
|
|
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestIsLibName(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
isLib bool
|
|
}{
|
|
{
|
|
name: "",
|
|
isLib: false,
|
|
},
|
|
{
|
|
name: "lib/not/.so",
|
|
isLib: false,
|
|
},
|
|
{
|
|
name: "lib.so",
|
|
isLib: false,
|
|
},
|
|
{
|
|
name: "notlibcuda.so",
|
|
isLib: false,
|
|
},
|
|
{
|
|
name: "libcuda.so",
|
|
isLib: true,
|
|
},
|
|
{
|
|
name: "libcuda.so.1",
|
|
isLib: true,
|
|
},
|
|
{
|
|
name: "libcuda.soNOT",
|
|
isLib: false,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
require.Equal(t, tc.isLib, isLibName(tc.name))
|
|
})
|
|
}
|
|
}
|