mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-05-30 01:58:49 +00:00
ec29b602c3
This change uses the reexec package to run the update of the ldcache in a container in a process with isolated namespaces. Since the hook is invoked as a createContainer hook, these namespaces are cloned from the container's namespaces. In the reexec handler, we further isolate the proc filesystem, mount the host ldconfig to a tmpfs, and pivot into the containers root. Signed-off-by: Evan Lezar <elezar@nvidia.com>
59 lines
1.7 KiB
Go
59 lines
1.7 KiB
Go
//go:build linux
|
|
|
|
/**
|
|
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package ldcache
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"strconv"
|
|
"syscall"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/exeseal"
|
|
)
|
|
|
|
// SafeExec attempts to clone the specified binary (as an memfd, for example) before executing it.
|
|
func SafeExec(path string, args []string, envv []string) error {
|
|
safeExe, err := cloneBinary(path)
|
|
if err != nil {
|
|
//nolint:gosec // TODO: Can we harden this so that there is less risk of command injection
|
|
return syscall.Exec(path, args, envv)
|
|
}
|
|
defer safeExe.Close()
|
|
|
|
exePath := "/proc/self/fd/" + strconv.Itoa(int(safeExe.Fd()))
|
|
//nolint:gosec // TODO: Can we harden this so that there is less risk of command injection
|
|
return syscall.Exec(exePath, args, envv)
|
|
}
|
|
|
|
func cloneBinary(path string) (*os.File, error) {
|
|
exe, err := os.Open(path)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("opening current binary: %w", err)
|
|
}
|
|
defer exe.Close()
|
|
|
|
stat, err := exe.Stat()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("checking %v size: %w", path, err)
|
|
}
|
|
size := stat.Size()
|
|
|
|
return exeseal.CloneBinary(exe, size, path, os.TempDir())
|
|
}
|