mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-06-26 18:18:24 +00:00
d03a06029a
The gated modifiers used to add support for GDS, Mofed, and CUDA Forward Comatibility only check the NVIDIA_VISIBLE_DEVICES envvar to determine whether GPUs are requested and modifications should be made. This means that use cases where volume mounts are used to request devices are not supported. This change ensures that device extraction is consistent for all use cases. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com>
101 lines
2.8 KiB
Go
101 lines
2.8 KiB
Go
/**
|
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package modifier
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
|
)
|
|
|
|
func TestGraphicsModifier(t *testing.T) {
|
|
testCases := []struct {
|
|
description string
|
|
envmap map[string]string
|
|
expectedDevices []string
|
|
}{
|
|
{
|
|
description: "empty image does not create modifier",
|
|
},
|
|
{
|
|
description: "devices with no capabilities does not create modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
},
|
|
},
|
|
{
|
|
description: "devices with no non-graphics does not create modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "compute",
|
|
},
|
|
},
|
|
{
|
|
description: "devices with all capabilities creates modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "all",
|
|
},
|
|
expectedDevices: []string{"all"},
|
|
},
|
|
{
|
|
description: "devices with graphics capability creates modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "graphics",
|
|
},
|
|
expectedDevices: []string{"all"},
|
|
},
|
|
{
|
|
description: "devices with compute,graphics capability creates modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "compute,graphics",
|
|
},
|
|
expectedDevices: []string{"all"},
|
|
},
|
|
{
|
|
description: "devices with display capability creates modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "display",
|
|
},
|
|
expectedDevices: []string{"all"},
|
|
},
|
|
{
|
|
description: "devices with display,graphics capability creates modifier",
|
|
envmap: map[string]string{
|
|
"NVIDIA_VISIBLE_DEVICES": "all",
|
|
"NVIDIA_DRIVER_CAPABILITIES": "display,graphics",
|
|
},
|
|
expectedDevices: []string{"all"},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
image, _ := image.New(
|
|
image.WithEnvMap(tc.envmap),
|
|
)
|
|
required, _ := requiresGraphicsModifier(image)
|
|
require.EqualValues(t, tc.expectedDevices, required)
|
|
})
|
|
}
|
|
}
|