mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-22 16:29:18 +00:00
d52dbeaa7a
This changes splits the functionality in the internal system package into two packages: one for dealing with devices and one for dealing with kernel modules. This removes ambiguity around the meaning of driver / device roots in each case. In each case, a root can be specified where device nodes are created or kernel modules loaded. Signed-off-by: Evan Lezar <elezar@nvidia.com>
134 lines
3.1 KiB
Go
134 lines
3.1 KiB
Go
/**
|
|
# Copyright (c) NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package nvdevices
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/info/proc/devices"
|
|
testlog "github.com/sirupsen/logrus/hooks/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCreateControlDevices(t *testing.T) {
|
|
logger, _ := testlog.NewNullLogger()
|
|
|
|
nvidiaDevices := &devices.DevicesMock{
|
|
GetFunc: func(name devices.Name) (devices.Major, bool) {
|
|
devices := map[devices.Name]devices.Major{
|
|
"nvidia-frontend": 195,
|
|
"nvidia-uvm": 243,
|
|
}
|
|
return devices[name], true
|
|
},
|
|
}
|
|
|
|
mknodeError := errors.New("mknode error")
|
|
|
|
testCases := []struct {
|
|
description string
|
|
root string
|
|
devices devices.Devices
|
|
mknodeError error
|
|
expectedError error
|
|
expectedCalls []struct {
|
|
S string
|
|
N1 int
|
|
N2 int
|
|
}
|
|
}{
|
|
{
|
|
description: "no root specified",
|
|
root: "",
|
|
devices: nvidiaDevices,
|
|
mknodeError: nil,
|
|
expectedCalls: []struct {
|
|
S string
|
|
N1 int
|
|
N2 int
|
|
}{
|
|
{"/dev/nvidiactl", 195, 255},
|
|
{"/dev/nvidia-modeset", 195, 254},
|
|
{"/dev/nvidia-uvm", 243, 0},
|
|
{"/dev/nvidia-uvm-tools", 243, 1},
|
|
},
|
|
},
|
|
{
|
|
description: "some root specified",
|
|
root: "/some/root",
|
|
devices: nvidiaDevices,
|
|
mknodeError: nil,
|
|
expectedCalls: []struct {
|
|
S string
|
|
N1 int
|
|
N2 int
|
|
}{
|
|
{"/some/root/dev/nvidiactl", 195, 255},
|
|
{"/some/root/dev/nvidia-modeset", 195, 254},
|
|
{"/some/root/dev/nvidia-uvm", 243, 0},
|
|
{"/some/root/dev/nvidia-uvm-tools", 243, 1},
|
|
},
|
|
},
|
|
{
|
|
description: "mknod error returns error",
|
|
devices: nvidiaDevices,
|
|
mknodeError: mknodeError,
|
|
expectedError: mknodeError,
|
|
// We expect the first call to this to fail, and the rest to be skipped
|
|
expectedCalls: []struct {
|
|
S string
|
|
N1 int
|
|
N2 int
|
|
}{
|
|
{"/dev/nvidiactl", 195, 255},
|
|
},
|
|
},
|
|
{
|
|
description: "missing major returns error",
|
|
devices: &devices.DevicesMock{
|
|
GetFunc: func(name devices.Name) (devices.Major, bool) {
|
|
return 0, false
|
|
},
|
|
},
|
|
expectedError: errInvalidDeviceNode,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
mknode := &mknoderMock{
|
|
MknodeFunc: func(string, int, int) error {
|
|
return tc.mknodeError
|
|
},
|
|
}
|
|
|
|
d, _ := New(
|
|
WithLogger(logger),
|
|
WithDevRoot(tc.root),
|
|
WithDevices(tc.devices),
|
|
)
|
|
d.mknoder = mknode
|
|
|
|
err := d.CreateNVIDIAControlDevices()
|
|
require.ErrorIs(t, err, tc.expectedError)
|
|
require.EqualValues(t, tc.expectedCalls, mknode.MknodeCalls())
|
|
})
|
|
}
|
|
|
|
}
|