mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-22 16:29:18 +00:00
5885fead8f
This change ensures that a more concrete error is provided by the NVIDIA Container Runtime if the NVIDIA Container Runtime hook cannot be located. Signed-off-by: Evan Lezar <elezar@nvidia.com>
78 lines
2.7 KiB
Go
78 lines
2.7 KiB
Go
/*
|
|
# Copyright (c) 2021, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
*/
|
|
|
|
package modifier
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/lookup"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/oci"
|
|
"github.com/opencontainers/runtime-spec/specs-go"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// NewStableRuntimeModifier creates an OCI spec modifier that inserts the NVIDIA Container Runtime Hook into an OCI
|
|
// spec. The specified logger is used to capture log output.
|
|
func NewStableRuntimeModifier(logger *logrus.Logger) oci.SpecModifier {
|
|
m := stableRuntimeModifier{logger: logger}
|
|
|
|
return &m
|
|
}
|
|
|
|
// stableRuntimeModifier modifies an OCI spec inplace, inserting the nvidia-container-runtime-hook as a
|
|
// prestart hook. If the hook is already present, no modification is made.
|
|
type stableRuntimeModifier struct {
|
|
logger *logrus.Logger
|
|
}
|
|
|
|
// Modify applies the required modification to the incoming OCI spec, inserting the nvidia-container-runtime-hook
|
|
// as a prestart hook.
|
|
func (m stableRuntimeModifier) Modify(spec *specs.Spec) error {
|
|
// If an NVIDIA Container Runtime Hook already exists, we don't make any modifications to the spec.
|
|
if spec.Hooks != nil {
|
|
for _, hook := range spec.Hooks.Prestart {
|
|
if isNVIDIAContainerRuntimeHook(&hook) {
|
|
m.logger.Infof("Existing nvidia prestart hook (%v) found in OCI spec", hook.Path)
|
|
return nil
|
|
}
|
|
}
|
|
}
|
|
|
|
// We create a locator and look for the NVIDIA Container Runtime Hook in the path.
|
|
candidates, err := lookup.NewExecutableLocator(m.logger, "").Locate(config.NVIDIAContainerRuntimeHookExecutable)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to locate NVIDIA Container Runtime Hook: %v", err)
|
|
}
|
|
path := candidates[0]
|
|
if len(candidates) > 1 {
|
|
m.logger.Debugf("Using %v from multiple NVIDIA Container Runtime Hook candidates: %v", path, candidates)
|
|
}
|
|
|
|
m.logger.Infof("Using prestart hook path: %v", path)
|
|
args := []string{path}
|
|
if spec.Hooks == nil {
|
|
spec.Hooks = &specs.Hooks{}
|
|
}
|
|
spec.Hooks.Prestart = append(spec.Hooks.Prestart, specs.Hook{
|
|
Path: path,
|
|
Args: append(args, "prestart"),
|
|
})
|
|
|
|
return nil
|
|
}
|