mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-22 16:29:18 +00:00
cca343abb0
Since the incoming OCI spec has already been parsed and used to construct a CUDA image representation, pass this to the CSV modifier constructor instead of re-creating an image representation. Signed-off-by: Evan Lezar <elezar@nvidia.com>
121 lines
3.7 KiB
Go
121 lines
3.7 KiB
Go
/*
|
|
# Copyright (c) 2021-2022, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
*/
|
|
|
|
package runtime
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/info"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/logger"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/modifier"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/oci"
|
|
)
|
|
|
|
// newNVIDIAContainerRuntime is a factory method that constructs a runtime based on the selected configuration and specified logger
|
|
func newNVIDIAContainerRuntime(logger logger.Interface, cfg *config.Config, argv []string) (oci.Runtime, error) {
|
|
lowLevelRuntime, err := oci.NewLowLevelRuntime(logger, cfg.NVIDIAContainerRuntimeConfig.Runtimes)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error constructing low-level runtime: %v", err)
|
|
}
|
|
|
|
if !oci.HasCreateSubcommand(argv) {
|
|
logger.Debugf("Skipping modifier for non-create subcommand")
|
|
return lowLevelRuntime, nil
|
|
}
|
|
|
|
ociSpec, err := oci.NewSpec(logger, argv)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error constructing OCI specification: %v", err)
|
|
}
|
|
|
|
specModifier, err := newSpecModifier(logger, cfg, ociSpec)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to construct OCI spec modifier: %v", err)
|
|
}
|
|
|
|
// Create the wrapping runtime with the specified modifier
|
|
r := oci.NewModifyingRuntimeWrapper(
|
|
logger,
|
|
lowLevelRuntime,
|
|
ociSpec,
|
|
specModifier,
|
|
)
|
|
|
|
return r, nil
|
|
}
|
|
|
|
// newSpecModifier is a factory method that creates constructs an OCI spec modifer based on the provided config.
|
|
func newSpecModifier(logger logger.Interface, cfg *config.Config, ociSpec oci.Spec) (oci.SpecModifier, error) {
|
|
rawSpec, err := ociSpec.Load()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to load OCI spec: %v", err)
|
|
}
|
|
|
|
image, err := image.NewCUDAImageFromSpec(rawSpec)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
mode := info.ResolveAutoMode(logger, cfg.NVIDIAContainerRuntimeConfig.Mode, image)
|
|
modeModifier, err := newModeModifier(logger, mode, cfg, ociSpec, image)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
// For CDI mode we make no additional modifications.
|
|
if mode == "cdi" {
|
|
return modeModifier, nil
|
|
}
|
|
|
|
graphicsModifier, err := modifier.NewGraphicsModifier(logger, cfg, image)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
gdsModifier, err := modifier.NewGDSModifier(logger, cfg, image)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
mofedModifier, err := modifier.NewMOFEDModifier(logger, cfg, image)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
modifiers := modifier.Merge(
|
|
modeModifier,
|
|
graphicsModifier,
|
|
gdsModifier,
|
|
mofedModifier,
|
|
)
|
|
return modifiers, nil
|
|
}
|
|
|
|
func newModeModifier(logger logger.Interface, mode string, cfg *config.Config, ociSpec oci.Spec, image image.CUDA) (oci.SpecModifier, error) {
|
|
switch mode {
|
|
case "legacy":
|
|
return modifier.NewStableRuntimeModifier(logger, cfg.NVIDIAContainerRuntimeHookConfig.Path), nil
|
|
case "csv":
|
|
return modifier.NewCSVModifier(logger, cfg, image)
|
|
case "cdi":
|
|
return modifier.NewCDIModifier(logger, cfg, ociSpec)
|
|
}
|
|
|
|
return nil, fmt.Errorf("invalid runtime mode: %v", cfg.NVIDIAContainerRuntimeConfig.Mode)
|
|
}
|