mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-29 16:02:10 +00:00
e591f3f26b
These changes replace the nvidia-container-runtime config options experimental and discover-mode with a single mode config option. Note that mode is now a string with a default value of "auto" and a mode value of "legacy" is equivalent to experimental == false. Signed-off-by: Evan Lezar <elezar@nvidia.com>
167 lines
5.6 KiB
Go
167 lines
5.6 KiB
Go
/**
|
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package modifier
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/cuda"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/discover"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/discover/csv"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/edits"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/oci"
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/requirements"
|
|
"github.com/opencontainers/runtime-spec/specs-go"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// csvMode represents the modifications as performed by the csv runtime mode
|
|
type csvMode struct {
|
|
logger *logrus.Logger
|
|
discoverer discover.Discover
|
|
}
|
|
|
|
const (
|
|
visibleDevicesEnvvar = "NVIDIA_VISIBLE_DEVICES"
|
|
visibleDevicesVoid = "void"
|
|
|
|
nvidiaRequireJetpackEnvvar = "NVIDIA_REQUIRE_JETPACK"
|
|
)
|
|
|
|
// NewCSVModifier creates a modifier that applies modications to an OCI spec if required by the runtime wrapper.
|
|
// The modifications are defined by CSV MountSpecs.
|
|
func NewCSVModifier(logger *logrus.Logger, cfg *config.Config, ociSpec oci.Spec) (oci.SpecModifier, error) {
|
|
rawSpec, err := ociSpec.Load()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to load OCI spec: %v", err)
|
|
}
|
|
|
|
// In experimental mode, we check whether a modification is required at all and return the lowlevelRuntime directly
|
|
// if no modification is required.
|
|
visibleDevices, exists := ociSpec.LookupEnv(visibleDevicesEnvvar)
|
|
if !exists || visibleDevices == "" || visibleDevices == visibleDevicesVoid {
|
|
logger.Infof("No modification required: %v=%v (exists=%v)", visibleDevicesEnvvar, visibleDevices, exists)
|
|
return nil, nil
|
|
}
|
|
logger.Infof("Constructing modifier from config: %+v", *cfg)
|
|
|
|
config := &discover.Config{
|
|
Root: cfg.NVIDIAContainerCLIConfig.Root,
|
|
NVIDIAContainerToolkitCLIExecutablePath: cfg.NVIDIACTKConfig.Path,
|
|
}
|
|
|
|
// TODO: Once the devices have been encapsulated in the CUDA image, this can be moved to before the
|
|
// visible devices are checked.
|
|
image, err := image.NewCUDAImageFromSpec(rawSpec)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err := checkRequirements(logger, &image); err != nil {
|
|
return nil, fmt.Errorf("requirements not met: %v", err)
|
|
}
|
|
|
|
csvFiles, err := csv.GetFileList(cfg.NVIDIAContainerRuntimeConfig.Modes.CSV.MountSpecPath)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get list of CSV files: %v", err)
|
|
}
|
|
|
|
nvidiaRequireJetpack, _ := ociSpec.LookupEnv(nvidiaRequireJetpackEnvvar)
|
|
if nvidiaRequireJetpack != "csv-mounts=all" {
|
|
csvFiles = csv.BaseFilesOnly(csvFiles)
|
|
}
|
|
|
|
csvDiscoverer, err := discover.NewFromCSVFiles(logger, csvFiles, config.Root)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to create CSV discoverer: %v", err)
|
|
}
|
|
|
|
ldcacheUpdateHook, err := discover.NewLDCacheUpdateHook(logger, csvDiscoverer, config)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to create ldcach update hook discoverer: %v", err)
|
|
}
|
|
|
|
createSymlinksHook, err := discover.NewCreateSymlinksHook(logger, csvFiles, csvDiscoverer, config)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to create symlink hook discoverer: %v", err)
|
|
}
|
|
|
|
d := discover.NewList(csvDiscoverer, ldcacheUpdateHook, createSymlinksHook)
|
|
|
|
return newModifierFromDiscoverer(logger, d)
|
|
}
|
|
|
|
// newModifierFromDiscoverer created a modifier that aplies the discovered
|
|
// modifications to an OCI spec if require by the runtime wrapper.
|
|
func newModifierFromDiscoverer(logger *logrus.Logger, d discover.Discover) (oci.SpecModifier, error) {
|
|
m := csvMode{
|
|
logger: logger,
|
|
discoverer: d,
|
|
}
|
|
return &m, nil
|
|
}
|
|
|
|
// Modify applies the required modifications to the incomming OCI spec. These modifications
|
|
// are applied in-place.
|
|
func (m csvMode) Modify(spec *specs.Spec) error {
|
|
err := nvidiaContainerRuntimeHookRemover{m.logger}.Modify(spec)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to remove existing hooks: %v", err)
|
|
}
|
|
|
|
specEdits, err := edits.NewSpecEdits(m.logger, m.discoverer)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get required container edits: %v", err)
|
|
}
|
|
|
|
return specEdits.Modify(spec)
|
|
}
|
|
|
|
func checkRequirements(logger *logrus.Logger, image *image.CUDA) error {
|
|
if image.HasDisableRequire() {
|
|
// TODO: We could print the real value here instead
|
|
logger.Debugf("NVIDIA_DISABLE_REQUIRE=%v; skipping requirement checks", true)
|
|
return nil
|
|
}
|
|
|
|
imageRequirements, err := image.GetRequirements()
|
|
if err != nil {
|
|
// TODO: Should we treat this as a failure, or just issue a warning?
|
|
return fmt.Errorf("failed to get image requirements: %v", err)
|
|
}
|
|
|
|
r := requirements.New(logger, imageRequirements)
|
|
|
|
cudaVersion, err := cuda.Version()
|
|
if err != nil {
|
|
logger.Warnf("Failed to get CUDA version: %v", err)
|
|
} else {
|
|
r.AddVersionProperty(requirements.CUDA, cudaVersion)
|
|
}
|
|
|
|
compteCapability, err := cuda.ComputeCapability(0)
|
|
if err != nil {
|
|
logger.Warnf("Failed to get CUDA Compute Capability: %v", err)
|
|
} else {
|
|
r.AddVersionProperty(requirements.ARCH, compteCapability)
|
|
}
|
|
|
|
return r.Assert()
|
|
}
|