mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-25 13:35:00 +00:00
e591f3f26b
These changes replace the nvidia-container-runtime config options experimental and discover-mode with a single mode config option. Note that mode is now a string with a default value of "auto" and a mode value of "legacy" is equivalent to experimental == false. Signed-off-by: Evan Lezar <elezar@nvidia.com>
130 lines
3.1 KiB
Go
130 lines
3.1 KiB
Go
/*
|
|
# Copyright (c) 2021, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config"
|
|
"github.com/opencontainers/runtime-spec/specs-go"
|
|
testlog "github.com/sirupsen/logrus/hooks/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFactoryMethod(t *testing.T) {
|
|
logger, _ := testlog.NewNullLogger()
|
|
|
|
testCases := []struct {
|
|
description string
|
|
cfg *config.Config
|
|
spec *specs.Spec
|
|
expectedError bool
|
|
}{
|
|
{
|
|
description: "empty config raises error",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{},
|
|
},
|
|
expectedError: true,
|
|
},
|
|
{
|
|
description: "config with runtime raises no error",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
Mode: "legacy",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "csv mode is supported",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
Mode: "csv",
|
|
},
|
|
},
|
|
spec: &specs.Spec{
|
|
Process: &specs.Process{
|
|
Env: []string{
|
|
"NVIDIA_VISIBLE_DEVICES=all",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "non-legacy discover mode raises error",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
Mode: "non-legacy",
|
|
},
|
|
},
|
|
expectedError: true,
|
|
},
|
|
{
|
|
description: "legacy discover mode returns modifier",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
Mode: "legacy",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "csv discover mode returns modifier",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
Mode: "csv",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "empty mode raises error",
|
|
cfg: &config.Config{
|
|
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
|
Runtimes: []string{"runc"},
|
|
},
|
|
},
|
|
expectedError: true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
bundleDir := t.TempDir()
|
|
|
|
specFile, err := os.Create(filepath.Join(bundleDir, "config.json"))
|
|
require.NoError(t, err)
|
|
require.NoError(t, json.NewEncoder(specFile).Encode(tc.spec))
|
|
|
|
argv := []string{"--bundle", bundleDir, "create"}
|
|
|
|
_, err = newNVIDIAContainerRuntime(logger, tc.cfg, argv)
|
|
if tc.expectedError {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|