mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-22 16:29:18 +00:00
b8389283d5
This change updates the logic to populate the options for the nvidia runtime configs added to containerd or crio from a default runtime if this is specified and a runc entry is not found. This allows the default runtime values for settings such as SystemdCgroup to be applied correctly. Signed-off-by: Evan Lezar <elezar@nvidia.com>
246 lines
7.0 KiB
Go
246 lines
7.0 KiB
Go
/**
|
|
# Copyright 2024 NVIDIA CORPORATION
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package containerd
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/pelletier/go-toml"
|
|
testlog "github.com/sirupsen/logrus/hooks/test"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAddRuntimeV1(t *testing.T) {
|
|
logger, _ := testlog.NewNullLogger()
|
|
testCases := []struct {
|
|
description string
|
|
config string
|
|
setAsDefault bool
|
|
configOverrides []map[string]interface{}
|
|
expectedConfig string
|
|
expectedError error
|
|
}{
|
|
{
|
|
description: "empty config not default runtime",
|
|
expectedConfig: `
|
|
version = 1
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.test]
|
|
privileged_without_host_devices = false
|
|
runtime_engine = ""
|
|
runtime_root = ""
|
|
runtime_type = ""
|
|
[plugins.cri.containerd.runtimes.test.options]
|
|
BinaryName = "/usr/bin/test"
|
|
Runtime = "/usr/bin/test"
|
|
`,
|
|
expectedError: nil,
|
|
},
|
|
{
|
|
description: "empty config not default runtime with overrides",
|
|
configOverrides: []map[string]interface{}{
|
|
{
|
|
"options": map[string]interface{}{
|
|
"SystemdCgroup": true,
|
|
},
|
|
},
|
|
},
|
|
expectedConfig: `
|
|
version = 1
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.test]
|
|
privileged_without_host_devices = false
|
|
runtime_engine = ""
|
|
runtime_root = ""
|
|
runtime_type = ""
|
|
[plugins.cri.containerd.runtimes.test.options]
|
|
BinaryName = "/usr/bin/test"
|
|
Runtime = "/usr/bin/test"
|
|
SystemdCgroup = true
|
|
`,
|
|
},
|
|
{
|
|
description: "options from runc are imported",
|
|
config: `
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.runc]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.runc.options]
|
|
BinaryName = "/usr/bin/runc"
|
|
SystemdCgroup = true
|
|
`,
|
|
expectedConfig: `
|
|
version = 1
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.runc]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.runc.options]
|
|
BinaryName = "/usr/bin/runc"
|
|
SystemdCgroup = true
|
|
[plugins.cri.containerd.runtimes.test]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.test.options]
|
|
BinaryName = "/usr/bin/test"
|
|
Runtime = "/usr/bin/test"
|
|
SystemdCgroup = true
|
|
`,
|
|
},
|
|
{
|
|
description: "options from default runtime are imported",
|
|
config: `
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
default_runtime_name = "default"
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.default]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.default.options]
|
|
BinaryName = "/usr/bin/default"
|
|
SystemdCgroup = true
|
|
`,
|
|
expectedConfig: `
|
|
version = 1
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
default_runtime_name = "default"
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.default]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.default.options]
|
|
BinaryName = "/usr/bin/default"
|
|
SystemdCgroup = true
|
|
[plugins.cri.containerd.runtimes.test]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.test.options]
|
|
BinaryName = "/usr/bin/test"
|
|
Runtime = "/usr/bin/test"
|
|
SystemdCgroup = true
|
|
`,
|
|
},
|
|
{
|
|
description: "options from runc take precedence over default runtime",
|
|
config: `
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
default_runtime_name = "default"
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.runc]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.runc.options]
|
|
BinaryName = "/usr/bin/runc"
|
|
SystemdCgroup = true
|
|
[plugins.cri.containerd.runtimes.default]
|
|
privileged_without_host_devices = false
|
|
runtime_engine = "defaultengine"
|
|
runtime_root = "defaultroot"
|
|
runtime_type = "defaulttype"
|
|
[plugins.cri.containerd.runtimes.default.options]
|
|
BinaryName = "/usr/bin/default"
|
|
SystemdCgroup = false
|
|
`,
|
|
expectedConfig: `
|
|
version = 1
|
|
[plugins]
|
|
[plugins.cri]
|
|
[plugins.cri.containerd]
|
|
default_runtime_name = "default"
|
|
[plugins.cri.containerd.runtimes]
|
|
[plugins.cri.containerd.runtimes.runc]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.runc.options]
|
|
BinaryName = "/usr/bin/runc"
|
|
SystemdCgroup = true
|
|
[plugins.cri.containerd.runtimes.default]
|
|
privileged_without_host_devices = false
|
|
runtime_engine = "defaultengine"
|
|
runtime_root = "defaultroot"
|
|
runtime_type = "defaulttype"
|
|
[plugins.cri.containerd.runtimes.default.options]
|
|
BinaryName = "/usr/bin/default"
|
|
SystemdCgroup = false
|
|
[plugins.cri.containerd.runtimes.test]
|
|
privileged_without_host_devices = true
|
|
runtime_engine = "engine"
|
|
runtime_root = "root"
|
|
runtime_type = "type"
|
|
[plugins.cri.containerd.runtimes.test.options]
|
|
BinaryName = "/usr/bin/test"
|
|
Runtime = "/usr/bin/test"
|
|
SystemdCgroup = true
|
|
`,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
config, err := toml.Load(tc.config)
|
|
require.NoError(t, err)
|
|
expectedConfig, err := toml.Load(tc.expectedConfig)
|
|
require.NoError(t, err)
|
|
|
|
c := &ConfigV1{
|
|
Logger: logger,
|
|
Tree: config,
|
|
}
|
|
|
|
err = c.AddRuntime("test", "/usr/bin/test", tc.setAsDefault, tc.configOverrides...)
|
|
require.NoError(t, err)
|
|
|
|
require.EqualValues(t, expectedConfig.String(), config.String())
|
|
})
|
|
}
|
|
}
|