mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-22 16:29:18 +00:00
d2516cb5d5
Fix bug in update-ldcache hook when OCI spec contains a relative root See merge request nvidia/container-toolkit/container-toolkit!147
130 lines
3.3 KiB
Go
130 lines
3.3 KiB
Go
/**
|
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
**/
|
|
|
|
package ldcache
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"syscall"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/oci"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/urfave/cli/v2"
|
|
)
|
|
|
|
type command struct {
|
|
logger *logrus.Logger
|
|
}
|
|
|
|
type config struct {
|
|
folders cli.StringSlice
|
|
containerSpec string
|
|
}
|
|
|
|
// NewCommand constructs an update-ldcache command with the specified logger
|
|
func NewCommand(logger *logrus.Logger) *cli.Command {
|
|
c := command{
|
|
logger: logger,
|
|
}
|
|
return c.build()
|
|
}
|
|
|
|
// build the update-ldcache command
|
|
func (m command) build() *cli.Command {
|
|
cfg := config{}
|
|
|
|
// Create the 'update-ldcache' command
|
|
c := cli.Command{
|
|
Name: "update-ldcache",
|
|
Usage: "Update ldcache in a container by running ldconfig",
|
|
Action: func(c *cli.Context) error {
|
|
return m.run(c, &cfg)
|
|
},
|
|
}
|
|
|
|
c.Flags = []cli.Flag{
|
|
&cli.StringSliceFlag{
|
|
Name: "folder",
|
|
Usage: "Specifiy a folder to add to /etc/ld.so.conf before updating the ld cache",
|
|
Destination: &cfg.folders,
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "container-spec",
|
|
Usage: "Specify the path to the OCI container spec. If empty or '-' the spec will be read from STDIN",
|
|
Destination: &cfg.containerSpec,
|
|
},
|
|
}
|
|
|
|
return &c
|
|
}
|
|
|
|
func (m command) run(c *cli.Context, cfg *config) error {
|
|
s, err := oci.LoadContainerState(cfg.containerSpec)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to load container state: %v", err)
|
|
}
|
|
|
|
containerRoot, err := s.GetContainerRoot()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to determined container root: %v", err)
|
|
}
|
|
|
|
err = m.createConfig(containerRoot, cfg.folders.Value())
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update ld.so.conf: %v", err)
|
|
}
|
|
|
|
args := []string{"/sbin/ldconfig"}
|
|
if containerRoot != "" {
|
|
args = append(args, "-r", containerRoot)
|
|
}
|
|
|
|
return syscall.Exec(args[0], args, nil)
|
|
}
|
|
|
|
// createConfig creates (or updates) /etc/ld.so.conf.d/nvcr-<RANDOM_STRING>.conf in the container
|
|
// to include the required paths.
|
|
func (m command) createConfig(root string, folders []string) error {
|
|
if len(folders) == 0 {
|
|
m.logger.Debugf("No folders to add to /etc/ld.so.conf")
|
|
return nil
|
|
}
|
|
|
|
configFile, err := os.CreateTemp(filepath.Join(root, "/etc/ld.so.conf.d"), "nvcr-*.conf")
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create config file: %v", err)
|
|
}
|
|
defer configFile.Close()
|
|
|
|
m.logger.Debugf("Adding folders %v to %v", folders, configFile.Name())
|
|
|
|
configured := make(map[string]bool)
|
|
for _, folder := range folders {
|
|
if configured[folder] {
|
|
continue
|
|
}
|
|
_, err = configFile.WriteString(fmt.Sprintf("%s\n", folder))
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update ld.so.conf.d: %v", err)
|
|
}
|
|
configured[folder] = true
|
|
}
|
|
|
|
return nil
|
|
}
|