UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-22 08:18:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,593 Commits 20 Branches 73 Tags 28 MiB
dce368e308
Commit Graph

1593 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
acc50969dc Fix ifElseChain lint errors 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
48d68e4eff Add nolint for exec calls 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
709e27bf4b Fix implicit memory aliasing in for loop 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
1b16b341dd Fix default permissions 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
2e1f94aedf Fix append assignments 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
2f48ab99c3 Address singleCaseSwitch errors 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
f8870b31be Fix filepath.Join with single arg 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
73857eb8e3 Fix unnecessary conversion 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
dd2f218226 Use MustCompile for static regexp 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
8a9f367067 Check returned error values 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
e0df157f70 Remove unnecessary assignment to the blank identifier 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
f2c9937ca8 Use cdi parser package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
12dc12ce09 Fix misspellings 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
2fad708556 Address ioutil deprecation 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
73749285d5 Remove unused loadSaver interface 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
49dbae5c32 Use .golangci config for toml.Delete issues 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
d8d56e18f9 Add nolint for dxcore 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
7f610d19ed Add .golangci.yml config 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
3eca7dfd7b Replace check targets with golangci-lint 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
b02d5538b0 Merge branch 'update-container-runtime-readme' into 'main' 
Update nvidia-container-runtime README

See merge request nvidia/container-toolkit/container-toolkit!484
 2023-10-24 13:05:12 +00:00
Evan Lezar
ebff62f56b Update nvidia-container-runtime README 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-23 13:35:19 +02:00
Evan Lezar
53b24618a5 Merge branch 'bump-cuda-version' into 'main' 
Add missing changelog entry

See merge request nvidia/container-toolkit/container-toolkit!483
 2023-10-19 11:22:22 +00:00
Evan Lezar
867151fe25 Bump version to v1.14.3 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-19 13:20:23 +02:00
Evan Lezar
82fc309c4e Merge branch 'bump-cuda-version' into 'main' 
Bump version to v1.14.3

See merge request nvidia/container-toolkit/container-toolkit!482
 2023-10-19 09:32:30 +00:00
Evan Lezar
27521c0b5e Bump CUDA base image version to 12.2.2 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-19 10:47:13 +02:00
Evan Lezar
e611d4403b Bump version to v1.14.3 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-19 10:46:46 +02:00
Evan Lezar
807c87e057 Merge branch 'fix-symlink-discovery' into 'main' 
Fix bug in creating symlinks in containers on Tegra-based systems

See merge request nvidia/container-toolkit/container-toolkit!479
 2023-09-25 10:01:08 +00:00
Evan Lezar
f63ad3d9e7 Refactor symlink filter 
This change refactors the use of the symlink filter to make it extendible.
A blocked filter can be set on the Tegra CSV discoverer to ensure that the correct
symlink libraries are filtered out. Here, globs can be used to select mulitple libraries,
and a **/ prefix on the globs indicates that the pattern that follows is only applied to
the filename of the symlink entry in the CSV file.

A --csv.ignore-pattern command line argument is added to the nvidia-ctk cdi generate
command that allows this to be set.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-22 22:04:06 +02:00
Evan Lezar
c4b4478d1a Remove default symlink filter 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-22 22:02:51 +02:00
Evan Lezar
963250a58f Refactor CSV discovery for testability 
This change improves the testibility of the CSV discoverer.
This is done by adding injection points for mocks for library discovery and
symlink resolution.

Note that this highlights a bug in the current implementation where the
library filter causes valid symlinks to be skipped.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-22 22:02:30 +02:00
Evan Lezar
be570fce65 Bump version to 1.14.2 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-22 22:02:28 +02:00
Evan Lezar
6094effd58
Merge branch 'debug-no-cgroups' into 'main' 
Update libnvidia-container

See merge request nvidia/container-toolkit/container-toolkit!478
 2023-09-07 15:55:06 +00:00
Evan Lezar
7187608a36
Update libnvidia-container 2023-09-07 15:55:06 +00:00
Evan Lezar
a54d9d2118
Merge branch 'debug-no-cgroups' into 'main' 
Update libnvidia-container

See merge request nvidia/container-toolkit/container-toolkit!477
 2023-09-07 15:36:23 +00:00
Evan Lezar
56dd69ff1c Update libnvidia-container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-07 17:35:48 +02:00
Evan Lezar
89240cecae
Merge branch 'debug-no-cgroups' into 'main' 
Add required option to new toml config

See merge request nvidia/container-toolkit/container-toolkit!476
 2023-09-07 11:16:34 +00:00
Evan Lezar
4ec9bd751e Add required option to new toml config 
This change adds a "required" option to the new toml config
that controls whether a default config is returned or not.
This is useful from the NVIDIA Container Runtime Hook, where
/run/driver/nvidia/etc/nvidia-container-runtime/config.toml
is checked before the standard path.

This fixes a bug where the default config was always applied
when this config was not used.

See https://github.com/NVIDIA/nvidia-container-toolkit/issues/106

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-07 11:56:01 +02:00
Evan Lezar
d74f7fef4e Update libnvidia-container to fix rpm builds 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-07 11:55:46 +02:00
Evan Lezar
538d4020df Bump version to v1.14.1 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-09-06 17:51:52 +02:00
Evan Lezar
f2bd3173d4 Merge branch 'bump-version-v1.14.0' into 'main' 
Bump verison to v1.14.0

See merge request nvidia/container-toolkit/container-toolkit!475
 2023-08-29 14:45:37 +00:00
Evan Lezar
2bf8017516 Bump verison to v1.14.0 
Note that v1.14.0-rc.3 was an internal-only release.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-29 16:03:41 +02:00
Evan Lezar
2a3afdd5d9 Merge branch 'fix-platform-detection' into 'main' 
Add UsesNVGPUModule info function

See merge request nvidia/container-toolkit/container-toolkit!473
 2023-08-28 15:58:41 +00:00
Evan Lezar
1dc028cdf2 Add UsesNVGPUModule info function 
This change adds a UsesNVGPUModule function that checks whether the nvgpu
kernel module is used by NVML. This allows for more robust detection of
Tegra-based platforms where libnvidia-ml.so is supported to enumerate the
iGPU.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-25 11:24:34 +02:00
Evan Lezar
72c56567fe Merge branch 'CNT-4496/remove/sys/devices/soc' into 'main' 
Remove /sys/devices/soc0/family from CDI spec

See merge request nvidia/container-toolkit/container-toolkit!472
 2023-08-25 08:26:15 +00:00
Evan Lezar
ca1055588d Remove /sys/devices/soc0/family from CDI spec 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-25 10:25:33 +02:00
Evan Lezar
fca30d7acc Merge branch 'fix-config-file' into 'main' 
Properly create output for config file

See merge request nvidia/container-toolkit/container-toolkit!471
 2023-08-23 08:55:58 +00:00
Evan Lezar
5bf2209fdb Properly create output for config file 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-23 09:41:46 +02:00
Evan Lezar
f86a5abeb6 Merge branch 'CNT-4478/fix-unknown-devices' into 'main' 
Update go-nvlib dependency to  v0.0.0-20230818092907-09424fdc8884

See merge request nvidia/container-toolkit/container-toolkit!470
 2023-08-21 09:05:58 +00:00
Evan Lezar
9ac313f551 Instantiate nvpci.Interface with logger 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-18 11:40:17 +02:00
Evan Lezar
546f810159 Update go-nvlib dependency to v0.0.0-20230818092907-09424fdc8884 
This change updates go-nvlib to include logic to skip NVIDIA PCI-E
devices where the name or class id is not known.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-08-18 11:40:15 +02:00