UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-27 22:42:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,047 Commits 21 Branches 73 Tags 29 MiB
dcd65a6410
Commit Graph

2047 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
2987c4d670
Merge pull request #740 from elezar/imex-by-volume-mount 
Allow IMEX channel requests by volume mount
 2024-10-17 17:56:12 +02:00
Evan Lezar
2e6712d2bc Allow IMEX channels to be requested as volume mounts 
This change allows IMEX channels to be requested using the
volume mount mechanism.

A mount from /dev/null to /var/run/nvidia-container-devices/imex/{{ .ChannelID }}
is equivalent to including {{ .ChannelID }} in the NVIDIA_IMEX_CHANNELS
envvironment variables.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 16:54:29 +02:00
Evan Lezar
92df542f2f [no-relnote] Use image.CUDA to extract visible devices 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 16:53:17 +02:00
Evan Lezar
1991b3ef2a [no-relnote] Use string slice for devices in hook 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 16:53:17 +02:00
Evan Lezar
cdf39fbad3 [no-relnote] Use symlinks.Resolve in hook 
This change removes duplicate logic from the create-symlinks hook
and uses symlinks.Resolve instead.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 15:47:13 +02:00
Evan Lezar
c30ca0fdc3 Fix typo in error message 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 15:46:49 +02:00
Evan Lezar
b077e2648d
Merge pull request #741 from elezar/imex-default 
Add disableIMEXChannelCreation feature flag
 2024-10-17 15:26:21 +02:00
Evan Lezar
457d71c170 Add disable-imex-channel-creation feature flag 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 14:26:24 +02:00
Evan Lezar
bc9180b59d Expose opt-in features in toolkit-container 
This change enables opt-in (off-by-default) features to be opted into.
These features can be toggled by name by specifying the (repeated)
--opt-in-features command line argument or as a comma-separated list
in the NVIDIA_CONTAINER_TOOLKIT_OPT_IN_FEATURES environment variable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-17 14:26:24 +02:00
Evan Lezar
ec8dfaf779
Merge pull request #743 from elezar/remove-opt-in-features 
Remove ability to set per-container features in the config file
 2024-10-17 13:46:23 +02:00
Evan Lezar
c129122da6
Merge pull request #742 from NVIDIA/dependabot/docker/deployments/container/main/nvidia/cuda-12.6.2-base-ubuntu20.04 
Bump nvidia/cuda from 12.6.1-base-ubuntu20.04 to 12.6.2-base-ubuntu20.04 in /deployments/container
 2024-10-17 11:49:05 +02:00
Evan Lezar
0abf800000
Merge pull request #744 from elezar/fix-script 
[no-relnote] Fix typo in script
 2024-10-16 15:32:09 +02:00
Evan Lezar
1d9d0acf7d [no-relnote] Remove feature flag for per-container features 
This change REMOVES the ability to set opt-in features
(e.g. GDS, MOFED, GDRCOPY) in the config file. The existing
per-container envvars are unaffected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-16 15:30:31 +02:00
Evan Lezar
17f14278a9 [no-relnote] Fix typo in script 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-16 10:53:45 +02:00
dependabot[bot]
1fa5bbf351
Bump nvidia/cuda in /deployments/container 
Bumps nvidia/cuda from 12.6.1-base-ubuntu20.04 to 12.6.2-base-ubuntu20.04.

---
updated-dependencies:
- dependency-name: nvidia/cuda
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-15 09:07:59 +00:00
Evan Lezar
f794d09df1
Merge pull request #729 from NVIDIA/dependabot/go_modules/main/golang.org/x/sys-0.26.0 
Bump golang.org/x/sys from 0.25.0 to 0.26.0
 2024-10-11 16:16:15 +02:00
Evan Lezar
17a2377ad5
Merge pull request #734 from NVIDIA/minor-cleanup 
minor cleanup and improvements
 2024-10-11 16:15:19 +02:00
Tariq Ibrahim
b90ee5d100 [no-relnote] minor cleanup and improvements 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-11 16:14:41 +02:00
Evan Lezar
1ef3f4048f
Merge pull request #733 from elezar/add-imex-channels-to-management-spec 
Add imex channels to management CDI spec
 2024-10-11 15:28:50 +02:00
Evan Lezar
7fb31bd1dc
Merge pull request #732 from elezar/add-z-lazy 
Add -z,lazy to LDFLAGS
 2024-10-11 15:20:30 +02:00
Evan Lezar
e2fe591535 Add -z,lazy to LDFLAGS 
This fixes undefined symbol errors on platforms where -z,lazy may
not be the default.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-11 15:20:06 +02:00
Evan Lezar
adf3708d0b Add imex channels to management CDI spec 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-10 14:38:33 +02:00
Evan Lezar
a06d838b1c
Merge pull request #686 from NVIDIA/get-config-from-cmdline 
Fetch current container runtime config
 2024-10-10 11:58:08 +02:00
Tariq Ibrahim
f477dc0df1
fetch current container runtime config through the command line 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>

add default runtime binary path to runtimes field of toolkit config toml

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>

[no-relnote] Get low-level runtimes consistently

We ensure that we use the same low-level runtimes regardless
of the runtime engine being configured. This ensures consistent
behaviour.

Signed-off-by: Evan Lezar <elezar@nvidia.com>

Co-authored-by: Evan Lezar <elezar@nvidia.com>

address review comment

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
 2024-10-10 01:13:20 -07:00
dependabot[bot]
879bb9ffd5
Bump golang.org/x/sys from 0.25.0 to 0.26.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.25.0 to 0.26.0.
- [Commits](https://github.com/golang/sys/compare/v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 08:57:11 +00:00
Tariq
4604e3b6c8
Merge pull request #725 from elezar/fix-nvsandboxutils 
Ensure that nvsandboxutils is available for version
 2024-10-04 04:58:03 +08:00
dependabot[bot]
a9ca6995f7
Bump golang from 1.23.1 to 1.23.2 in /deployments/devel 
Bumps golang from 1.23.1 to 1.23.2.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-02 08:37:23 +00:00
Evan Lezar
7cd2aef0d8 Ensure that nvsandboxutils is available for version 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-02 09:37:05 +02:00
Evan Lezar
19482dac6f
Merge pull request #715 from elezar/add-libcuda-so-symlink 
Align driver symlinks with libnvidia-container
 2024-10-01 18:16:36 +02:00
Evan Lezar
78c4ca8a12
Merge pull request #693 from NVIDIA/dependabot/go_modules/deployments/devel/main/github.com/golangci/golangci-lint-1.61.0 
Bump github.com/golangci/golangci-lint from 1.60.1 to 1.61.0 in /deployments/devel
 2024-10-01 11:40:31 +02:00
Evan Lezar
b12bdfc52a
Merge pull request #691 from elezar/fix-codeql 
Add an explicit CodeQL workflow to this repostitory
 2024-10-01 11:39:34 +02:00
Evan Lezar
82ae2e615a Add creation of select driver symlinks to CDI spec 
This change aligns the creation of symlinks under CDI with
the implementation in libnvidia-container. If the driver libraries
are present, the following symlinks are created:

* {{ .LibRoot }}/libcuda.so -> libcuda.so.1
* {{ .LibRoot }}/libnvidia-opticalflow.so -> libnvidia-opticalflow.so.1
* {{ .LibRoot }}/libGLX_indirect.so.0 -> libGLX_nvidia.so.{{ .Version }}

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-10-01 11:34:58 +02:00
Tariq
4f440dedda
Merge pull request #722 from tariq1890/use-go-api-for-toolkit-install-rebase 2024-10-01 07:41:28 +08:00
Evan Lezar
3ee678f4f6
Convert crio to runtime package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:40:30 -07:00
Evan Lezar
103375e504
Convert containerd to runtime package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:39:52 -07:00
Evan Lezar
5bedbc2b50
Convert docker to runtime package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:36:35 -07:00
Evan Lezar
94337b7427
Add runtime package for runtime setup 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:36:35 -07:00
Evan Lezar
046a05921f
Convert toolkit to go package 
This change converts the toolkit installation logic to a go package
and invokes this installation over the go API instead of starting
this executable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:36:35 -07:00
Tariq
6ca2700a17
Merge pull request #721 from NVIDIA/devel-check-modules 
add go modules check for deployments/devel
 2024-10-01 05:35:45 +08:00
Tariq Ibrahim
0d626cfbb7
add go modules check for deployments/devel 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
 2024-09-30 12:13:56 -07:00
Tariq
10bafd1d09
Merge pull request #643 from elezar/refactor-toml-source 
Refactor handling of TOML config files for runtimes
 2024-10-01 00:59:52 +08:00
Evan Lezar
bf2bdfd35e Refactor Toml config handling 
This change refactors the toml config file handlig for runtimes
such as containerd or crio. A toml.Loader is introduced that
encapsulates loading the required file.

This can be extended to allow other mechanisms for loading
loading the current config.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-30 14:24:18 +02:00
Evan Lezar
f126877254
Merge pull request #716 from elezar/discover-vdpau-libraries 
Also search for driver libraries in vdpau
 2024-09-30 11:18:49 +02:00
Evan Lezar
006aebf31e
Merge pull request #717 from elezar/fix-libnvidia-allocator-so-1 
Skip explicit creation of libnvidia-allocator.so.1 symlink
 2024-09-30 11:06:08 +02:00
Evan Lezar
6c5f4eea63 Remove support for config overrides 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-27 13:23:35 +02:00
dependabot[bot]
b0b7c7c9ee
Bump github.com/golangci/golangci-lint in /deployments/devel 
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.60.1 to 1.61.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.60.1...v1.61.0)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-26 14:45:16 +00:00
Evan Lezar
b466270a24
Merge pull request #666 from NVIDIA/dependabot/go_modules/deployments/devel/main/github.com/matryer/moq-0.5.0 
Bump github.com/matryer/moq from 0.3.4 to 0.5.0 in /deployments/devel
 2024-09-26 16:43:49 +02:00
Evan Lezar
d806f1045b
Merge pull request #677 from NVIDIA/dependabot/docker/deployments/container/main/nvidia/cuda-12.6.1-base-ubuntu20.04 
Bump nvidia/cuda from 12.6.0-base-ubuntu20.04 to 12.6.1-base-ubuntu20.04 in /deployments/container
 2024-09-26 16:43:08 +02:00
Evan Lezar
35ee96ac41
Merge pull request #685 from NVIDIA/dependabot/go_modules/main/golang.org/x/sys-0.25.0 
Bump golang.org/x/sys from 0.24.0 to 0.25.0
 2024-09-26 16:42:30 +02:00
Evan Lezar
f8141aab27 Skip explicit creation of libnvidia-allocator.so.1 symlink 
Since we expect .so.1 symlinks to be created by ldconfig, we don't
explicitly request these. This change removes the creation of
a libnvidia-allocator.so.1 -> libnvidia-allocator.so.RM_VERSION symlink
through the create-symlinks hook.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-26 16:34:39 +02:00