Tariq Ibrahim
9c6dd94ac8
Merge branch 'disc-typos' into 'main'
...
fix minor typos and rm unused logger param
See merge request nvidia/container-toolkit/container-toolkit!540
2024-01-23 18:42:21 +00:00
Evan Lezar
f936f4c0bc
Add --cdi.enable as alias for --cdi.enabled
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-23 14:57:15 +01:00
Evan Lezar
ab598f004d
Fix --cdi.enabled for Docker
...
Instead of relying only on Experimental mode, the docker daemon
config requires that CDI is an opt-in feature.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-23 14:56:08 +01:00
Tariq Ibrahim
9c1f0bb08b
fix minor typos and rm unused logger param
...
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
2024-01-22 16:48:11 -08:00
Evan Lezar
b3519fadc4
Merge branch 'ldconfig-path' into 'main'
...
Allow for customizing the path to ldconfig and call ldconfig with explicit cache/config paths
See merge request nvidia/container-toolkit/container-toolkit!525
2024-01-22 12:36:51 +00:00
Jared Baur
d80657dd0a
Explicitly set ldconfig cache and config file
...
Since the `update-ldcache` hook uses the host's `ldconfig`, the default
cache and config files configured on the host will be used. If those
defaults differ from what nvidia-ctk expects it to be (/etc/ld.so.cache
and /etc/ld.so.conf, respectively), then the hook will fail. This change
makes the call to ldconfig explicit in which cache and config files are
being used.
Signed-off-by: Jared Baur <jaredbaur@fastmail.com>
2024-01-18 02:23:27 -08:00
Jared Baur
838493b8b9
Allow for customizing the path to ldconfig
...
Since the `createContainer` `runc` hook runs with the environment that
the container's config.json specifies, the path to `ldconfig` may not be
easily resolvable if the host environment differs enough from the
container (e.g. on a NixOS host where all binaries are under hashed
paths in /nix/store with an Ubuntu container whose PATH contains
FHS-style paths such as /bin and /usr/bin). This change allows for
specifying exactly where ldconfig comes from.
Signed-off-by: Jared Baur <jaredbaur@fastmail.com>
2024-01-17 21:07:00 -08:00
Evan Lezar
26a4eb327c
Merge branch 'add-crun-as-configured-runtime' into 'main'
...
Set default low-level runtimes to runc, crun
See merge request nvidia/container-toolkit/container-toolkit!536
2024-01-17 21:28:14 +00:00
Evan Lezar
f6c252cbde
Add crun as a default low-level runtime.
...
This change adds crun as a configured low-level runtime.
Note that runc still preferred and will be used if present on the
system.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-17 11:31:07 +01:00
Evan Lezar
11692a8499
Merge branch 'bump-cuda-12.3.1' into 'main'
...
Bump CUDA base image to 12.3.1
See merge request nvidia/container-toolkit/container-toolkit!535
2024-01-11 14:03:32 +00:00
Evan Lezar
ba3d80e8ea
Merge branch 'fix-user-group' into 'main'
...
Fix bug in determining CLI user on SUSE systems
See merge request nvidia/container-toolkit/container-toolkit!532
2024-01-11 13:19:25 +00:00
Evan Lezar
9c029cac72
Fix bug in determining CLI user on SUSE systems
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-11 13:54:40 +01:00
Evan Lezar
dd065fa69e
Bump CUDA base image to 12.3.1
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-11 10:35:54 +01:00
Evan Lezar
6f3d9307bb
Merge branch 'update-libnvidia-container' into 'main'
...
Update libnvidia-container to a4ef85eb
See merge request nvidia/container-toolkit/container-toolkit!533
2024-01-10 14:14:39 +00:00
Evan Lezar
72584cd863
Update libnvidia-container to a4ef85eb
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-10 14:29:03 +01:00
Evan Lezar
2a7bfcd36b
Merge branch 'fix-mid-device-nodes' into 'main'
...
Use devRoot to resolve MIG device nodes
See merge request nvidia/container-toolkit/container-toolkit!526
2024-01-09 14:58:19 +00:00
Evan Lezar
21fc1f24e4
Use devRoot to resolve MIG device nodes
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-09 15:40:17 +01:00
Evan Lezar
9396858834
Merge branch 'libnvdxgdmal' into 'main'
...
Add libnvdxgdmal library
See merge request nvidia/container-toolkit/container-toolkit!529
2024-01-09 14:37:08 +00:00
Jakub Bujak
79acd7acff
Add libnvdxgdmal library
...
This change adds the new libnvdxgdmal.so.1 library to the list of files copied from the DriverStore.
Signed-off-by: Jakub Bujak <jbujak@nvidia.com>
2024-01-09 15:29:55 +01:00
Evan Lezar
fab711ddf3
Merge branch 'remove-libseccomp-dependency' into 'main'
...
Remove libseccomp package dependency
See merge request nvidia/container-toolkit/container-toolkit!531
2024-01-09 09:44:23 +00:00
Evan Lezar
760cf93317
Remove libseccomp package dependency
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2024-01-09 10:02:06 +01:00
Evan Lezar
f4838dde9b
Merge branch 'log-requested-mode' into 'main'
...
Log explicitly requested runtime mode
See merge request nvidia/container-toolkit/container-toolkit!527
2024-01-08 11:42:42 +00:00
Evan Lezar
c90211e070
Log explicitly requested runtime mode
...
For users running the nvidia-container-runtime it would be useful
to determine the runtime mode used from the logs directly instead
of relying on other log messages as signals. This change ensures
that an explicitly selected mode is also logged instead of only
when mode=auto.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-12-15 15:35:35 +01:00
Evan Lezar
a2262d00cc
Merge branch 'tegra-chardev-discover' into 'main'
...
Use `devRoot` for discovering character devices on Tegra platforms
See merge request nvidia/container-toolkit/container-toolkit!524
2023-12-15 14:34:07 +00:00
Jared Baur
95b8ebc297
Use devRoot
for discovering character devices on Tegra platforms
...
Signed-off-by: Jared Baur <jaredbaur@fastmail.com>
2023-12-14 11:46:21 -08:00
Evan Lezar
99b3050d20
Merge branch 'update-changelog' into 'main'
...
Update changelog
See merge request nvidia/container-toolkit/container-toolkit!523
2023-12-14 15:35:45 +00:00
Evan Lezar
883f7ec3d8
Update changelog
...
See merge request nvidia/container-toolkit/container-toolkit!522
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-12-14 13:47:38 +01:00
Evan Lezar
9dd324be9c
Merge branch 'tegra-dev-root' into 'main'
...
Fix using `devRoot` on Tegra platforms
See merge request nvidia/container-toolkit/container-toolkit!522
2023-12-14 09:46:05 +00:00
Jared Baur
508438a0c5
Fix using devRoot
on Tegra platforms
...
Using `WithDevRoot` on Tegra platforms was incorrectly setting
`driverRoot`, fix it so that it correctly sets `devRoot`.
Signed-off-by: Jared Baur <jaredbaur@fastmail.com>
2023-12-13 19:56:02 -08:00
Christopher Desiniotis
9baed635d1
Merge branch 'CNT-4778/bump-gonvlib' into 'main'
...
Update to github.com/NVIDIA/go-nvlib@f3264c8a6a7a
See merge request nvidia/container-toolkit/container-toolkit!520
2023-12-13 18:11:59 +00:00
Christopher Desiniotis
895a5ed73a
Update to github.com/NVIDIA/go-nvlib@f3264c8a6a7a
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-13 10:08:14 -08:00
Christopher Desiniotis
2d7b126bc9
Merge branch 'CNT-4762/extend-runtime-cdi-device-names' into 'main'
...
Extend the 'runtime.nvidia.com/gpu' CDI device kind to support full-GPUs...
See merge request nvidia/container-toolkit/container-toolkit!514
2023-12-06 17:10:26 +00:00
Christopher Desiniotis
86d86395ea
Update changelog for the automatic CDI spec generation added for the 'runtime.nvidia.com/gpu' CDI kind
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:09:10 -08:00
Christopher Desiniotis
32c3bd1ded
Fallback to standard CDI modifier when creation of automatic CDI modifier fails
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:02:19 -08:00
Christopher Desiniotis
3158146946
Extend the 'runtime.nvidia.com/gpu' CDI device kind to support MIG devices specified by index or UUID
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:02:19 -08:00
Christopher Desiniotis
def7d09f85
Refactor how device identifiers are parsed before performing automatic CDI spec generation
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:02:19 -08:00
Christopher Desiniotis
b9ac54b922
Add GetDeviceSpecsByID() API to the nvcdi Interface
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:02:19 -08:00
Christopher Desiniotis
ae1b7e126c
Extend the 'runtime.nvidia.com/gpu' CDI device kind to support full-GPUs specified by index or UUID
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-06 09:02:19 -08:00
Evan Lezar
08ef3e7969
Merge branch 'bump-version-1.15.0-rc.2' into 'main'
...
Bump version to v1.15.0-rc.2
See merge request nvidia/container-toolkit/container-toolkit!519
2023-12-06 16:45:29 +00:00
Evan Lezar
ea977fb43e
Bump version to v1.15.0-rc.2
...
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-12-06 17:45:08 +01:00
Evan Lezar
7b47eee634
Merge branch 'CNT-4774/implement-set-for-crio' into 'main'
...
Implement Set() for the crio implementation of engine.Interface
See merge request nvidia/container-toolkit/container-toolkit!517
2023-12-05 09:30:42 +00:00
Christopher Desiniotis
d7a3d93024
Implement Set() for the crio implementation of engine.Interface
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-04 15:27:35 -08:00
Christopher Desiniotis
527248ef5b
Merge branch 'CNT-4764/cleanup-engine-interface' into 'main'
...
Refactor the engine.Interface such that the Set() API does not return an extraneous error
See merge request nvidia/container-toolkit/container-toolkit!515
2023-12-04 23:05:30 +00:00
Christopher Desiniotis
83ad09b179
Refactor the engine.Interface such that the Set() API does not return an extraneous error
...
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
2023-12-01 15:59:34 -08:00
Evan Lezar
ffe7ed313a
Merge branch 'goimports-local' into 'main'
...
run goimports -local against the entire codebase
See merge request nvidia/container-toolkit/container-toolkit!512
2023-12-01 10:54:26 +00:00
Tariq Ibrahim
7627d48a5c
run goimports -local against the entire codebase
...
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-12-01 11:13:17 +01:00
Evan Lezar
5c78e2b7e6
Merge branch 'CNT-4659/transform-container-roots' into 'main'
...
Add transformer for container roots
See merge request nvidia/container-toolkit/container-toolkit!507
2023-12-01 09:38:39 +00:00
Evan Lezar
bc4e19aa48
Add --relative-to option to nvidia-ctk transform root
...
This change adds a --relative-to option to the nvidia-ctk transform root
command. This defaults to "host" maintaining the existing behaviour.
If --relative-to=container is specified, the root transform is applied to
container paths in the CDI specification instead of host paths.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-11-30 20:26:42 +01:00
Evan Lezar
879cc99aac
Add transformer for container roots
...
This change renames the root transformer to indicate that it
operates on host paths and adds a container root transformer for
explicitly transforming container roots.
The transform.NewRootTransformer constructor still exists, but has
been marked as deprecated.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2023-11-30 20:26:42 +01:00
Evan Lezar
aa72dcde97
Merge branch 'golangci-lint-on-darwin' into 'main'
...
Allow make check to run on non-linux platforms
See merge request nvidia/container-toolkit/container-toolkit!509
2023-11-27 13:51:08 +00:00