UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-25 05:21:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,532 Commits 21 Branches 73 Tags 29 MiB
895a5ed73a
Commit Graph

1532 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
039d7fd324 Merge branch 'remove-config-import-from-discover' into 'main' 
Remove NewGraphicsDiscoverer API simplification

See merge request nvidia/container-toolkit/container-toolkit!498
 2023-11-20 22:52:02 +00:00
Christopher Desiniotis
2768023ff5 Merge branch 'gen-cdi-spec-at-runtime' into 'main' 
Automatically generate CDI spec for the runtime.nvidia.com/gpu=all device

See merge request nvidia/container-toolkit/container-toolkit!492
 2023-11-20 22:15:05 +00:00
Evan Lezar
255181a5ff Rename NewGraphicsDiscoverer as NewDRMNodesDiscoverer 
This change renames NewGraphicsDiscoverer to NewDRMNodesDiscoverer and
instead calls NewGraphicsMountsDiscoverer explicitly when constructing
a graphics modifier.

This avoids the import of config.Config into the discover package
which leads to a transitive dependency on toml-specifics and
requires that the vendor/github.com/pelletier/ package
be vendored in to consumers.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 23:10:57 +01:00
Christopher Desiniotis
dc36ea76e8 Automatically generate CDI spec for the runtime.nvidia.com/gpu=all device 
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
 2023-11-20 13:35:07 -08:00
Evan Lezar
e315d7d74b Merge branch 'allow-separate-dev-root' into 'main' 
Add devRoot option to CDI api

See merge request nvidia/container-toolkit/container-toolkit!497
 2023-11-20 21:10:12 +00:00
Evan Lezar
b4c6832828 Add additional debug 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 21:29:35 +01:00
Evan Lezar
3a96a00362 Simplify meta device discovery 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 21:29:35 +01:00
Evan Lezar
00a712d018 Add --dev-root option to CDI spec generation 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 21:29:35 +01:00
Evan Lezar
d4e21fdd10 Add devRoot option to CDI api 
A driverRoot defines both the driver library root and the
root for device nodes. In the case of preinstalled drivers or
the driver container, these are equal, but in cases such as GKE
they do not match. In this case, drivers are extracted to a folder
and devices exist at the root /.

The changes here add a devRoot option to the nvcdi API that allows the
parent of /dev to be specified explicitly.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 21:29:35 +01:00
Ievgen Popovych
9085cb7dd5 nvidia-ctk hook chmod: Move file mode parsing into flag validation function 
Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
 2023-11-20 14:49:29 +02:00
Evan Lezar
f6e3593a72 Merge branch 'update-go-nvlib' into 'main' 
Update to github.com/NVIDIA/go-nvlib@9fd385bace0d2b8949cf60d9fcaab6169bde87ef

See merge request nvidia/container-toolkit/container-toolkit!495
 2023-11-20 11:25:25 +00:00
Evan Lezar
f2ef7ee661 Update to github.com/NVIDIA/go-nvlib@9fd385bace0d2b8949cf60d9fcaab6169bde87ef 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 12:25:08 +01:00
Evan Lezar
27777f4dab Merge branch 'bump-libnvidia-container' into 'main' 
Update libnvidia-container

See merge request nvidia/container-toolkit/container-toolkit!494
 2023-11-20 11:11:15 +00:00
Evan Lezar
34175f15d3 Update libnvidia-container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-20 10:57:35 +01:00
Ievgen Popovych
eb35d9b30a nvidia-ctk hook chmod: Ignore permission errors 
In some cases we might get a permission error trying to chmod -
most likely this is due to something beyond our control
like whole `/dev` being mounted.
Do not fail container creation in this case.

Due to loosing control of the program after `exec()`-ing `chmod(1)` program
and therefore not being able to handle errors -
refactor to use `chmod(2)` syscall instead of `exec()` `chmod(1)` program.

Fixes: #143
Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
 2023-11-20 01:29:51 +02:00
Ievgen Popovych
f1d32f2cd3 nvidia-ctk hook chmod: Only chmod if desired permissions are different 
This is to avoid any unnecessary potential errors (e.g. due to permissions).

Fixes: #143
Signed-off-by: Ievgen Popovych <jmennius@gmail.com>
 2023-11-20 01:18:36 +02:00
Evan Lezar
ee713adf33 Merge branch 'fix-update-ldcache' into 'main' 
Allow ldcache update in container to be skipped

See merge request nvidia/container-toolkit/container-toolkit!485
 2023-11-18 11:37:56 +00:00
Christopher Desiniotis
33cb1b68df Merge branch 'deduplicate-symlinks' into 'main' 
Deduplicate symlinks

See merge request nvidia/container-toolkit/container-toolkit!493
 2023-11-17 17:09:18 +00:00
Evan Lezar
6dc9ee3f33 Allow ldcache update in container to be skipped 
This change skips the update of ld.cache in the container if it
doesn't exist. Instead, the -N flag is used to only create the
relevant symlinks.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-17 11:56:19 +01:00
Evan Lezar
e609e41a64 Allow multiple pattern matches for symlinks 
Since we allow pattern inputs for locating symlinks we could have
multiples. The error being checked is resolved by the deduplication.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-17 10:43:52 +01:00
Evan Lezar
80ecd024ee Add tests for library locator 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-17 10:43:52 +01:00
Evan Lezar
e8dbb216a5 Return empty ldcache if cache does not exist 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-17 10:14:03 +01:00
Christopher Desiniotis
f5d8d248b7 Deduplicate symlinks 
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
 2023-11-16 17:57:31 -08:00
Evan Lezar
5d7ee25b37 Merge branch 'migrate-go-nvlib' into 'main' 
Use github.com/NVIDIA/go-nvlib imports

See merge request nvidia/container-toolkit/container-toolkit!491
 2023-11-15 20:39:35 +00:00
Evan Lezar
2ff2d84283 Update vendoring 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-15 21:38:54 +01:00
Evan Lezar
c63fb35ba8 Use github.com/NVIDIA/go-nvlib imports 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-15 21:38:26 +01:00
Evan Lezar
da0755769f Merge branch 'improve-library-lookup' into 'main' 
Make CDI-based library discovery more robust

See merge request nvidia/container-toolkit/container-toolkit!488
 2023-11-06 18:17:25 +00:00
Evan Lezar
04b28d116c Make library lookups more robust 
These changes make library lookups more robust. The core change is that
library lookups now first look a set of predefined locations before checking
the ldcache. This also handles cases where an ldcache is not available more
gracefully.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-06 12:15:28 -06:00
Evan Lezar
65b0b2b5e0 Merge branch 'make-graphics-optional' into 'main' 
Make discovery of graphics libraries optional

See merge request nvidia/container-toolkit/container-toolkit!489
 2023-11-03 21:22:47 +00:00
Evan Lezar
8d52cc18ce Make discovery of graphics libraries optional 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-03 22:15:41 +01:00
Evan Lezar
c25376afa0 Merge branch 'update-cdi' into 'main' 
Use tags.cncf.io for CDI imports

See merge request nvidia/container-toolkit/container-toolkit!487
 2023-11-02 09:14:30 +00:00
Evan Lezar
7cc0c1f1cf Run go mod tidy 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-01 12:42:07 +01:00
Evan Lezar
e56bb09889 Use tags.cncf.io for CDI imports 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-11-01 12:40:51 +01:00
Evan Lezar
c7a7083e64 Merge branch 'add-option-to-enable-cdi' into 'main' 
Add cdi.enabled config option to nvidia-ctk runtime configure command

See merge request nvidia/container-toolkit/container-toolkit!486
 2023-11-01 09:54:19 +00:00
Evan Lezar
61595aa0fa Add cdi.enabled option to runtime configure 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-31 17:23:55 +01:00
Evan Lezar
b8b134f389 Ensure git works in container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-31 15:25:41 +01:00
Evan Lezar
c5a9ed6594 Merge branch 'support-cdi-mount-devices' into 'main' 
Support CDI devices as mounts

See merge request nvidia/container-toolkit/container-toolkit!480
 2023-10-27 20:04:46 +00:00
Evan Lezar
833254fa59 Support CDI devices as mounts 
This change allows CDI devices to be requested as mounts in the
container. This enables their use in environments such as kind
where environment variables or annotations cannot be used.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-27 21:24:53 +02:00
Evan Lezar
1b1aae9c4a Merge branch 'golangci-lint' into 'main' 
Use golanglint-ci to check code in NVIDIA Container Toolkit

See merge request nvidia/container-toolkit/container-toolkit!474
 2023-10-24 18:59:46 +00:00
Evan Lezar
acc50969dc Fix ifElseChain lint errors 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
48d68e4eff Add nolint for exec calls 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
709e27bf4b Fix implicit memory aliasing in for loop 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
1b16b341dd Fix default permissions 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
2e1f94aedf Fix append assignments 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
2f48ab99c3 Address singleCaseSwitch errors 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
f8870b31be Fix filepath.Join with single arg 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
73857eb8e3 Fix unnecessary conversion 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:11:34 +02:00
Evan Lezar
dd2f218226 Use MustCompile for static regexp 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
8a9f367067 Check returned error values 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00
Evan Lezar
e0df157f70 Remove unnecessary assignment to the blank identifier 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2023-10-24 20:00:24 +02:00