UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-11-22 00:08:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,040 Commits 20 Branches 73 Tags 28 MiB
1467f3f339
Commit Graph

2040 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sananya Majumder
978d439cf8 nvsandboxutils: Add internal bindings 
This change adds the internal bindings for Sandboxutils, some of which
have been automatically generated with the help of c-for-go. The format
followed is similar to what is used in go-nvml. These would need to be
regenerated when the header file is modified and new APIs are added.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Huy Nguyen <huyn@nvidia.com>
Signed-off-by: Sananya Majumder <sananyam@nvidia.com>
 2024-09-24 10:05:05 -07:00
Sananya Majumder
aa946f3f59 nvsandboxutils: Add script to generate bindings 
This change adds a script and related files to generate the internal
bindings for Sandboxutils library with the help of c-for-go.
This can be used to update the bindings when the header file is modified
with reference to how they are generated with the Makefile in go-nvml.

Run: ./update-bindings.sh

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Huy Nguyen <huyn@nvidia.com>
Signed-off-by: Sananya Majumder <sananyam@nvidia.com>
 2024-09-24 10:04:48 -07:00
Evan Lezar
a5a5833c14
Merge pull request #710 from elezar/update-changelog 
Update CHANGELOG.md for v1.16.2 release
 2024-09-24 17:22:29 +02:00
Evan Lezar
8e07d90802 Update CHANGELOG.md for v1.16.2 release 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-24 14:12:24 +02:00
Evan Lezar
2aadbbf22d
Merge pull request #709 from elezar/bump-version-v1.16.2 
Bump version to v1.16.2
 2024-09-20 20:52:54 +02:00
Evan Lezar
88f9414849 Bump version to v1.16.2 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-20 20:50:33 +02:00
Evan Lezar
53c2dc6301
Merge pull request #705 from elezar/remove-libnvidia-contianer-update-check 
[no-relnote] Don't check for submodule changes
 2024-09-20 20:50:17 +02:00
Evan Lezar
3121663537
Merge pull request #708 from elezar/revert-check-symlink-resolution 
Revert "Merge pull request #696 from elezar/check-link-resolution"
 2024-09-20 20:50:02 +02:00
Evan Lezar
4b6de8036d
Merge pull request #707 from elezar/revert-no-persistenced-flag-by-default 
Revert #703 and #694
 2024-09-20 20:46:13 +02:00
Evan Lezar
dc2ccdd2fa Revert "Merge pull request #696 from elezar/check-link-resolution" 
This reverts commit c490baab63, reversing
changes made to 32486cf1e9.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-20 20:29:42 +02:00
Evan Lezar
5145b0a4b6 Revert "Merge pull request #694 from elezar/add-opt-in-to-sockets" 
This reverts commit b061446694, reversing
changes made to c490baab63.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-20 20:26:45 +02:00
Evan Lezar
a819cfdab4 Revert "Merge pull request #703 from elezar/fix-no-persistenced-flag" 
This reverts commit c02b144ed4, reversing
changes made to b061446694.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-20 20:26:33 +02:00
Evan Lezar
629db79b4f [no-relnote] Don't check for submodule changes 
With the move to dependabot to udpate the libnvidia-container
submodule it is no longer required to have checks in place that
ensure that this is up to date when building.

In addition when re-building old commits in CI, for example we explicitly
do NOT want to have this check.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-20 20:20:36 +02:00
Evan Lezar
8693dd6962 [no-relnote] Add CodeQL workflow 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-19 14:36:45 +02:00
dependabot[bot]
51cc619eab
Bump github.com/matryer/moq from 0.3.4 to 0.5.0 in /deployments/devel 
Bumps [github.com/matryer/moq](https://github.com/matryer/moq) from 0.3.4 to 0.5.0.
- [Release notes](https://github.com/matryer/moq/releases)
- [Changelog](https://github.com/matryer/moq/blob/main/.goreleaser.yml)
- [Commits](https://github.com/matryer/moq/compare/v0.3.4...v0.5.0)

---
updated-dependencies:
- dependency-name: github.com/matryer/moq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-18 22:45:12 +00:00
Tariq
9b72161b63
Merge pull request #702 from NVIDIA/sync-gomod2 2024-09-19 06:43:55 +08:00
Evan Lezar
d925b6596b
Merge pull request #687 from NVIDIA/dependabot/docker/deployments/devel/main/golang-1.23.1 
Bump golang from 1.23.0 to 1.23.1 in /deployments/devel
 2024-09-18 23:30:30 +02:00
Evan Lezar
c02b144ed4
Merge pull request #703 from elezar/fix-no-persistenced-flag 
[no-relnote] Move --no-persistenced flag to after configure
 2024-09-18 22:58:43 +02:00
Evan Lezar
16fdef50e6 [no-relnote] Move --no-persistenced flag to after configure 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 22:52:25 +02:00
Christopher Desiniotis
b061446694
Merge pull request #694 from elezar/add-opt-in-to-sockets 
Skip injection of nvidia-persistenced socket by default
 2024-09-18 13:39:28 -07:00
Evan Lezar
9c2476c98d Expose opt-in features in toolkit-container 
This change enables opt-in (off-by-default) features to be opted into.
These features can be toggled by name by specifying the (repeated)
--opt-in-feature command line argument or as a comma-separated list
in the NVIDIA_CONTAINER_TOOLKIT_OPT_IN_FEATURES environment variable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 22:30:27 +02:00
Evan Lezar
70da6cfa50 Allow inclusion of persistenced socket in CDI specification 
This change adds an include-persistenced-socket flag to the
nvidia-ctk cdi generate command that ensures that a generated
specification includes the nvidia-persistenced socket if present on
the host.

Note that for mangement mode, these sockets are always included
if detected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 22:30:27 +02:00
Evan Lezar
a4bfccc3fe Use include-persistenced-socket feature for CDI mode 
This change ensures that the internal CDI representation includes
the persistenced socket if the include-persistenced-socket feature
flag is enabled.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 22:30:27 +02:00
Tariq Ibrahim
66f50d91bd
sync go.mod with go mod tidy in deployments/devel 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
 2024-09-18 13:17:54 -07:00
Evan Lezar
ba1ed3232f Skip injection of nvidia-persistenced socket by default 
This changes skips the injection of the nvidia-persistenced socket by
default.

An include-persistenced-socket feature flag is added to allow the
injection of this socket to be explicitly requested.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 22:10:09 +02:00
Evan Lezar
c490baab63
Merge pull request #696 from elezar/check-link-resolution 
Check for valid paths in create-symlinks hook
 2024-09-18 22:05:14 +02:00
Evan Lezar
32486cf1e9
Merge pull request #701 from NVIDIA/dependabot/submodules/main/third_party/libnvidia-container-921e2f3 
Bump third_party/libnvidia-container from `6b8b8e4` to `921e2f3`
 2024-09-18 22:04:37 +02:00
dependabot[bot]
b9c3185d72
Bump third_party/libnvidia-container from 6b8b8e4 to 921e2f3 
Bumps [third_party/libnvidia-container](https://github.com/NVIDIA/libnvidia-container) from `6b8b8e4` to `921e2f3`.
- [Release notes](https://github.com/NVIDIA/libnvidia-container/releases)
- [Commits](6b8b8e425e...921e2f3197)

---
updated-dependencies:
- dependency-name: third_party/libnvidia-container
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-18 20:00:15 +00:00
Evan Lezar
e383b75a4d Check for valid paths in create-symlinks hook 
This change updates the create-symlinks hook to check whether
link paths resolve in the container's filesystem. In addition
the executable is updated to return an error if a link could
not be created.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-09-18 17:47:19 +02:00
Evan Lezar
5827434cae
Merge pull request #699 from NVIDIA/dependabot/submodules/main/third_party/libnvidia-container-6b8b8e4 
Bump third_party/libnvidia-container from `4c2494f` to `6b8b8e4`
 2024-09-18 16:22:21 +02:00
dependabot[bot]
6ad699c095
Bump third_party/libnvidia-container from 4c2494f to 6b8b8e4 
Bumps [third_party/libnvidia-container](https://github.com/NVIDIA/libnvidia-container) from `4c2494f` to `6b8b8e4`.
- [Release notes](https://github.com/NVIDIA/libnvidia-container/releases)
- [Commits](4c2494f165...6b8b8e425e)

---
updated-dependencies:
- dependency-name: third_party/libnvidia-container
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-18 09:05:59 +00:00
dependabot[bot]
2450b002a8
Bump golang from 1.23.0 to 1.23.1 in /deployments/devel 
Bumps golang from 1.23.0 to 1.23.1.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-09 08:25:21 +00:00
dependabot[bot]
03d1acc7b0
Bump golang.org/x/sys from 0.24.0 to 0.25.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.24.0 to 0.25.0.
- [Commits](https://github.com/golang/sys/compare/v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-08 08:25:45 +00:00
dependabot[bot]
39120d5878
Bump nvidia/cuda in /deployments/container 
Bumps nvidia/cuda from 12.6.0-base-ubuntu20.04 to 12.6.1-base-ubuntu20.04.

---
updated-dependencies:
- dependency-name: nvidia/cuda
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-06 08:44:24 +00:00
Evan Lezar
da5e3ce8c3
Merge pull request #634 from NVIDIA/dependabot/go_modules/main/golang.org/x/mod-0.20.0 
Bump golang.org/x/mod from 0.19.0 to 0.20.0
 2024-09-04 12:41:04 +02:00
dependabot[bot]
b47f954b7c
Bump golang.org/x/mod from 0.19.0 to 0.20.0 
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.19.0 to 0.20.0.
- [Commits](https://github.com/golang/mod/compare/v0.19.0...v0.20.0)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-08-27 07:44:17 +00:00
Evan Lezar
f959c0daaa
Merge pull request #644 from NVIDIA/dependabot/go_modules/main/golang.org/x/sys-0.24.0 
Bump golang.org/x/sys from 0.22.0 to 0.24.0
 2024-08-27 09:43:10 +02:00
Evan Lezar
c3c0cdcc89
Merge pull request #660 from elezar/fix-libnvidia-allocator-duplicate-mount 
Exclude libnvidia-allocator from graphics mounts
 2024-08-22 14:00:25 +02:00
Evan Lezar
e3936fd623
Merge pull request #661 from elezar/fix-golangci-lint 
[no-relnote] Ignore integer overflow in golangci-lint
 2024-08-22 11:43:17 +02:00
Evan Lezar
f4987580d2 [no-relnote] Ignore integer overflow in golangci-lint 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-08-22 11:33:59 +02:00
dependabot[bot]
f3fceab317
Bump golang.org/x/sys from 0.22.0 to 0.24.0 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.22.0 to 0.24.0.
- [Commits](https://github.com/golang/sys/compare/v0.22.0...v0.24.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-08-20 18:29:08 +00:00
Evan Lezar
ff2ba2bbc5
Merge pull request #655 from NVIDIA/dependabot/go_modules/main/github.com/urfave/cli/v2-2.27.4 
Bump github.com/urfave/cli/v2 from 2.27.3 to 2.27.4
 2024-08-20 20:27:53 +02:00
Evan Lezar
0c554cbf7e
Merge pull request #652 from NVIDIA/dependabot/docker/deployments/devel/main/golang-1.23.0 
Bump golang from 1.22.6 to 1.23.0 in /deployments/devel
 2024-08-20 17:18:06 +02:00
Evan Lezar
beb921fafe Exclude libnvidia-allocator from graphics mounts 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-08-20 16:28:14 +02:00
Evan Lezar
45030d1169
Merge pull request #651 from NVIDIA/dependabot/docker/deployments/container/main/nvidia/cuda-12.6.0-base-ubuntu20.04 
Bump nvidia/cuda from 12.5.1-base-ubuntu20.04 to 12.6.0-base-ubuntu20.04 in /deployments/container
 2024-08-19 11:39:46 +02:00
dependabot[bot]
2f37055bc6
Bump golang from 1.22.6 to 1.23.0 in /deployments/devel 
Bumps golang from 1.22.6 to 1.23.0.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-08-19 09:39:15 +00:00
Evan Lezar
5316c2a618
Merge pull request #657 from yeahdongcn/typo 
Rename icp_test.go to ipc_test.go
 2024-08-19 11:38:56 +02:00
dependabot[bot]
89e4ae70c8
Bump github.com/urfave/cli/v2 from 2.27.3 to 2.27.4 
Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.27.3 to 2.27.4.
- [Release notes](https://github.com/urfave/cli/releases)
- [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md)
- [Commits](https://github.com/urfave/cli/compare/v2.27.3...v2.27.4)

---
updated-dependencies:
- dependency-name: github.com/urfave/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-08-19 09:38:51 +00:00
Evan Lezar
c68b4be12f
Merge pull request #658 from elezar/fix-default-value 
Use empty string for default runtime-config-override
 2024-08-19 11:34:36 +02:00
Evan Lezar
89c12c1368 Use empty string for default runtime-config-override 
This change ensures that we unnecessarily print warnings for
runtimes where these configs are not applicable.

This removes the following warnings:
WARN[0000] Ignoring runtime-config-override flag for docker

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2024-08-19 11:33:26 +02:00