UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2024-12-01 16:52:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,050 Commits 20 Branches 73 Tags 29 MiB
release-1.17
Commit Graph

2050 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Lezar
c58d81cec5 Bump version to 1.10.0-rc.3 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-18 13:38:54 +02:00
Evan Lezar
2a3b87157a Merge branch 'prep-release' into 'main' 
Update changelog and libnvidia-container for release

See merge request nvidia/container-toolkit/container-toolkit!152
 2022-05-13 11:52:58 +00:00
Evan Lezar
a68d1d914c Update libnvidia-container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-13 13:52:20 +02:00
Evan Lezar
f7ac8b8139 Update changelog for release 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-13 13:44:43 +02:00
Evan Lezar
b2902cc04a Merge branch 'CNT-2967/add-version-string' into 'main' 
Add --version support for the CLIs

See merge request nvidia/container-toolkit/container-toolkit!151
 2022-05-13 11:02:34 +00:00
Evan Lezar
25710468dc Ensure that git commit is set in docker build 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-13 07:31:11 +02:00
Evan Lezar
4a19bf16a8 Set the version and gitCommit in the Makefile 
This change ensures that the variables used to construct the
version strings for CMDs are set in the makefile.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-13 07:31:11 +02:00
Evan Lezar
c77e86137e Add version output to CLIs 
This change adds version output to the nvidia-continer-runtime,
nvidia-container-toolkit, and nvidia-ctk CLIs. The same version
is used in all cases and includes a version string and a git
revision if set.

The construction of the version string mirrors what is done in runc.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-13 07:31:11 +02:00
Evan Lezar
60dacb76b6 Call logger.Reset() to ensure errors are captured 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 15:42:42 +02:00
Evan Lezar
19138a2110 Skip setting of log file for --version flag 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 14:34:37 +02:00
Evan Lezar
bdb43aa8f2 Merge branch 'CNT-2973/add-has-nvml' into 'main' 
Include HasNVML check in ResolveAutoMode

See merge request nvidia/container-toolkit/container-toolkit!149
 2022-05-12 11:23:47 +00:00
Evan Lezar
d62cce3c75 Merge branch 'CNT-2953/new-options' into 'main' 
Update config options to control OCI Spec modification

See merge request nvidia/container-toolkit/container-toolkit!145
 2022-05-12 11:22:42 +00:00
Evan Lezar
ff86ecb2a5 Include HasNVML check in ResolveAutoMode 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:55:58 +02:00
Evan Lezar
ad9ec1efae Add HasNVML function to check if NVML is supported 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:55:13 +02:00
Evan Lezar
9db5f9c9e8 Remove unneeded legacy discovery 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:53:52 +02:00
Evan Lezar
4c49f75365 Remove --force flag from nvidia-container-runtime-hook 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:53:52 +02:00
Evan Lezar
e591f3f26b Replace experimental and discover-mode 
These changes replace the nvidia-container-runtime config options
experimental and discover-mode with a single mode config option.

Note that mode is now a string with a default value of "auto"
and a mode value of "legacy" is equivalent to experimental == false.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:53:50 +02:00
Evan Lezar
e0ad82e467 Move ResolveAutoMode to info package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:28:56 +02:00
Evan Lezar
3a1404f2f4 Move isTegraSystem to internal info package 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:28:56 +02:00
Evan Lezar
cf7bb91481 Update nvidia-container-runtime config options 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:28:56 +02:00
Evan Lezar
ba0e606df2 Use toml unmarshal to read runtime config 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-12 10:28:56 +02:00
Evan Lezar
ae57a2fc93 Merge branch 'CNT-2875/create-specific-symlinks' into 'main' 
Create specific symlinks for CSV mode

See merge request nvidia/container-toolkit/container-toolkit!150
 2022-05-12 05:27:43 +00:00
Evan Lezar
1eb0e3c8b3 Merge branch 'fix-executable-locator' into 'main' 
Fix location of executables in PATH

See merge request nvidia/container-toolkit/container-toolkit!148
 2022-05-12 05:26:22 +00:00
Evan Lezar
a524c44161 Merge branch 'CNT-2926/runc-logging' into 'main' 
Support runc logging command line options

See merge request nvidia/container-toolkit/container-toolkit!144
 2022-05-12 05:24:25 +00:00
Evan Lezar
675fbace01 Add hook to create specific links 
This change updates the create-symlinks hook to also create symlinks for
libcuda.so, libGLX_indirect.so.0, and libnvidia-opticalflow.so

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-11 16:36:49 +02:00
Evan Lezar
eac326c5ea Add --link option to nvidia-ctk hook create-symlinks command 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-11 15:28:53 +02:00
Evan Lezar
b0f7a3809f Factor linkCreation into method 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-11 15:28:02 +02:00
Evan Lezar
126c004ee0 Improve symlink creation loop 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-11 15:17:15 +02:00
Evan Lezar
d2516cb5d5 Merge branch 'fix-container-root' into 'main' 
Fix bug in update-ldcache hook when OCI spec contains a relative root

See merge request nvidia/container-toolkit/container-toolkit!147
 2022-05-10 22:01:14 +00:00
Evan Lezar
4696d7ee69 Merge branch 'fix-hook-flags' into 'main' 
Use singular instead of plural for hook arguments

See merge request nvidia/container-toolkit/container-toolkit!146
 2022-05-10 22:00:51 +00:00
Evan Lezar
ef6f48e9f7 Use singular instead of plural for hook arguments 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 19:55:31 +02:00
Evan Lezar
088db09180 Use executable locator to find low-level runtime 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 15:21:48 +02:00
Evan Lezar
b8ef6be6ea Use lookup.GetPath from runtime hook 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 14:53:26 +02:00
Evan Lezar
1d2e1bd403 Add lookup.GetPath and lookup.GetPaths functions 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 14:52:47 +02:00
Evan Lezar
55efdc8765 Use state.GetContainerRoot in nvidia-ctk hook subcommands 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 11:48:43 +02:00
Evan Lezar
395f6cecb2 Add GetContainerRoot to oci.State type 
This change adds a GetContainerRoot to the oci.State type to
encapsulate the logic around determining the container root.
This Fixes a bug where relative roots (e.g. as generated by contianerd)
are not supported.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-10 11:48:43 +02:00
Evan Lezar
e9d929dc2f Support runc logging command line options 
This change processes and supports runc logging command line arguments.
This allows for better integration into container engines such as
docker.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-09 19:32:38 +02:00
Evan Lezar
117f68fa6e Merge branch 'CNT-2924/low-level-runtime-config' into 'main' 
Add nvidia-container-runtime.runtimes config option

See merge request nvidia/container-toolkit/container-toolkit!143
 2022-05-09 17:31:02 +00:00
Evan Lezar
7574a0d7de Make output of bundle directory a debug message 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-09 09:38:16 +02:00
Evan Lezar
335de5a352 Switch to debug logging when locating runtimes 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-09 09:38:16 +02:00
Evan Lezar
c76946cbcc Add nvidia-container-runtime.runtimes config option 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-09 09:38:12 +02:00
Evan Lezar
e93bafa6d4 Merge branch 'CNT-2676/nvidia-require' into 'main' 
Add support for checking requirements to CSV discovery

See merge request nvidia/container-toolkit/container-toolkit!141
 2022-05-06 12:52:53 +00:00
Evan Lezar
785f120c31 Fix form -> from in comment 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-06 13:22:34 +02:00
Evan Lezar
9e46d41dbe Add debug logging when checking requirements 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 14:14:01 +02:00
Evan Lezar
70c4588197 Add compute capability of first device as arch property 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 14:11:30 +02:00
Evan Lezar
9f50ac95c4 Add CUDA ComputeCapability function 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 14:09:28 +02:00
Evan Lezar
75ce057878 Add debug log for command line arguments 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 13:47:39 +02:00
Evan Lezar
9d2363e12e Return low-level runtime if subcommand is not create 
This also removes a test that invokes nvidia-container-runtime run --bundle
expecting an error. This test is no longer valid since this command line
is forwared to runc where the error should be detected.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 13:43:13 +02:00
Evan Lezar
49f4bb3198 Check requirements before creating CSV discoverer 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 13:43:13 +02:00
Evan Lezar
583793b7ae Add processing for requirements and constraints 
This change adds a Requirements abstraction that can be used to check
an images' NVIDIA_REQUIRE_* envvars against the host properties such
as CUDA version or architecture.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
 2022-05-05 13:43:13 +02:00