diff --git a/CHANGELOG.md b/CHANGELOG.md index 62155ab6..9fbe06d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ * Include `vulkan/icd.d/nvidia_layers.json` in list of graphics mounts. * Add support for `--library-search-paths` to `nvidia-ctk cdi generate` command. * Add support for injecting /dev/nvidia-nvswitch* devices if the NVIDIA_NVSWITCH=enabled envvar is specified. +* Added support for `nvidia-ctk runtime configure --enable-cdi` for the `docker` runtime. Note that this requires Docker >= 25. * [libnvidia-container] Fix device permission check when using cgroupv2 (fixes #227) diff --git a/cmd/nvidia-ctk/runtime/configure/configure.go b/cmd/nvidia-ctk/runtime/configure/configure.go index 11f37387..145fef0e 100644 --- a/cmd/nvidia-ctk/runtime/configure/configure.go +++ b/cmd/nvidia-ctk/runtime/configure/configure.go @@ -20,13 +20,14 @@ import ( "fmt" "path/filepath" + "github.com/urfave/cli/v2" + "github.com/NVIDIA/nvidia-container-toolkit/internal/logger" "github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine" "github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/containerd" "github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/crio" "github.com/NVIDIA/nvidia-container-toolkit/pkg/config/engine/docker" "github.com/NVIDIA/nvidia-container-toolkit/pkg/config/ocihook" - "github.com/urfave/cli/v2" ) const ( @@ -185,7 +186,7 @@ func (m command) validateFlags(c *cli.Context, config *config) error { } } - if config.runtime != "containerd" { + if config.runtime != "containerd" && config.runtime != "docker" { if config.cdi.enabled { m.logger.Warningf("Ignoring cdi.enabled flag for %v", config.runtime) } @@ -244,10 +245,9 @@ func (m command) configureConfigFile(c *cli.Context, config *config) error { return fmt.Errorf("unable to update config: %v", err) } - if config.cdi.enabled { - if err := cfg.Set("enable_cdi", true); err != nil { - return fmt.Errorf("failed enable CDI in containerd: %w", err) - } + err = enableCDI(config, cfg) + if err != nil { + return fmt.Errorf("failed to enable CDI in %s: %w", config.runtime, err) } outputPath := config.getOuputConfigPath() @@ -300,3 +300,17 @@ func (m *command) configureOCIHook(c *cli.Context, config *config) error { } return nil } + +// enableCDI enables the use of CDI in the corresponding container engine +func enableCDI(config *config, cfg engine.Interface) error { + if !config.cdi.enabled { + return nil + } + switch config.runtime { + case "containerd": + return cfg.Set("enable_cdi", true) + case "docker": + return cfg.Set("experimental", true) + } + return fmt.Errorf("enabling CDI in %s is not supported", config.runtime) +} diff --git a/pkg/config/engine/docker/docker.go b/pkg/config/engine/docker/docker.go index 965dc2e4..a6828528 100644 --- a/pkg/config/engine/docker/docker.go +++ b/pkg/config/engine/docker/docker.go @@ -114,9 +114,10 @@ func (c *Config) RemoveRuntime(name string) error { return nil } -// Set is not supported for docker configs. +// Set sets the specified docker option func (c *Config) Set(key string, value interface{}) error { - return fmt.Errorf("Set is not supported for crio configs") + (*c)[key] = value + return nil } // Save writes the config to the specified path