mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2024-11-25 13:35:00 +00:00
Add support for specifying search paths
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
parent
e5391760e6
commit
f20ab793a2
@ -32,6 +32,17 @@ var _ Locator = (*ldcacheLocator)(nil)
|
|||||||
|
|
||||||
// NewLibraryLocator creates a library locator using the specified options.
|
// NewLibraryLocator creates a library locator using the specified options.
|
||||||
func NewLibraryLocator(opts ...Option) Locator {
|
func NewLibraryLocator(opts ...Option) Locator {
|
||||||
|
b := newBuilder(opts...)
|
||||||
|
|
||||||
|
// If search paths are already specified, we return a locator for the specified search paths.
|
||||||
|
if len(b.searchPaths) > 0 {
|
||||||
|
return NewSymlinkLocator(
|
||||||
|
WithLogger(b.logger),
|
||||||
|
WithSearchPaths(b.searchPaths...),
|
||||||
|
WithRoot("/"),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
opts = append(opts,
|
opts = append(opts,
|
||||||
WithSearchPaths([]string{
|
WithSearchPaths([]string{
|
||||||
"/",
|
"/",
|
||||||
|
@ -66,7 +66,7 @@ func TestLDCacheLocator(t *testing.T) {
|
|||||||
{
|
{
|
||||||
description: "lib only not in LDCache returns error",
|
description: "lib only not in LDCache returns error",
|
||||||
libname: "libnotcuda.so",
|
libname: "libnotcuda.so",
|
||||||
expectedError: errNotFound,
|
expectedError: ErrNotFound,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -127,16 +127,12 @@ func TestLibraryLocator(t *testing.T) {
|
|||||||
require.NoError(t, os.Symlink(libTarget1, source1))
|
require.NoError(t, os.Symlink(libTarget1, source1))
|
||||||
require.NoError(t, os.Symlink(source1, source2))
|
require.NoError(t, os.Symlink(source1, source2))
|
||||||
|
|
||||||
lut := NewLibraryLocator(
|
|
||||||
WithLogger(logger),
|
|
||||||
WithRoot(testDir),
|
|
||||||
)
|
|
||||||
|
|
||||||
testCases := []struct {
|
testCases := []struct {
|
||||||
description string
|
description string
|
||||||
libname string
|
libname string
|
||||||
expected []string
|
librarySearchPaths []string
|
||||||
expectedError error
|
expected []string
|
||||||
|
expectedError error
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
description: "slash in path resoves symlink",
|
description: "slash in path resoves symlink",
|
||||||
@ -156,7 +152,7 @@ func TestLibraryLocator(t *testing.T) {
|
|||||||
{
|
{
|
||||||
description: "library not found returns error",
|
description: "library not found returns error",
|
||||||
libname: "/lib/symlink/libnotcuda.so",
|
libname: "/lib/symlink/libnotcuda.so",
|
||||||
expectedError: errNotFound,
|
expectedError: ErrNotFound,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
description: "slash in path with pattern resoves symlink",
|
description: "slash in path with pattern resoves symlink",
|
||||||
@ -176,10 +172,31 @@ func TestLibraryLocator(t *testing.T) {
|
|||||||
filepath.Join(testDir, "/lib/symlink/libtarget.so.1.2.3"),
|
filepath.Join(testDir, "/lib/symlink/libtarget.so.1.2.3"),
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
description: "search paths are searched",
|
||||||
|
libname: "lib*.so.1.2.3",
|
||||||
|
librarySearchPaths: []string{filepath.Join(testDir, "/lib/symlink")},
|
||||||
|
expected: []string{
|
||||||
|
filepath.Join(testDir, "/lib/symlink/libcuda.so.1.2.3"),
|
||||||
|
filepath.Join(testDir, "/lib/symlink/libtarget.so.1.2.3"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
description: "search paths are absolute to root",
|
||||||
|
libname: "lib*.so.1.2.3",
|
||||||
|
librarySearchPaths: []string{"/lib/symlink"},
|
||||||
|
expectedError: ErrNotFound,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range testCases {
|
for _, tc := range testCases {
|
||||||
t.Run(tc.description, func(t *testing.T) {
|
t.Run(tc.description, func(t *testing.T) {
|
||||||
|
lut := NewLibraryLocator(
|
||||||
|
WithLogger(logger),
|
||||||
|
WithRoot(testDir),
|
||||||
|
WithSearchPaths(tc.librarySearchPaths...),
|
||||||
|
)
|
||||||
|
|
||||||
candidates, err := lut.Locate(tc.libname)
|
candidates, err := lut.Locate(tc.libname)
|
||||||
require.ErrorIs(t, err, tc.expectedError)
|
require.ErrorIs(t, err, tc.expectedError)
|
||||||
|
|
||||||
|
@ -25,4 +25,5 @@ type Locator interface {
|
|||||||
Locate(string) ([]string, error)
|
Locate(string) ([]string, error)
|
||||||
}
|
}
|
||||||
|
|
||||||
var errNotFound = errors.New("not found")
|
// ErrNotFound indicates that a specified pattern or file could not be found.
|
||||||
|
var ErrNotFound = errors.New("not found")
|
||||||
|
Loading…
Reference in New Issue
Block a user