mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-02-16 17:42:20 +00:00
Add support for injecting NVSWITCH devices
This change adds support for an NVIDIA_NVSWITCH environment variable. When set to `enabled` this striggers the injection of all available /dev/nvidia-nvswitch* device nodes. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
parent
3045954cd9
commit
efae501834
@ -5,6 +5,7 @@
|
|||||||
* Include `nvidia/nvoptix.bin` in list of graphics mounts.
|
* Include `nvidia/nvoptix.bin` in list of graphics mounts.
|
||||||
* Include `vulkan/icd.d/nvidia_layers.json` in list of graphics mounts.
|
* Include `vulkan/icd.d/nvidia_layers.json` in list of graphics mounts.
|
||||||
* Add support for `--library-search-paths` to `nvidia-ctk cdi generate` command.
|
* Add support for `--library-search-paths` to `nvidia-ctk cdi generate` command.
|
||||||
|
* Add support for injecting /dev/nvidia-nvswitch* devices if the NVIDIA_NVSWITCH=enabled envvar is specified.
|
||||||
|
|
||||||
* [libnvidia-container] Fix device permission check when using cgroupv2 (fixes #227)
|
* [libnvidia-container] Fix device permission check when using cgroupv2 (fixes #227)
|
||||||
|
|
||||||
|
33
internal/discover/nvswitch.go
Normal file
33
internal/discover/nvswitch.go
Normal file
@ -0,0 +1,33 @@
|
|||||||
|
/**
|
||||||
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
**/
|
||||||
|
|
||||||
|
package discover
|
||||||
|
|
||||||
|
import "github.com/NVIDIA/nvidia-container-toolkit/internal/logger"
|
||||||
|
|
||||||
|
// NewNvSwitchDiscoverer creates a discoverer for NVSWITCH devices.
|
||||||
|
func NewNvSwitchDiscoverer(logger logger.Interface, devRoot string) (Discover, error) {
|
||||||
|
devices := NewCharDeviceDiscoverer(
|
||||||
|
logger,
|
||||||
|
devRoot,
|
||||||
|
[]string{
|
||||||
|
"/dev/nvidia-nvswitchctl",
|
||||||
|
"/dev/nvidia-nvswitch*",
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
return devices, nil
|
||||||
|
}
|
@ -27,8 +27,9 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
const (
|
const (
|
||||||
nvidiaGDSEnvvar = "NVIDIA_GDS"
|
nvidiaGDSEnvvar = "NVIDIA_GDS"
|
||||||
nvidiaMOFEDEnvvar = "NVIDIA_MOFED"
|
nvidiaMOFEDEnvvar = "NVIDIA_MOFED"
|
||||||
|
nvidiaNVSWITCHEnvvar = "NVIDIA_NVSWITCH"
|
||||||
)
|
)
|
||||||
|
|
||||||
// NewFeatureGatedModifier creates the modifiers for optional features.
|
// NewFeatureGatedModifier creates the modifiers for optional features.
|
||||||
@ -36,6 +37,7 @@ const (
|
|||||||
//
|
//
|
||||||
// NVIDIA_GDS=enabled
|
// NVIDIA_GDS=enabled
|
||||||
// NVIDIA_MOFED=enabled
|
// NVIDIA_MOFED=enabled
|
||||||
|
// NVIDIA_NVSWITCH=enabled
|
||||||
//
|
//
|
||||||
// If not devices are selected, no changes are made.
|
// If not devices are selected, no changes are made.
|
||||||
func NewFeatureGatedModifier(logger logger.Interface, cfg *config.Config, image image.CUDA) (oci.SpecModifier, error) {
|
func NewFeatureGatedModifier(logger logger.Interface, cfg *config.Config, image image.CUDA) (oci.SpecModifier, error) {
|
||||||
@ -65,5 +67,13 @@ func NewFeatureGatedModifier(logger logger.Interface, cfg *config.Config, image
|
|||||||
discoverers = append(discoverers, d)
|
discoverers = append(discoverers, d)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if image.Getenv(nvidiaNVSWITCHEnvvar) == "enabled" {
|
||||||
|
d, err := discover.NewNvSwitchDiscoverer(logger, devRoot)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("failed to construct discoverer for NVSWITCH devices: %w", err)
|
||||||
|
}
|
||||||
|
discoverers = append(discoverers, d)
|
||||||
|
}
|
||||||
|
|
||||||
return NewModifierFromDiscoverer(logger, discover.Merge(discoverers...))
|
return NewModifierFromDiscoverer(logger, discover.Merge(discoverers...))
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user