UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2025-04-06 13:35:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #969 from elezar/allow-comma-separated-config-values
Some checks are pending
CI Pipeline / code-scanning (push) Waiting to run
Details
CI Pipeline / variables (push) Waiting to run
Details
CI Pipeline / golang (push) Waiting to run
Details
CI Pipeline / image (push) Blocked by required conditions
Details
CI Pipeline / e2e-test (push) Blocked by required conditions
Details

Browse Source 
Allow nvidia-ctk config --set to accept comma-separated lists
This commit is contained in:
Evan Lezar 2025-03-12 16:21:52 +02:00 committed by GitHub
commit e4547bdda6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/nvidia-ctk/config/config.go
View File

@ -194,7 +194,14 @@ func setFlagToKeyValue(setFlag string, setListSeparator string) (string, interfa
case reflect.String: case reflect.String:
return key, value, nil return key, value, nil
case reflect.Slice: case reflect.Slice:
valueParts := strings.Split(value, setListSeparator) valueParts := []string{value}
for _, sep := range []string{setListSeparator, ","} {
if !strings.Contains(value, sep) {
continue
}
valueParts = strings.Split(value, sep)
break
}
switch field.Elem().Kind() { switch field.Elem().Kind() {
case reflect.String: case reflect.String:
return key, valueParts, nil return key, valueParts, nil

1
cmd/nvidia-ctk/main.go
View File

@ -49,6 +49,7 @@ func main() {
// Create the top-level CLI // Create the top-level CLI
c := cli.NewApp() c := cli.NewApp()
c.DisableSliceFlagSeparator = true
c.Name = "NVIDIA Container Toolkit CLI" c.Name = "NVIDIA Container Toolkit CLI"
c.UseShortOptionHandling = true c.UseShortOptionHandling = true
c.EnableBashCompletion = true c.EnableBashCompletion = true