mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-06-26 18:18:24 +00:00
Read top-level config to propagate Root to experimental runtime
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
@@ -36,14 +36,13 @@ type experimental struct {
|
||||
|
||||
// NewExperimentalModifier creates a modifier that applied the experimental
|
||||
// modications to an OCI spec if required by the runtime wrapper.
|
||||
func NewExperimentalModifier(logger *logrus.Logger, cfg *config.RuntimeConfig) (oci.SpecModifier, error) {
|
||||
func NewExperimentalModifier(logger *logrus.Logger, cfg *config.Config) (oci.SpecModifier, error) {
|
||||
logger.Infof("Constructing modifier from config: %+v", cfg)
|
||||
|
||||
// TODO: We need to specify the root
|
||||
root := ""
|
||||
root := cfg.NVIDIAContainerCLIConfig.Root
|
||||
|
||||
var d discover.Discover
|
||||
switch cfg.DiscoverMode {
|
||||
switch cfg.NVIDIAContainerRuntimeConfig.DiscoverMode {
|
||||
case "legacy":
|
||||
legacyDiscoverer, err := discover.NewLegacyDiscoverer(logger, root)
|
||||
if err != nil {
|
||||
@@ -51,7 +50,7 @@ func NewExperimentalModifier(logger *logrus.Logger, cfg *config.RuntimeConfig) (
|
||||
}
|
||||
d = legacyDiscoverer
|
||||
default:
|
||||
return nil, fmt.Errorf("invalid discover mode: %v", cfg.DiscoverMode)
|
||||
return nil, fmt.Errorf("invalid discover mode: %v", cfg.NVIDIAContainerRuntimeConfig.DiscoverMode)
|
||||
}
|
||||
|
||||
return newExperimentalModifierFromDiscoverer(logger, d)
|
||||
|
||||
@@ -32,25 +32,31 @@ func TestConstructor(t *testing.T) {
|
||||
|
||||
testCases := []struct {
|
||||
description string
|
||||
cfg *config.RuntimeConfig
|
||||
cfg *config.Config
|
||||
expectedError error
|
||||
}{
|
||||
{
|
||||
description: "empty config raises error",
|
||||
cfg: &config.RuntimeConfig{},
|
||||
description: "empty config raises error",
|
||||
cfg: &config.Config{
|
||||
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{},
|
||||
},
|
||||
expectedError: fmt.Errorf("invalid discover mode"),
|
||||
},
|
||||
{
|
||||
description: "non-legacy discover mode raises error",
|
||||
cfg: &config.RuntimeConfig{
|
||||
DiscoverMode: "non-legacy",
|
||||
cfg: &config.Config{
|
||||
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
||||
DiscoverMode: "non-legacy",
|
||||
},
|
||||
},
|
||||
expectedError: fmt.Errorf("invalid discover mode"),
|
||||
},
|
||||
{
|
||||
description: "legacy discover mode returns modifier",
|
||||
cfg: &config.RuntimeConfig{
|
||||
DiscoverMode: "legacy",
|
||||
cfg: &config.Config{
|
||||
NVIDIAContainerRuntimeConfig: config.RuntimeConfig{
|
||||
DiscoverMode: "legacy",
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user