UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2025-04-20 22:25:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[no-relnote] Fix QF1008: could remove embedded field lint errors

Browse Source 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
Evan Lezar 2025-04-02 14:10:33 +02:00
parent bee1969bbf
commit c1c6534b1f
No known key found for this signature in database
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/discover/symlinks.go
View File

@ -42,7 +42,7 @@ func WithDriverDotSoSymlinks(mounts Discover, version string, nvidiaCDIHookPath
// Hooks returns a hook to create the additional symlinks based on the mounts. // Hooks returns a hook to create the additional symlinks based on the mounts.
func (d *additionalSymlinks) Hooks() ([]Hook, error) { func (d *additionalSymlinks) Hooks() ([]Hook, error) {
mounts, err := d.Discover.Mounts() mounts, err := d.Mounts()
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to get library mounts: %v", err) return nil, fmt.Errorf("failed to get library mounts: %v", err)
} }

4
internal/oci/spec_memory.go
View File

@ -61,11 +61,11 @@ func (s *memorySpec) Modify(m SpecModifier) error {
// Otherwise the returned value will be empty and the boolean will // Otherwise the returned value will be empty and the boolean will
// be false. // be false.
func (s memorySpec) LookupEnv(key string) (string, bool) { func (s memorySpec) LookupEnv(key string) (string, bool) {
if s.Spec == nil || s.Spec.Process == nil { if s.Spec == nil || s.Process == nil {
return "", false return "", false
} }
for _, env := range s.Spec.Process.Env { for _, env := range s.Process.Env {
if !strings.HasPrefix(env, key) { if !strings.HasPrefix(env, key) {
continue continue
} }

2
internal/oci/spec_memory_test.go
View File

@ -160,7 +160,7 @@ func TestModify(t *testing.T) {
require.EqualValues(t, &specs.Spec{}, spec.Spec, "%d: %v", i, tc) require.EqualValues(t, &specs.Spec{}, spec.Spec, "%d: %v", i, tc)
default: default:
require.NoError(t, err, "%d: %v", i, tc) require.NoError(t, err, "%d: %v", i, tc)
require.Equal(t, "updated", spec.Spec.Version, "%d: %v", i, tc) require.Equal(t, "updated", spec.Version, "%d: %v", i, tc)
} }
} }
} }