From 82ccae23b1d0ddb3ae0e6a0e56383c1120bdb4ed Mon Sep 17 00:00:00 2001 From: Carlos Eduardo Arango Gutierrez Date: Thu, 6 Feb 2025 10:41:28 +0100 Subject: [PATCH 1/2] [no-relnote] fix step holodeck_public_dns_name variable name E2E Signed-off-by: Carlos Eduardo Arango Gutierrez --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index 5740ec7a..fdfe9bf7 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -65,13 +65,13 @@ jobs: VERSION: ${COMMIT_SHORT_SHA} SSH_KEY: ${{ secrets.AWS_SSH_KEY }} E2E_SSH_USER: ${{ secrets.E2E_SSH_USER }} + E2E_SSH_HOST: ${{ steps.holodeck_public_dns_name.outputs.result }} E2E_INSTALL_CTK: "true" run: | e2e_ssh_key=$(mktemp) echo "$SSH_KEY" > "$e2e_ssh_key" chmod 600 "$e2e_ssh_key" export E2E_SSH_KEY="$e2e_ssh_key" - export E2E_SSH_HOST="${{ steps.get_public_dns_name.outputs.result }}" make -f tests/e2e/Makefile test From adbe127afd09ccf240b091d27b0701efc910a071 Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Thu, 6 Feb 2025 12:02:49 +0100 Subject: [PATCH 2/2] [no-relnote] Remove on push trigger Signed-off-by: Evan Lezar --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index fdfe9bf7..1c4de830 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -27,7 +27,7 @@ on: jobs: e2e-tests: runs-on: linux-amd64-cpu4 - if: ${{ github.event.workflow_run.conclusion == 'success' }} && ${{ github.event.workflow_run.event == 'push' }} + if: ${{ github.event.workflow_run.conclusion == 'success' }} steps: - name: Check out code uses: actions/checkout@v4