diff --git a/cmd/nvidia-ctk/cdi/generate/driver.go b/cmd/nvidia-ctk/cdi/generate/driver.go index 97f1506a..8a6af8de 100644 --- a/cmd/nvidia-ctk/cdi/generate/driver.go +++ b/cmd/nvidia-ctk/cdi/generate/driver.go @@ -41,12 +41,18 @@ func NewDriverDiscoverer(logger *logrus.Logger, driverRoot string, nvidiaCTKPath return nil, fmt.Errorf("failed to create discoverer for driver libraries: %v", err) } + ipcs, err := discover.NewIPCDiscoverer(logger, driverRoot) + if err != nil { + return nil, fmt.Errorf("failed to create discoverer for IPC sockets: %v", err) + } + firmwares := NewDriverFirmwareDiscoverer(logger, driverRoot, version) binaries := NewDriverBinariesDiscoverer(logger, driverRoot) d := discover.Merge( libraries, + ipcs, firmwares, binaries, ) diff --git a/cmd/nvidia-ctk/cdi/generate/generate.go b/cmd/nvidia-ctk/cdi/generate/generate.go index 213286fa..c46eb147 100644 --- a/cmd/nvidia-ctk/cdi/generate/generate.go +++ b/cmd/nvidia-ctk/cdi/generate/generate.go @@ -232,19 +232,6 @@ func (m command) generateSpec(driverRoot string, nvidiaCTKPath string, namer dev deviceSpecs = append(deviceSpecs, allDevice) - allEdits := edits.NewContainerEdits() - - ipcs, err := discover.NewIPCDiscoverer(m.logger, driverRoot) - if err != nil { - return nil, fmt.Errorf("failed to create discoverer for IPC sockets: %v", err) - } - - ipcEdits, err := edits.FromDiscoverer(ipcs) - if err != nil { - return nil, fmt.Errorf("failed to create container edits for IPC sockets: %v", err) - } - allEdits.Append(ipcEdits) - common, err := NewCommonDiscoverer(m.logger, driverRoot, nvidiaCTKPath, nvmllib) if err != nil { return nil, fmt.Errorf("failed to create discoverer for common entities: %v", err) @@ -260,14 +247,12 @@ func (m command) generateSpec(driverRoot string, nvidiaCTKPath string, namer dev return nil, fmt.Errorf("failed to create container edits for common entities: %v", err) } - allEdits.Append(commonEdits) - // We construct the spec and determine the minimum required version based on the specification. spec := specs.Spec{ Version: "NOT_SET", Kind: "nvidia.com/gpu", Devices: deviceSpecs, - ContainerEdits: *allEdits.ContainerEdits, + ContainerEdits: *commonEdits.ContainerEdits, } minVersion, err := cdi.MinimumRequiredVersion(&spec)