Merge pull request #945 from elezar/disable-nvsandboxutils

Disable nvsandboxutils in nvcdi API
This commit is contained in:
Evan Lezar 2025-02-28 17:10:56 +02:00 committed by GitHub
commit 91a983a341
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -111,19 +111,24 @@ func New(opts ...Option) (Interface, error) {
} }
l.nvmllib = nvml.New(nvmlOpts...) l.nvmllib = nvml.New(nvmlOpts...)
} }
if l.nvsandboxutilslib == nil { // TODO: Repeated calls to nvsandboxutils.Init and Shutdown are causing
var nvsandboxutilsOpts []nvsandboxutils.LibraryOption // segmentation violations. Here we disabled nvsandbox utils unless explicitly
// Set the library path for libnvidia-sandboxutils // specified.
candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1") // This will be reenabled as soon as we have more visibility into why this is
if err != nil { // happening and a mechanism to detect and disable this if required.
l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err) // if l.nvsandboxutilslib == nil {
} else { // var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
libNvidiaSandboxutilsPath := candidates[0] // // Set the library path for libnvidia-sandboxutils
l.logger.Infof("Using %v", libNvidiaSandboxutilsPath) // candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath)) // if err != nil {
} // l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...) // } else {
} // libNvidiaSandboxutilsPath := candidates[0]
// l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
// nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
// }
// l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
// }
if l.devicelib == nil { if l.devicelib == nil {
l.devicelib = device.New(l.nvmllib) l.devicelib = device.New(l.nvmllib)
} }