diff --git a/Makefile b/Makefile index 3afbd9c6..922e4445 100644 --- a/Makefile +++ b/Makefile @@ -100,31 +100,12 @@ coverage: test generate: go generate $(MODULE)/... -# Generate an image for containerized builds -# Note: This image is local only -.PHONY: .build-image .pull-build-image .push-build-image -.build-image: docker/Dockerfile.devel - if [ x"$(SKIP_IMAGE_BUILD)" = x"" ]; then \ - $(DOCKER) build \ - --progress=plain \ - --build-arg GOLANG_VERSION="$(GOLANG_VERSION)" \ - --tag $(BUILDIMAGE) \ - -f $(^) \ - docker; \ - fi - -.pull-build-image: - $(DOCKER) pull $(BUILDIMAGE) - -.push-build-image: - $(DOCKER) push $(BUILDIMAGE) - -$(DOCKER_TARGETS): docker-%: .build-image - @echo "Running 'make $(*)' in docker container $(BUILDIMAGE)" +$(DOCKER_TARGETS): docker-%: + @echo "Running 'make $(*)' in container image $(BUILDIMAGE)" $(DOCKER) run \ --rm \ - -e GOCACHE=/tmp/.cache \ - -e GOLANGCI_LINT_CACHE=/tmp/.cache \ + -e GOCACHE=/tmp/.cache/go \ + -e GOMODCACHE=/tmp/.cache/gomod \ -v $(PWD):/work \ -w /work \ --user $$(id -u):$$(id -g) \ @@ -137,8 +118,8 @@ PHONY: .shell $(DOCKER) run \ --rm \ -ti \ - -e GOCACHE=/tmp/.cache \ - -e GOLANGCI_LINT_CACHE=/tmp/.cache \ + -e GOCACHE=/tmp/.cache/go \ + -e GOMODCACHE=/tmp/.cache/gomod \ -v $(PWD):/work \ -w /work \ --user $$(id -u):$$(id -g) \ diff --git a/versions.mk b/versions.mk index 65e2af5a..3b2fae45 100644 --- a/versions.mk +++ b/versions.mk @@ -33,6 +33,9 @@ LIBNVIDIA_CONTAINER0_VERSION := 0.10.0+jetpack CUDA_VERSION := 12.3.1 GOLANG_VERSION := 1.20.5 +BUILDIMAGE_TAG ?= devel-go$(GOLANG_VERSION) +BUILDIMAGE ?= ghcr.io/nvidia/k8s-test-infra:$(BUILDIMAGE_TAG) + GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always --abbrev=40 2> /dev/null || echo "") GIT_COMMIT_SHORT ?= $(shell git rev-parse --short HEAD 2> /dev/null || echo "") GIT_BRANCH ?= $(shell git rev-parse --abbrev-ref HEAD 2> /dev/null || echo "${GIT_COMMIT}")