UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2025-06-26 18:18:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bug in update-ldcache hook

Browse Source 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
Evan Lezar 2024-01-29 15:11:09 +01:00
parent 73cd63e4e5
commit 862f071557
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/nvidia-ctk/hook/update-ldcache/update-ldcache.go
View File

@ -17,6 +17,7 @@
package ldcache package ldcache
import ( import (
"errors"
"fmt" "fmt"
"os" "os"
"path/filepath" "path/filepath"
@ -56,6 +57,9 @@ func (m command) build() *cli.Command {
c := cli.Command{ c := cli.Command{
Name: "update-ldcache", Name: "update-ldcache",
Usage: "Update ldcache in a container by running ldconfig", Usage: "Update ldcache in a container by running ldconfig",
Before: func(c *cli.Context) error {
return m.validateFlags(c, &cfg)
},
Action: func(c *cli.Context) error { Action: func(c *cli.Context) error {
return m.run(c, &cfg) return m.run(c, &cfg)
}, },
@ -71,7 +75,7 @@ func (m command) build() *cli.Command {
Name: "ldconfig-path", Name: "ldconfig-path",
Usage: "Specify the path to the ldconfig program", Usage: "Specify the path to the ldconfig program",
Destination: &cfg.ldconfigPath, Destination: &cfg.ldconfigPath,
DefaultText: "/sbin/ldconfig", Value: "/sbin/ldconfig",
}, },
&cli.StringFlag{ &cli.StringFlag{
Name: "container-spec", Name: "container-spec",
@ -83,6 +87,13 @@ func (m command) build() *cli.Command {
return &c return &c
} }
func (m command) validateFlags(c *cli.Context, cfg *options) error {
if cfg.ldconfigPath == "" {
return errors.New("ldconfig-path must be specified")
}
return nil
}
func (m command) run(c *cli.Context, cfg *options) error { func (m command) run(c *cli.Context, cfg *options) error {
s, err := oci.LoadContainerState(cfg.containerSpec) s, err := oci.LoadContainerState(cfg.containerSpec)
if err != nil { if err != nil {