mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-04-09 23:14:06 +00:00
Add nvidia-ctk config section
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
parent
1c892af215
commit
740bd3fb9d
@ -38,6 +38,7 @@ var (
|
|||||||
// Note: This is currently duplicated by the HookConfig in cmd/nvidia-container-toolkit/hook_config.go
|
// Note: This is currently duplicated by the HookConfig in cmd/nvidia-container-toolkit/hook_config.go
|
||||||
type Config struct {
|
type Config struct {
|
||||||
NVIDIAContainerCLIConfig ContainerCLIConfig `toml:"nvidia-container-cli"`
|
NVIDIAContainerCLIConfig ContainerCLIConfig `toml:"nvidia-container-cli"`
|
||||||
|
NVIDIACTKConfig CTKConfig `toml:"nvidia-ctk"`
|
||||||
NVIDIAContainerRuntimeConfig RuntimeConfig `toml:"nvidia-container-runtime"`
|
NVIDIAContainerRuntimeConfig RuntimeConfig `toml:"nvidia-container-runtime"`
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -83,6 +84,7 @@ func getConfigFrom(toml *toml.Tree) *Config {
|
|||||||
}
|
}
|
||||||
|
|
||||||
cfg.NVIDIAContainerCLIConfig = *getContainerCLIConfigFrom(toml)
|
cfg.NVIDIAContainerCLIConfig = *getContainerCLIConfigFrom(toml)
|
||||||
|
cfg.NVIDIACTKConfig = *getCTKConfigFrom(toml)
|
||||||
cfg.NVIDIAContainerRuntimeConfig = *getRuntimeConfigFrom(toml)
|
cfg.NVIDIAContainerRuntimeConfig = *getRuntimeConfigFrom(toml)
|
||||||
|
|
||||||
return cfg
|
return cfg
|
||||||
@ -92,6 +94,7 @@ func getConfigFrom(toml *toml.Tree) *Config {
|
|||||||
func getDefaultConfig() *Config {
|
func getDefaultConfig() *Config {
|
||||||
c := Config{
|
c := Config{
|
||||||
NVIDIAContainerCLIConfig: *getDefaultContainerCLIConfig(),
|
NVIDIAContainerCLIConfig: *getDefaultContainerCLIConfig(),
|
||||||
|
NVIDIACTKConfig: *getDefaultCTKConfig(),
|
||||||
NVIDIAContainerRuntimeConfig: *getDefaultRuntimeConfig(),
|
NVIDIAContainerRuntimeConfig: *getDefaultRuntimeConfig(),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -65,43 +65,58 @@ func TestGetConfig(t *testing.T) {
|
|||||||
Experimental: false,
|
Experimental: false,
|
||||||
DiscoverMode: "auto",
|
DiscoverMode: "auto",
|
||||||
},
|
},
|
||||||
|
NVIDIACTKConfig: CTKConfig{
|
||||||
|
Path: "nvidia-ctk",
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
description: "config options set inline",
|
description: "config options set inline",
|
||||||
contents: []string{
|
contents: []string{
|
||||||
|
"nvidia-container-cli.root = \"/bar/baz\"",
|
||||||
"nvidia-container-runtime.debug = \"/foo/bar\"",
|
"nvidia-container-runtime.debug = \"/foo/bar\"",
|
||||||
"nvidia-container-runtime.experimental = true",
|
"nvidia-container-runtime.experimental = true",
|
||||||
"nvidia-container-runtime.discover-mode = \"not-legacy\"",
|
"nvidia-container-runtime.discover-mode = \"not-legacy\"",
|
||||||
|
"nvidia-ctk.path = \"/foo/bar/nvidia-ctk\"",
|
||||||
},
|
},
|
||||||
expectedConfig: &Config{
|
expectedConfig: &Config{
|
||||||
NVIDIAContainerCLIConfig: ContainerCLIConfig{
|
NVIDIAContainerCLIConfig: ContainerCLIConfig{
|
||||||
Root: "",
|
Root: "/bar/baz",
|
||||||
},
|
},
|
||||||
NVIDIAContainerRuntimeConfig: RuntimeConfig{
|
NVIDIAContainerRuntimeConfig: RuntimeConfig{
|
||||||
DebugFilePath: "/foo/bar",
|
DebugFilePath: "/foo/bar",
|
||||||
Experimental: true,
|
Experimental: true,
|
||||||
DiscoverMode: "not-legacy",
|
DiscoverMode: "not-legacy",
|
||||||
},
|
},
|
||||||
|
NVIDIACTKConfig: CTKConfig{
|
||||||
|
Path: "/foo/bar/nvidia-ctk",
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
description: "config options set in section",
|
description: "config options set in section",
|
||||||
contents: []string{
|
contents: []string{
|
||||||
|
"[nvidia-container-cli]",
|
||||||
|
"root = \"/bar/baz\"",
|
||||||
"[nvidia-container-runtime]",
|
"[nvidia-container-runtime]",
|
||||||
"debug = \"/foo/bar\"",
|
"debug = \"/foo/bar\"",
|
||||||
"experimental = true",
|
"experimental = true",
|
||||||
"discover-mode = \"not-legacy\"",
|
"discover-mode = \"not-legacy\"",
|
||||||
|
"[nvidia-ctk]",
|
||||||
|
"path = \"/foo/bar/nvidia-ctk\"",
|
||||||
},
|
},
|
||||||
expectedConfig: &Config{
|
expectedConfig: &Config{
|
||||||
NVIDIAContainerCLIConfig: ContainerCLIConfig{
|
NVIDIAContainerCLIConfig: ContainerCLIConfig{
|
||||||
Root: "",
|
Root: "/bar/baz",
|
||||||
},
|
},
|
||||||
NVIDIAContainerRuntimeConfig: RuntimeConfig{
|
NVIDIAContainerRuntimeConfig: RuntimeConfig{
|
||||||
DebugFilePath: "/foo/bar",
|
DebugFilePath: "/foo/bar",
|
||||||
Experimental: true,
|
Experimental: true,
|
||||||
DiscoverMode: "not-legacy",
|
DiscoverMode: "not-legacy",
|
||||||
},
|
},
|
||||||
|
NVIDIACTKConfig: CTKConfig{
|
||||||
|
Path: "/foo/bar/nvidia-ctk",
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
}
|
46
internal/config/toolkit-cli.go
Normal file
46
internal/config/toolkit-cli.go
Normal file
@ -0,0 +1,46 @@
|
|||||||
|
/**
|
||||||
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
**/
|
||||||
|
|
||||||
|
package config
|
||||||
|
|
||||||
|
import "github.com/pelletier/go-toml"
|
||||||
|
|
||||||
|
// CTKConfig stores the config options for the NVIDIA Container Toolkit CLI (nvidia-ctk)
|
||||||
|
type CTKConfig struct {
|
||||||
|
Path string `toml:"path"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// getCTKConfigFrom reads the nvidia container runtime config from the specified toml Tree.
|
||||||
|
func getCTKConfigFrom(toml *toml.Tree) *CTKConfig {
|
||||||
|
cfg := getDefaultCTKConfig()
|
||||||
|
|
||||||
|
if toml == nil {
|
||||||
|
return cfg
|
||||||
|
}
|
||||||
|
|
||||||
|
cfg.Path = toml.GetDefault("nvidia-ctk.path", cfg.Path).(string)
|
||||||
|
|
||||||
|
return cfg
|
||||||
|
}
|
||||||
|
|
||||||
|
// getDefaultCTKConfig defines the default values for the config
|
||||||
|
func getDefaultCTKConfig() *CTKConfig {
|
||||||
|
c := CTKConfig{
|
||||||
|
Path: "nvidia-ctk",
|
||||||
|
}
|
||||||
|
|
||||||
|
return &c
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user