mirror of
https://github.com/NVIDIA/nvidia-container-toolkit
synced 2025-04-16 05:21:24 +00:00
[no-relnote] Move nvcdi wrapper to separate file
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
parent
5d9b27f107
commit
6e413d8445
@ -22,26 +22,14 @@ import (
|
|||||||
"github.com/NVIDIA/go-nvlib/pkg/nvlib/device"
|
"github.com/NVIDIA/go-nvlib/pkg/nvlib/device"
|
||||||
"github.com/NVIDIA/go-nvlib/pkg/nvlib/info"
|
"github.com/NVIDIA/go-nvlib/pkg/nvlib/info"
|
||||||
"github.com/NVIDIA/go-nvml/pkg/nvml"
|
"github.com/NVIDIA/go-nvml/pkg/nvml"
|
||||||
"tags.cncf.io/container-device-interface/pkg/cdi"
|
|
||||||
|
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/internal/logger"
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/logger"
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/root"
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/root"
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/internal/nvsandboxutils"
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/nvsandboxutils"
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/internal/platform-support/tegra/csv"
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/platform-support/tegra/csv"
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/spec"
|
|
||||||
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform"
|
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform"
|
||||||
)
|
)
|
||||||
|
|
||||||
type wrapper struct {
|
|
||||||
Interface
|
|
||||||
|
|
||||||
vendor string
|
|
||||||
class string
|
|
||||||
|
|
||||||
mergedDeviceOptions []transform.MergedDeviceOption
|
|
||||||
}
|
|
||||||
|
|
||||||
type nvcdilib struct {
|
type nvcdilib struct {
|
||||||
logger logger.Interface
|
logger logger.Interface
|
||||||
nvmllib nvml.Interface
|
nvmllib nvml.Interface
|
||||||
@ -180,38 +168,6 @@ func New(opts ...Option) (Interface, error) {
|
|||||||
return &w, nil
|
return &w, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetSpec combines the device specs and common edits from the wrapped Interface to a single spec.Interface.
|
|
||||||
func (l *wrapper) GetSpec() (spec.Interface, error) {
|
|
||||||
deviceSpecs, err := l.GetAllDeviceSpecs()
|
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
|
||||||
}
|
|
||||||
|
|
||||||
edits, err := l.GetCommonEdits()
|
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
|
||||||
}
|
|
||||||
|
|
||||||
return spec.New(
|
|
||||||
spec.WithDeviceSpecs(deviceSpecs),
|
|
||||||
spec.WithEdits(*edits.ContainerEdits),
|
|
||||||
spec.WithVendor(l.vendor),
|
|
||||||
spec.WithClass(l.class),
|
|
||||||
spec.WithMergedDeviceOptions(l.mergedDeviceOptions...),
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
// GetCommonEdits returns the wrapped edits and adds additional edits on top.
|
|
||||||
func (m *wrapper) GetCommonEdits() (*cdi.ContainerEdits, error) {
|
|
||||||
edits, err := m.Interface.GetCommonEdits()
|
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
|
||||||
}
|
|
||||||
edits.Env = append(edits.Env, image.EnvVarNvidiaVisibleDevices+"=void")
|
|
||||||
|
|
||||||
return edits, nil
|
|
||||||
}
|
|
||||||
|
|
||||||
// getCudaVersion returns the CUDA version of the current system.
|
// getCudaVersion returns the CUDA version of the current system.
|
||||||
func (l *nvcdilib) getCudaVersion() (string, error) {
|
func (l *nvcdilib) getCudaVersion() (string, error) {
|
||||||
version, err := l.getCudaVersionNvsandboxutils()
|
version, err := l.getCudaVersionNvsandboxutils()
|
||||||
|
72
pkg/nvcdi/wrapper.go
Normal file
72
pkg/nvcdi/wrapper.go
Normal file
@ -0,0 +1,72 @@
|
|||||||
|
/**
|
||||||
|
# Copyright 2025 NVIDIA CORPORATION
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
**/
|
||||||
|
|
||||||
|
package nvcdi
|
||||||
|
|
||||||
|
import (
|
||||||
|
"tags.cncf.io/container-device-interface/pkg/cdi"
|
||||||
|
"tags.cncf.io/container-device-interface/specs-go"
|
||||||
|
|
||||||
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
||||||
|
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/spec"
|
||||||
|
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/transform"
|
||||||
|
)
|
||||||
|
|
||||||
|
type wrapper struct {
|
||||||
|
Interface
|
||||||
|
|
||||||
|
vendor string
|
||||||
|
class string
|
||||||
|
|
||||||
|
mergedDeviceOptions []transform.MergedDeviceOption
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetSpec combines the device specs and common edits from the wrapped Interface to a single spec.Interface.
|
||||||
|
func (l *wrapper) GetSpec() (spec.Interface, error) {
|
||||||
|
deviceSpecs, err := l.GetAllDeviceSpecs()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
edits, err := l.GetCommonEdits()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
return spec.New(
|
||||||
|
spec.WithDeviceSpecs(deviceSpecs),
|
||||||
|
spec.WithEdits(*edits.ContainerEdits),
|
||||||
|
spec.WithVendor(l.vendor),
|
||||||
|
spec.WithClass(l.class),
|
||||||
|
spec.WithMergedDeviceOptions(l.mergedDeviceOptions...),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetAllDeviceSpecs returns the device specs for all available devices.
|
||||||
|
func (l *wrapper) GetAllDeviceSpecs() ([]specs.Device, error) {
|
||||||
|
return l.Interface.GetAllDeviceSpecs()
|
||||||
|
}
|
||||||
|
|
||||||
|
// GetCommonEdits returns the wrapped edits and adds additional edits on top.
|
||||||
|
func (m *wrapper) GetCommonEdits() (*cdi.ContainerEdits, error) {
|
||||||
|
edits, err := m.Interface.GetCommonEdits()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
edits.Env = append(edits.Env, image.EnvVarNvidiaVisibleDevices+"=void")
|
||||||
|
|
||||||
|
return edits, nil
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user