UniqAI/nvidia-container-toolkit
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvidia-container-toolkit synced 2025-05-29 09:43:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #980 from elezar/add-rprivate-to-mount-options
Some checks are pending
CI Pipeline / code-scanning (push) Waiting to run
Details
CI Pipeline / variables (push) Waiting to run
Details
CI Pipeline / golang (push) Waiting to run
Details
CI Pipeline / image (push) Blocked by required conditions
Details
CI Pipeline / e2e-test (push) Blocked by required conditions
Details

Browse Source 
Add rprivate to CDI mount options
This commit is contained in:
Evan Lezar 2025-05-16 07:53:39 +02:00 committed by GitHub
commit 6dfd63f4a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/nvidia-ctk-installer/toolkit/toolkit_test.go
View File

@ -109,7 +109,8 @@ containerEdits:
- ro
- nosuid
- nodev
- bind
- rbind
- rprivate
`,
},
}

3
cmd/nvidia-ctk/cdi/generate/generate_test.go
View File

@ -111,7 +111,8 @@ containerEdits:
- ro
- nosuid
- nodev
- bind
- rbind
- rprivate
`,
},
}

3
internal/discover/ipc_test.go
View File

@ -52,7 +52,8 @@ func TestIPCMounts(t *testing.T) {
"ro",
"nosuid",
"nodev",
"bind",
"rbind",
"rprivate",
"noexec",
},
},

3
internal/discover/mounts-to-container-path.go
View File

@ -71,7 +71,8 @@ func (d *mountsToContainerPath) Mounts() ([]Mount, error) {
"ro",
"nosuid",
"nodev",
"bind",
"rbind",
"rprivate",
},
}
mounts = append(mounts, mount)

3
internal/discover/mounts-to-container-path_test.go
View File

@ -32,7 +32,8 @@ func TestMountsToContainerPath(t *testing.T) {
"ro",
"nosuid",
"nodev",
"bind",
"rbind",
"rprivate",
}
testCases := []struct {

3
internal/discover/mounts.go
View File

@ -90,7 +90,8 @@ func (d *mounts) Mounts() ([]Mount, error) {
"ro",
"nosuid",
"nodev",
"bind",
"rbind",
"rprivate",
},
}
}

3
internal/discover/mounts_test.go
View File

@ -41,7 +41,8 @@ func TestMounts(t *testing.T) {
"ro",
"nosuid",
"nodev",
"bind",
"rbind",
"rprivate",
}
logger, logHook := testlog.NewNullLogger()

10
internal/platform-support/tegra/csv_test.go
View File

@ -79,12 +79,12 @@ func TestDiscovererFromCSVFiles(t *testing.T) {
{
Path: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
HostPath: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
Options: []string{"ro", "nosuid", "nodev", "bind"},
Options: []string{"ro", "nosuid", "nodev", "rbind", "rprivate"},
},
{
Path: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
HostPath: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
Options: []string{"ro", "nosuid", "nodev", "bind"},
Options: []string{"ro", "nosuid", "nodev", "rbind", "rprivate"},
},
},
expectedHooks: []discover.Hook{
@ -135,12 +135,12 @@ func TestDiscovererFromCSVFiles(t *testing.T) {
{
Path: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
HostPath: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
Options: []string{"ro", "nosuid", "nodev", "bind"},
Options: []string{"ro", "nosuid", "nodev", "rbind", "rprivate"},
},
{
Path: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
HostPath: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
Options: []string{"ro", "nosuid", "nodev", "bind"},
Options: []string{"ro", "nosuid", "nodev", "rbind", "rprivate"},
},
},
expectedHooks: []discover.Hook{
@ -175,7 +175,7 @@ func TestDiscovererFromCSVFiles(t *testing.T) {
{
Path: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
HostPath: "/usr/lib/aarch64-linux-gnu/tegra/libv4l2_nvargus.so",
Options: []string{"ro", "nosuid", "nodev", "bind"},
Options: []string{"ro", "nosuid", "nodev", "rbind", "rprivate"},
},
},
},