From 852a7a62a5c60fb3d51d1f19ddc7df18456b5a2f Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Mon, 19 Aug 2024 11:21:03 +0200 Subject: [PATCH 1/2] Use empty string for default runtime-config-override This change ensures that we unnecessarily print warnings for runtimes where these configs are not applicable. This removes the following warnings: WARN[0000] Ignoring runtime-config-override flag for docker Signed-off-by: Evan Lezar --- cmd/nvidia-ctk/runtime/configure/configure.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/nvidia-ctk/runtime/configure/configure.go b/cmd/nvidia-ctk/runtime/configure/configure.go index 6f8f42f3..6dc95913 100644 --- a/cmd/nvidia-ctk/runtime/configure/configure.go +++ b/cmd/nvidia-ctk/runtime/configure/configure.go @@ -160,7 +160,7 @@ func (m command) build() *cli.Command { Name: "runtime-config-override", Destination: &config.runtimeConfigOverrideJSON, Usage: "specify additional runtime options as a JSON string. The paths are relative to the runtime config.", - Value: "{}", + Value: "", EnvVars: []string{"RUNTIME_CONFIG_OVERRIDE"}, }, } From 6d7dd04824dc3b9226450235ea388fdc905d46bd Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Mon, 19 Aug 2024 11:36:16 +0200 Subject: [PATCH 2/2] [no-relnote] Fix lint error in test Signed-off-by: Evan Lezar --- internal/discover/mounts_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/discover/mounts_test.go b/internal/discover/mounts_test.go index c239db3a..40c46568 100644 --- a/internal/discover/mounts_test.go +++ b/internal/discover/mounts_test.go @@ -100,7 +100,7 @@ func TestMounts(t *testing.T) { lookup: &lookup.LocatorMock{ LocateFunc: func(s string) ([]string, error) { if s == "error" { - return nil, fmt.Errorf(s) + return nil, fmt.Errorf("error") } return []string{s}, nil },